aboutsummaryrefslogtreecommitdiffstats
path: root/drivers/net/ibmveth.c
diff options
context:
space:
mode:
authorSantiago Leon <santil@linux.vnet.ibm.com>2010-09-03 14:28:09 -0400
committerDavid S. Miller <davem@davemloft.net>2010-09-06 21:20:32 -0400
commitc033a6d1390bb6cc0c11c3b4137b856dfd8cb7c8 (patch)
treeff296183b963b75d0da43e3c809b58083316e3af /drivers/net/ibmveth.c
parenta613f581489aff23189c4945aec9567f6663b0c6 (diff)
ibmveth: batch rx buffer replacement
At the moment we try and replenish the receive ring on every rx interrupt. We even have a pool->threshold but aren't using it. To limit the maximum latency incurred when refilling, change the threshold from 1/2 to 7/8 and reduce the largest rx pool from 768 buffers to 512 which should be more than enough. Signed-off-by: Anton Blanchard <anton@samba.org> Signed-off-by: Santiago Leon <santil@linux.vnet.ibm.com> Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'drivers/net/ibmveth.c')
-rw-r--r--drivers/net/ibmveth.c13
1 files changed, 8 insertions, 5 deletions
diff --git a/drivers/net/ibmveth.c b/drivers/net/ibmveth.c
index d2cc6d3f401c..3515ef318eb0 100644
--- a/drivers/net/ibmveth.c
+++ b/drivers/net/ibmveth.c
@@ -178,7 +178,7 @@ static void ibmveth_init_buffer_pool(struct ibmveth_buff_pool *pool, u32 pool_in
178 pool->size = pool_size; 178 pool->size = pool_size;
179 pool->index = pool_index; 179 pool->index = pool_index;
180 pool->buff_size = buff_size; 180 pool->buff_size = buff_size;
181 pool->threshold = pool_size / 2; 181 pool->threshold = pool_size * 7 / 8;
182 pool->active = pool_active; 182 pool->active = pool_active;
183} 183}
184 184
@@ -315,10 +315,13 @@ static void ibmveth_replenish_task(struct ibmveth_adapter *adapter)
315 315
316 adapter->replenish_task_cycles++; 316 adapter->replenish_task_cycles++;
317 317
318 for (i = (IbmVethNumBufferPools - 1); i >= 0; i--) 318 for (i = (IbmVethNumBufferPools - 1); i >= 0; i--) {
319 if(adapter->rx_buff_pool[i].active) 319 struct ibmveth_buff_pool *pool = &adapter->rx_buff_pool[i];
320 ibmveth_replenish_buffer_pool(adapter, 320
321 &adapter->rx_buff_pool[i]); 321 if (pool->active &&
322 (atomic_read(&pool->available) < pool->threshold))
323 ibmveth_replenish_buffer_pool(adapter, pool);
324 }
322 325
323 adapter->rx_no_buffer = *(u64*)(((char*)adapter->buffer_list_addr) + 4096 - 8); 326 adapter->rx_no_buffer = *(u64*)(((char*)adapter->buffer_list_addr) + 4096 - 8);
324} 327}