drivers/net: Remove unnecessary k.alloc/v.alloc OOM messages

alloc failures use dump_stack so emitting an additional
out-of-memory message is an unnecessary duplication.

Remove the allocation failure messages.

Signed-off-by: Joe Perches <joe@perches.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

29 files changed, 39 insertions, 114 deletions

diff --git a/drivers/net/ethernet/amd/ni65.c b/drivers/net/ethernet/amd/ni65.c
index 6e6aa7213aab..735c213798b1 100644
--- a/drivers/net/ethernet/amd/ni65.c
+++ b/drivers/net/ethernet/amd/ni65.c
@@ -621,10 +621,8 @@ static void *ni65_alloc_mem(struct net_device *dev,char *what,int size,int type)
         }
         else {
                 ret = ptr = kmalloc(T_BUF_SIZE,GFP_KERNEL | GFP_DMA);
-                if(!ret) {
-                        printk(KERN_WARNING "%s: unable to allocate %s memory.\n",dev->name,what);
+                if(!ret)
                         return NULL;
-                }
         }
         if( (u32) virt_to_phys(ptr+size) > 0x1000000) {
                 printk(KERN_WARNING "%s: unable to allocate %s memory in lower 16MB!\n",dev->name,what);
diff --git a/drivers/net/ethernet/apple/bmac.c b/drivers/net/ethernet/apple/bmac.c
index d070b229dbf7..4108ac800cf0 100644
--- a/drivers/net/ethernet/apple/bmac.c
+++ b/drivers/net/ethernet/apple/bmac.c
@@ -1660,10 +1660,8 @@ static int __init bmac_init(void)
 {
         if (bmac_emergency_rxbuf == NULL) {
                 bmac_emergency_rxbuf = kmalloc(RX_BUFLEN, GFP_KERNEL);
-                if (bmac_emergency_rxbuf == NULL) {
-                        printk(KERN_ERR "BMAC: can't allocate emergency RX buffer\n");
+                if (bmac_emergency_rxbuf == NULL)
                         return -ENOMEM;
-                }
         }
 
         return macio_register_driver(&bmac_driver);
diff --git a/drivers/net/ethernet/apple/mace.c b/drivers/net/ethernet/apple/mace.c
index bec87bd9195c..45ba18ee3d6a 100644
--- a/drivers/net/ethernet/apple/mace.c
+++ b/drivers/net/ethernet/apple/mace.c
@@ -136,10 +136,8 @@ static int __devinit mace_probe(struct macio_dev *mdev, const struct of_device_i
          */
         if (dummy_buf == NULL) {
                 dummy_buf = kmalloc(RX_BUFLEN+2, GFP_KERNEL);
-                if (dummy_buf == NULL) {
-                        printk(KERN_ERR "MACE: couldn't allocate dummy buffer\n");
+                if (dummy_buf == NULL)
                         return -ENOMEM;
-                }
         }
 
         if (macio_request_resources(mdev, "mace")) {
diff --git a/drivers/net/ethernet/broadcom/bnx2.c b/drivers/net/ethernet/broadcom/bnx2.c
index 021fb818007a..0a4c5405dcf4 100644
--- a/drivers/net/ethernet/broadcom/bnx2.c
+++ b/drivers/net/ethernet/broadcom/bnx2.c
@@ -2625,10 +2625,8 @@ bnx2_alloc_bad_rbuf(struct bnx2 *bp)
         u32 val;
 
         good_mbuf = kmalloc(512 * sizeof(u16), GFP_KERNEL);
-        if (good_mbuf == NULL) {
-                pr_err("Failed to allocate memory in %s\n", __func__);
+        if (good_mbuf == NULL)
                 return -ENOMEM;
-        }
 
         REG_WR(bp, BNX2_MISC_ENABLE_SET_BITS,
                 BNX2_MISC_ENABLE_SET_BITS_RX_MBUF_ENABLE);
diff --git a/drivers/net/ethernet/broadcom/bnx2x/bnx2x_main.c b/drivers/net/ethernet/broadcom/bnx2x/bnx2x_main.c
index fea961505391..582cbcf5f9fb 100644
--- a/drivers/net/ethernet/broadcom/bnx2x/bnx2x_main.c
+++ b/drivers/net/ethernet/broadcom/bnx2x/bnx2x_main.c
@@ -10894,10 +10894,8 @@ static inline void be16_to_cpu_n(const u8 *_source, u8 *_target, u32 n)
 do {                                                                    \
         u32 len = be32_to_cpu(fw_hdr->arr.len);                         \
         bp->arr = kmalloc(len, GFP_KERNEL);                             \
-        if (!bp->arr) {                                                 \
-                pr_err("Failed to allocate %d bytes for "#arr"\n", len); \
+        if (!bp->arr)                                                   \
                 goto lbl;                                               \
-        }                                                               \
         func(bp->firmware->data + be32_to_cpu(fw_hdr->arr.offset),      \
              (u8 *)bp->arr, len);                                       \
 } while (0)
diff --git a/drivers/net/ethernet/brocade/bna/bnad_debugfs.c b/drivers/net/ethernet/brocade/bna/bnad_debugfs.c
index 592ad3929f53..c9fdceb135f3 100644
--- a/drivers/net/ethernet/brocade/bna/bnad_debugfs.c
+++ b/drivers/net/ethernet/brocade/bna/bnad_debugfs.c
@@ -62,8 +62,6 @@ bnad_debugfs_open_fwtrc(struct inode *inode, struct file *file)
         if (!fw_debug->debug_buffer) {
                 kfree(fw_debug);
                 fw_debug = NULL;
-                pr_warn("bna %s: Failed to allocate fwtrc buffer\n",
-                        pci_name(bnad->pcidev));
                 return -ENOMEM;
         }
 
@@ -105,8 +103,6 @@ bnad_debugfs_open_fwsave(struct inode *inode, struct file *file)
         if (!fw_debug->debug_buffer) {
                 kfree(fw_debug);
                 fw_debug = NULL;
-                pr_warn("bna %s: Failed to allocate fwsave buffer\n",
-                        pci_name(bnad->pcidev));
                 return -ENOMEM;
         }
 
@@ -208,8 +204,6 @@ bnad_debugfs_open_drvinfo(struct inode *inode, struct file *file)
         if (!drv_info->debug_buffer) {
                 kfree(drv_info);
                 drv_info = NULL;
-                pr_warn("bna %s: Failed to allocate drv info buffer\n",
-                        pci_name(bnad->pcidev));
                 return -ENOMEM;
         }
 
@@ -348,11 +342,8 @@ bnad_debugfs_write_regrd(struct file *file, const char __user *buf,
 
         /* Allocate memory to store the user space buf */
         kern_buf = kzalloc(nbytes, GFP_KERNEL);
-        if (!kern_buf) {
-                pr_warn("bna %s: Failed to allocate user buffer\n",
-                        pci_name(bnad->pcidev));
+        if (!kern_buf)
                 return -ENOMEM;
-        }
 
         if (copy_from_user(kern_buf, (void  __user *)buf, nbytes)) {
                 kfree(kern_buf);
@@ -373,11 +364,8 @@ bnad_debugfs_write_regrd(struct file *file, const char __user *buf,
         bnad->reglen = 0;
 
         bnad->regdata = kzalloc(len << 2, GFP_KERNEL);
-        if (!bnad->regdata) {
-                pr_warn("bna %s: Failed to allocate regrd buffer\n",
-                        pci_name(bnad->pcidev));
+        if (!bnad->regdata)
                 return -ENOMEM;
-        }
 
         bnad->reglen = len << 2;
         rb = bfa_ioc_bar0(ioc);
@@ -421,11 +409,8 @@ bnad_debugfs_write_regwr(struct file *file, const char __user *buf,
 
         /* Allocate memory to store the user space buf */
         kern_buf = kzalloc(nbytes, GFP_KERNEL);
-        if (!kern_buf) {
-                pr_warn("bna %s: Failed to allocate user buffer\n",
-                        pci_name(bnad->pcidev));
+        if (!kern_buf)
                 return -ENOMEM;
-        }
 
         if (copy_from_user(kern_buf, (void  __user *)buf, nbytes)) {
                 kfree(kern_buf);
diff --git a/drivers/net/ethernet/cisco/enic/enic_main.c b/drivers/net/ethernet/cisco/enic/enic_main.c
index ab3f67f980d8..07df13745c43 100644
--- a/drivers/net/ethernet/cisco/enic/enic_main.c
+++ b/drivers/net/ethernet/cisco/enic/enic_main.c
@@ -2388,7 +2388,6 @@ static int __devinit enic_probe(struct pci_dev *pdev,
         /* Allocate structure for port profiles */
         enic->pp = kcalloc(num_pps, sizeof(*enic->pp), GFP_KERNEL);
         if (!enic->pp) {
-                pr_err("port profile alloc failed, aborting\n");
                 err = -ENOMEM;
                 goto err_out_disable_sriov_pp;
         }
diff --git a/drivers/net/ethernet/cisco/enic/vnic_rq.c b/drivers/net/ethernet/cisco/enic/vnic_rq.c
index 34105e0951a5..7e1488fc8ab2 100644
--- a/drivers/net/ethernet/cisco/enic/vnic_rq.c
+++ b/drivers/net/ethernet/cisco/enic/vnic_rq.c
@@ -38,10 +38,8 @@ static int vnic_rq_alloc_bufs(struct vnic_rq *rq)
 
         for (i = 0; i < blks; i++) {
                 rq->bufs[i] = kzalloc(VNIC_RQ_BUF_BLK_SZ(count), GFP_ATOMIC);
-                if (!rq->bufs[i]) {
-                        pr_err("Failed to alloc rq_bufs\n");
+                if (!rq->bufs[i])
                         return -ENOMEM;
-                }
         }
 
         for (i = 0; i < blks; i++) {
diff --git a/drivers/net/ethernet/cisco/enic/vnic_wq.c b/drivers/net/ethernet/cisco/enic/vnic_wq.c
index df61bd932ea6..5e0d7a2be9bc 100644
--- a/drivers/net/ethernet/cisco/enic/vnic_wq.c
+++ b/drivers/net/ethernet/cisco/enic/vnic_wq.c
@@ -38,10 +38,8 @@ static int vnic_wq_alloc_bufs(struct vnic_wq *wq)
 
         for (i = 0; i < blks; i++) {
                 wq->bufs[i] = kzalloc(VNIC_WQ_BUF_BLK_SZ(count), GFP_ATOMIC);
-                if (!wq->bufs[i]) {
-                        pr_err("Failed to alloc wq_bufs\n");
+                if (!wq->bufs[i])
                         return -ENOMEM;
-                }
         }
 
         for (i = 0; i < blks; i++) {
diff --git a/drivers/net/ethernet/i825xx/lp486e.c b/drivers/net/ethernet/i825xx/lp486e.c
index 414044b3cb11..02df5f5accb1 100644
--- a/drivers/net/ethernet/i825xx/lp486e.c
+++ b/drivers/net/ethernet/i825xx/lp486e.c
@@ -454,8 +454,6 @@ init_rx_bufs(struct net_device *dev, int num) {
                         }
 
                         rfd->rbd = rbd;
-                } else {
-                        printk("Could not kmalloc rbd\n");
                 }
         }
         lp->rbd_tail->next = rfd->rbd;
diff --git a/drivers/net/ethernet/ibm/emac/rgmii.c b/drivers/net/ethernet/ibm/emac/rgmii.c
index 05484f918ee3..d3123282e18e 100644
--- a/drivers/net/ethernet/ibm/emac/rgmii.c
+++ b/drivers/net/ethernet/ibm/emac/rgmii.c
@@ -237,11 +237,8 @@ static int __devinit rgmii_probe(struct platform_device *ofdev)
 
         rc = -ENOMEM;
         dev = kzalloc(sizeof(struct rgmii_instance), GFP_KERNEL);
-        if (dev == NULL) {
-                printk(KERN_ERR "%s: could not allocate RGMII device!\n",
-                       np->full_name);
+        if (dev == NULL)
                 goto err_gone;
-        }
 
         mutex_init(&dev->lock);
         dev->ofdev = ofdev;
diff --git a/drivers/net/ethernet/ibm/emac/tah.c b/drivers/net/ethernet/ibm/emac/tah.c
index 0d9881efe2ff..872912ef518d 100644
--- a/drivers/net/ethernet/ibm/emac/tah.c
+++ b/drivers/net/ethernet/ibm/emac/tah.c
@@ -96,11 +96,8 @@ static int __devinit tah_probe(struct platform_device *ofdev)
 
         rc = -ENOMEM;
         dev = kzalloc(sizeof(struct tah_instance), GFP_KERNEL);
-        if (dev == NULL) {
-                printk(KERN_ERR "%s: could not allocate TAH device!\n",
-                       np->full_name);
+        if (dev == NULL)
                 goto err_gone;
-        }
 
         mutex_init(&dev->lock);
         dev->ofdev = ofdev;
diff --git a/drivers/net/ethernet/ibm/emac/zmii.c b/drivers/net/ethernet/ibm/emac/zmii.c
index e799a6116ba5..415e9b4d5408 100644
--- a/drivers/net/ethernet/ibm/emac/zmii.c
+++ b/drivers/net/ethernet/ibm/emac/zmii.c
@@ -240,11 +240,8 @@ static int __devinit zmii_probe(struct platform_device *ofdev)
 
         rc = -ENOMEM;
         dev = kzalloc(sizeof(struct zmii_instance), GFP_KERNEL);
-        if (dev == NULL) {
-                printk(KERN_ERR "%s: could not allocate ZMII device!\n",
-                       np->full_name);
+        if (dev == NULL)
                 goto err_gone;
-        }
 
         mutex_init(&dev->lock);
         dev->ofdev = ofdev;
diff --git a/drivers/net/ethernet/intel/e1000/e1000_main.c b/drivers/net/ethernet/intel/e1000/e1000_main.c
index 669ca3800c01..363fd395c75b 100644
--- a/drivers/net/ethernet/intel/e1000/e1000_main.c
+++ b/drivers/net/ethernet/intel/e1000/e1000_main.c
@@ -730,10 +730,8 @@ static void e1000_dump_eeprom(struct e1000_adapter *adapter)
         eeprom.offset = 0;
 
         data = kmalloc(eeprom.len, GFP_KERNEL);
-        if (!data) {
-                pr_err("Unable to allocate memory to dump EEPROM data\n");
+        if (!data)
                 return;
-        }
 
         ops->get_eeprom(netdev, &eeprom, data);
 
diff --git a/drivers/net/ethernet/intel/ixgb/ixgb_main.c b/drivers/net/ethernet/intel/ixgb/ixgb_main.c
index 9bd5faf64a85..002478801a1b 100644
--- a/drivers/net/ethernet/intel/ixgb/ixgb_main.c
+++ b/drivers/net/ethernet/intel/ixgb/ixgb_main.c
@@ -1136,10 +1136,8 @@ ixgb_set_multi(struct net_device *netdev)
                 u8 *mta = kmalloc(IXGB_MAX_NUM_MULTICAST_ADDRESSES *
                               ETH_ALEN, GFP_ATOMIC);
                 u8 *addr;
-                if (!mta) {
-                        pr_err("allocation of multicast memory failed\n");
+                if (!mta)
                         goto alloc_failed;
-                }
 
                 IXGB_WRITE_REG(hw, RCTL, rctl);
 
diff --git a/drivers/net/ethernet/intel/ixgbevf/ixgbevf_main.c b/drivers/net/ethernet/intel/ixgbevf/ixgbevf_main.c
index bed411bada21..f3bc9333a082 100644
--- a/drivers/net/ethernet/intel/ixgbevf/ixgbevf_main.c
+++ b/drivers/net/ethernet/intel/ixgbevf/ixgbevf_main.c
@@ -2517,12 +2517,8 @@ int ixgbevf_setup_rx_resources(struct ixgbevf_adapter *adapter,
 
         size = sizeof(struct ixgbevf_rx_buffer) * rx_ring->count;
         rx_ring->rx_buffer_info = vzalloc(size);
-        if (!rx_ring->rx_buffer_info) {
-                hw_dbg(&adapter->hw,
-                       "Unable to vmalloc buffer memory for "
-                       "the receive descriptor ring\n");
+        if (!rx_ring->rx_buffer_info)
                 goto alloc_failed;
-        }
 
         /* Round up to nearest 4K */
         rx_ring->size = rx_ring->count * sizeof(union ixgbe_adv_rx_desc);
diff --git a/drivers/net/ethernet/korina.c b/drivers/net/ethernet/korina.c
index 6ad094f176f8..341d10130dca 100644
--- a/drivers/net/ethernet/korina.c
+++ b/drivers/net/ethernet/korina.c
@@ -1150,7 +1150,6 @@ static int korina_probe(struct platform_device *pdev)
 
         lp->td_ring = kmalloc(TD_RING_SIZE + RD_RING_SIZE, GFP_KERNEL);
         if (!lp->td_ring) {
-                printk(KERN_ERR DRV_NAME ": cannot allocate descriptors\n");
                 rc = -ENXIO;
                 goto probe_err_td_ring;
         }
diff --git a/drivers/net/ethernet/marvell/pxa168_eth.c b/drivers/net/ethernet/marvell/pxa168_eth.c
index 953ba5851f7b..92b4b4e68e3b 100644
--- a/drivers/net/ethernet/marvell/pxa168_eth.c
+++ b/drivers/net/ethernet/marvell/pxa168_eth.c
@@ -1017,10 +1017,9 @@ static int rxq_init(struct net_device *dev)
         /* Allocate RX skb rings */
         pep->rx_skb = kmalloc(sizeof(*pep->rx_skb) * pep->rx_ring_size,
                              GFP_KERNEL);
-        if (!pep->rx_skb) {
-                printk(KERN_ERR "%s: Cannot alloc RX skb ring\n", dev->name);
+        if (!pep->rx_skb)
                 return -ENOMEM;
-        }
+
         /* Allocate RX ring */
         pep->rx_desc_count = 0;
         size = pep->rx_ring_size * sizeof(struct rx_desc);
@@ -1081,10 +1080,9 @@ static int txq_init(struct net_device *dev)
 
         pep->tx_skb = kmalloc(sizeof(*pep->tx_skb) * pep->tx_ring_size,
                              GFP_KERNEL);
-        if (!pep->tx_skb) {
-                printk(KERN_ERR "%s: Cannot alloc TX skb ring\n", dev->name);
+        if (!pep->tx_skb)
                 return -ENOMEM;
-        }
+
         /* Allocate TX ring */
         pep->tx_desc_count = 0;
         size = pep->tx_ring_size * sizeof(struct tx_desc);
diff --git a/drivers/net/ethernet/mellanox/mlx4/en_rx.c b/drivers/net/ethernet/mellanox/mlx4/en_rx.c
index 971d4b6b8dfe..f61d0e08f52b 100644
--- a/drivers/net/ethernet/mellanox/mlx4/en_rx.c
+++ b/drivers/net/ethernet/mellanox/mlx4/en_rx.c
@@ -281,10 +281,9 @@ int mlx4_en_create_rx_ring(struct mlx4_en_priv *priv,
         tmp = size * roundup_pow_of_two(MLX4_EN_MAX_RX_FRAGS *
                                         sizeof(struct skb_frag_struct));
         ring->rx_info = vmalloc(tmp);
-        if (!ring->rx_info) {
-                en_err(priv, "Failed allocating rx_info ring\n");
+        if (!ring->rx_info)
                 return -ENOMEM;
-        }
+
         en_dbg(DRV, priv, "Allocated rx_info ring at addr:%p size:%d\n",
                  ring->rx_info, tmp);
 
diff --git a/drivers/net/ethernet/mellanox/mlx4/en_tx.c b/drivers/net/ethernet/mellanox/mlx4/en_tx.c
index 9ef9038d0629..ff3250586584 100644
--- a/drivers/net/ethernet/mellanox/mlx4/en_tx.c
+++ b/drivers/net/ethernet/mellanox/mlx4/en_tx.c
@@ -71,16 +71,14 @@ int mlx4_en_create_tx_ring(struct mlx4_en_priv *priv,
 
         tmp = size * sizeof(struct mlx4_en_tx_info);
         ring->tx_info = vmalloc(tmp);
-        if (!ring->tx_info) {
-                en_err(priv, "Failed allocating tx_info ring\n");
+        if (!ring->tx_info)
                 return -ENOMEM;
-        }
+
         en_dbg(DRV, priv, "Allocated tx_info ring at addr:%p size:%d\n",
                  ring->tx_info, tmp);
 
         ring->bounce_buf = kmalloc(MAX_DESC_SIZE, GFP_KERNEL);
         if (!ring->bounce_buf) {
-                en_err(priv, "Failed allocating bounce buffer\n");
                 err = -ENOMEM;
                 goto err_tx;
         }
diff --git a/drivers/net/ethernet/micrel/ks8851_mll.c b/drivers/net/ethernet/micrel/ks8851_mll.c
index a37264e61a20..4a9d57fb9fb4 100644
--- a/drivers/net/ethernet/micrel/ks8851_mll.c
+++ b/drivers/net/ethernet/micrel/ks8851_mll.c
@@ -1501,10 +1501,8 @@ static int ks_hw_init(struct ks_net *ks)
         ks->mcast_lst_size = 0;
 
         ks->frame_head_info = kmalloc(MHEADER_SIZE, GFP_KERNEL);
-        if (!ks->frame_head_info) {
-                pr_err("Error: Fail to allocate frame memory\n");
+        if (!ks->frame_head_info)
                 return false;
-        }
 
         ks_set_mac(ks, KS_DEFAULT_MAC_ADDRESS);
         return true;
diff --git a/drivers/net/ethernet/oki-semi/pch_gbe/pch_gbe_main.c b/drivers/net/ethernet/oki-semi/pch_gbe/pch_gbe_main.c
index 3ead111111e1..0217991fede7 100644
--- a/drivers/net/ethernet/oki-semi/pch_gbe/pch_gbe_main.c
+++ b/drivers/net/ethernet/oki-semi/pch_gbe/pch_gbe_main.c
@@ -1587,10 +1587,8 @@ int pch_gbe_setup_tx_resources(struct pch_gbe_adapter *adapter,
 
         size = (int)sizeof(struct pch_gbe_buffer) * tx_ring->count;
         tx_ring->buffer_info = vzalloc(size);
-        if (!tx_ring->buffer_info) {
-                pr_err("Unable to allocate memory for the buffer information\n");
+        if (!tx_ring->buffer_info)
                 return -ENOMEM;
-        }
 
         tx_ring->size = tx_ring->count * (int)sizeof(struct pch_gbe_tx_desc);
 
@@ -1636,10 +1634,9 @@ int pch_gbe_setup_rx_resources(struct pch_gbe_adapter *adapter,
 
         size = (int)sizeof(struct pch_gbe_buffer) * rx_ring->count;
         rx_ring->buffer_info = vzalloc(size);
-        if (!rx_ring->buffer_info) {
-                pr_err("Unable to allocate memory for the receive descriptor ring\n");
+        if (!rx_ring->buffer_info)
                 return -ENOMEM;
-        }
+
         rx_ring->size = rx_ring->count * (int)sizeof(struct pch_gbe_rx_desc);
         rx_ring->desc = dma_alloc_coherent(&pdev->dev, rx_ring->size,
                                            &rx_ring->dma, GFP_KERNEL);
diff --git a/drivers/net/ethernet/qlogic/netxen/netxen_nic_init.c b/drivers/net/ethernet/qlogic/netxen/netxen_nic_init.c
index a8259cc19a63..094d26c51816 100644
--- a/drivers/net/ethernet/qlogic/netxen/netxen_nic_init.c
+++ b/drivers/net/ethernet/qlogic/netxen/netxen_nic_init.c
@@ -280,13 +280,10 @@ int netxen_alloc_sw_resources(struct netxen_adapter *adapter)
 
                 }
                 rds_ring->rx_buf_arr = vzalloc(RCV_BUFF_RINGSIZE(rds_ring));
-                if (rds_ring->rx_buf_arr == NULL) {
-                        printk(KERN_ERR "%s: Failed to allocate "
-                                "rx buffer ring %d\n",
-                                netdev->name, ring);
+                if (rds_ring->rx_buf_arr == NULL)
                         /* free whatever was already allocated */
                         goto err_out;
-                }
+
                 INIT_LIST_HEAD(&rds_ring->free_list);
                 /*
                  * Now go through all of them, set reference handles
@@ -480,11 +477,8 @@ int netxen_pinit_from_rom(struct netxen_adapter *adapter)
         }
 
         buf = kcalloc(n, sizeof(struct crb_addr_pair), GFP_KERNEL);
-        if (buf == NULL) {
-                printk("%s: netxen_pinit_from_rom: Unable to calloc memory.\n",
-                                netxen_nic_driver_name);
+        if (buf == NULL)
                 return -ENOMEM;
-        }
 
         for (i = 0; i < n; i++) {
                 if (netxen_rom_fast_read(adapter, 8*i + 4*offset, &val) != 0 ||
diff --git a/drivers/net/ethernet/qlogic/qlge/qlge_dbg.c b/drivers/net/ethernet/qlogic/qlge/qlge_dbg.c
index fca804f36d61..58185b604b72 100644
--- a/drivers/net/ethernet/qlogic/qlge/qlge_dbg.c
+++ b/drivers/net/ethernet/qlogic/qlge/qlge_dbg.c
@@ -1824,10 +1824,8 @@ void ql_dump_hw_cb(struct ql_adapter *qdev, int size, u32 bit, u16 q_id)
         pr_err("%s: Enter\n", __func__);
 
         ptr = kmalloc(size, GFP_ATOMIC);
-        if (ptr == NULL) {
-                pr_err("%s: Couldn't allocate a buffer\n", __func__);
+        if (ptr == NULL)
                 return;
-        }
 
         if (ql_write_cfg(qdev, ptr, size, bit, q_id)) {
                 pr_err("%s: Failed to upload control block!\n", __func__);
diff --git a/drivers/net/ethernet/sis/sis900.c b/drivers/net/ethernet/sis/sis900.c
index c8efc708c792..91c44688bc3e 100644
--- a/drivers/net/ethernet/sis/sis900.c
+++ b/drivers/net/ethernet/sis/sis900.c
@@ -619,7 +619,6 @@ static int __devinit sis900_mii_probe(struct net_device * net_dev)
                 }
 
                 if ((mii_phy = kmalloc(sizeof(struct mii_phy), GFP_KERNEL)) == NULL) {
-                        printk(KERN_WARNING "Cannot allocate mem for struct mii_phy\n");
                         mii_phy = sis_priv->first_mii;
                         while (mii_phy) {
                                 struct mii_phy *phy;
diff --git a/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c b/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c
index 96fa2da30763..ffc7581879b1 100644
--- a/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c
+++ b/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c
@@ -954,10 +954,9 @@ static int stmmac_open(struct net_device *dev)
 
 #ifdef CONFIG_STMMAC_TIMER
         priv->tm = kzalloc(sizeof(struct stmmac_timer *), GFP_KERNEL);
-        if (unlikely(priv->tm == NULL)) {
-                pr_err("%s: ERROR: timer memory alloc failed\n", __func__);
+        if (unlikely(priv->tm == NULL))
                 return -ENOMEM;
-        }
+
         priv->tm->freq = tmrate;
 
         /* Test if the external timer can be actually used.
diff --git a/drivers/net/ethernet/sun/cassini.c b/drivers/net/ethernet/sun/cassini.c
index f10665f594c4..46d84abe553d 100644
--- a/drivers/net/ethernet/sun/cassini.c
+++ b/drivers/net/ethernet/sun/cassini.c
@@ -835,7 +835,6 @@ static int cas_saturn_firmware_init(struct cas *cp)
         cp->fw_data = vmalloc(cp->fw_size);
         if (!cp->fw_data) {
                 err = -ENOMEM;
-                pr_err("\"%s\" Failed %d\n", fw_name, err);
                 goto out;
         }
         memcpy(cp->fw_data, &fw->data[2], cp->fw_size);
diff --git a/drivers/net/ethernet/sun/sunvnet.c b/drivers/net/ethernet/sun/sunvnet.c
index 8c6c059f3489..2896f6e9672b 100644
--- a/drivers/net/ethernet/sun/sunvnet.c
+++ b/drivers/net/ethernet/sun/sunvnet.c
@@ -949,10 +949,9 @@ static int __devinit vnet_port_alloc_tx_bufs(struct vnet_port *port)
                 int map_len = (ETH_FRAME_LEN + 7) & ~7;
 
                 err = -ENOMEM;
-                if (!buf) {
-                        pr_err("TX buffer allocation failure\n");
+                if (!buf)
                         goto err_out;
-                }
+
                 err = -EFAULT;
                 if ((unsigned long)buf & (8UL - 1)) {
                         pr_err("TX buffer misaligned\n");
@@ -1165,10 +1164,8 @@ static int __devinit vnet_port_probe(struct vio_dev *vdev,
 
         port = kzalloc(sizeof(*port), GFP_KERNEL);
         err = -ENOMEM;
-        if (!port) {
-                pr_err("Cannot allocate vnet_port\n");
+        if (!port)
                 goto err_out_put_mdesc;
-        }
 
         for (i = 0; i < ETH_ALEN; i++)
                 port->raddr[i] = (*rmac >> (5 - i) * 8) & 0xff;
diff --git a/drivers/net/ethernet/toshiba/ps3_gelic_wireless.c b/drivers/net/ethernet/toshiba/ps3_gelic_wireless.c
index fd4ed7f8cfa1..5c14f82c4954 100644
--- a/drivers/net/ethernet/toshiba/ps3_gelic_wireless.c
+++ b/drivers/net/ethernet/toshiba/ps3_gelic_wireless.c
@@ -1621,10 +1621,9 @@ static void gelic_wl_scan_complete_event(struct gelic_wl_info *wl)
                 kfree(target->hwinfo);
                 target->hwinfo = kzalloc(be16_to_cpu(scan_info->size),
                                          GFP_KERNEL);
-                if (!target->hwinfo) {
-                        pr_info("%s: kzalloc failed\n", __func__);
+                if (!target->hwinfo)
                         continue;
-                }
+
                 /* copy hw scan info */
                 memcpy(target->hwinfo, scan_info, scan_info->size);
                 target->essid_len = strnlen(scan_info->essid,