drivers/net: Convert compare_ether_addr to ether_addr_equal

Use the new bool function ether_addr_equal to add
some clarity and reduce the likelihood for misuse
of compare_ether_addr for sorting.

Done via cocci script:

$ cat compare_ether_addr.cocci
@@
expression a,b;
@@
-	!compare_ether_addr(a, b)
+	ether_addr_equal(a, b)

@@
expression a,b;
@@
-	compare_ether_addr(a, b)
+	!ether_addr_equal(a, b)

@@
expression a,b;
@@
-	!ether_addr_equal(a, b) == 0
+	ether_addr_equal(a, b)

@@
expression a,b;
@@
-	!ether_addr_equal(a, b) != 0
+	!ether_addr_equal(a, b)

@@
expression a,b;
@@
-	ether_addr_equal(a, b) == 0
+	!ether_addr_equal(a, b)

@@
expression a,b;
@@
-	ether_addr_equal(a, b) != 0
+	ether_addr_equal(a, b)

@@
expression a,b;
@@
-	!!ether_addr_equal(a, b)
+	ether_addr_equal(a, b)

Signed-off-by: Joe Perches <joe@perches.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

9 files changed, 18 insertions, 21 deletions

diff --git a/drivers/net/ethernet/amd/depca.c b/drivers/net/ethernet/amd/depca.c
index 86dd95766a64..7f7b99a5f024 100644
--- a/drivers/net/ethernet/amd/depca.c
+++ b/drivers/net/ethernet/amd/depca.c
@@ -1079,7 +1079,8 @@ static int depca_rx(struct net_device *dev)
                                                 } else {
                                                         lp->pktStats.multicast++;
                                                 }
-                                        } else if (compare_ether_addr(buf, dev->dev_addr) == 0) {
+                                        } else if (ether_addr_equal(buf,
+                                                                    dev->dev_addr)) {
                                                 lp->pktStats.unicast++;
                                         }
 
diff --git a/drivers/net/ethernet/cisco/enic/enic_main.c b/drivers/net/ethernet/cisco/enic/enic_main.c
index d7ac6c17547c..8132c785cea8 100644
--- a/drivers/net/ethernet/cisco/enic/enic_main.c
+++ b/drivers/net/ethernet/cisco/enic/enic_main.c
@@ -944,8 +944,7 @@ static void enic_update_multicast_addr_list(struct enic *enic)
 
         for (i = 0; i < enic->mc_count; i++) {
                 for (j = 0; j < mc_count; j++)
-                        if (compare_ether_addr(enic->mc_addr[i],
-                                mc_addr[j]) == 0)
+                        if (ether_addr_equal(enic->mc_addr[i], mc_addr[j]))
                                 break;
                 if (j == mc_count)
                         enic_dev_del_addr(enic, enic->mc_addr[i]);
@@ -953,8 +952,7 @@ static void enic_update_multicast_addr_list(struct enic *enic)
 
         for (i = 0; i < mc_count; i++) {
                 for (j = 0; j < enic->mc_count; j++)
-                        if (compare_ether_addr(mc_addr[i],
-                                enic->mc_addr[j]) == 0)
+                        if (ether_addr_equal(mc_addr[i], enic->mc_addr[j]))
                                 break;
                 if (j == enic->mc_count)
                         enic_dev_add_addr(enic, mc_addr[i]);
@@ -999,8 +997,7 @@ static void enic_update_unicast_addr_list(struct enic *enic)
 
         for (i = 0; i < enic->uc_count; i++) {
                 for (j = 0; j < uc_count; j++)
-                        if (compare_ether_addr(enic->uc_addr[i],
-                                uc_addr[j]) == 0)
+                        if (ether_addr_equal(enic->uc_addr[i], uc_addr[j]))
                                 break;
                 if (j == uc_count)
                         enic_dev_del_addr(enic, enic->uc_addr[i]);
@@ -1008,8 +1005,7 @@ static void enic_update_unicast_addr_list(struct enic *enic)
 
         for (i = 0; i < uc_count; i++) {
                 for (j = 0; j < enic->uc_count; j++)
-                        if (compare_ether_addr(uc_addr[i],
-                                enic->uc_addr[j]) == 0)
+                        if (ether_addr_equal(uc_addr[i], enic->uc_addr[j]))
                                 break;
                 if (j == enic->uc_count)
                         enic_dev_add_addr(enic, uc_addr[i]);
diff --git a/drivers/net/ethernet/dec/ewrk3.c b/drivers/net/ethernet/dec/ewrk3.c
index 1879f84a25a3..17ae8c619680 100644
--- a/drivers/net/ethernet/dec/ewrk3.c
+++ b/drivers/net/ethernet/dec/ewrk3.c
@@ -1016,7 +1016,8 @@ static int ewrk3_rx(struct net_device *dev)
                                                         } else {
                                                                 lp->pktStats.multicast++;
                                                         }
-                                                } else if (compare_ether_addr(p, dev->dev_addr) == 0) {
+                                                } else if (ether_addr_equal(p,
+                                                                            dev->dev_addr)) {
                                                         lp->pktStats.unicast++;
                                                 }
                                                 lp->pktStats.bins[0]++;         /* Duplicates stats.rx_packets */
diff --git a/drivers/net/ethernet/dec/tulip/de4x5.c b/drivers/net/ethernet/dec/tulip/de4x5.c
index 18b106cc6d2b..d3cd489d11a2 100644
--- a/drivers/net/ethernet/dec/tulip/de4x5.c
+++ b/drivers/net/ethernet/dec/tulip/de4x5.c
@@ -1874,7 +1874,7 @@ de4x5_local_stats(struct net_device *dev, char *buf, int pkt_len)
         } else {
             lp->pktStats.multicast++;
         }
-    } else if (compare_ether_addr(buf, dev->dev_addr) == 0) {
+    } else if (ether_addr_equal(buf, dev->dev_addr)) {
         lp->pktStats.unicast++;
     }
 
diff --git a/drivers/net/ethernet/qlogic/qlcnic/qlcnic_main.c b/drivers/net/ethernet/qlogic/qlcnic/qlcnic_main.c
index 5c4713521d4c..46e77a2c5121 100644
--- a/drivers/net/ethernet/qlogic/qlcnic/qlcnic_main.c
+++ b/drivers/net/ethernet/qlogic/qlcnic/qlcnic_main.c
@@ -1965,7 +1965,7 @@ qlcnic_send_filter(struct qlcnic_adapter *adapter,
         __le16 vlan_id = 0;
         u8 hindex;
 
-        if (!compare_ether_addr(phdr->h_source, adapter->mac_addr))
+        if (ether_addr_equal(phdr->h_source, adapter->mac_addr))
                 return;
 
         if (adapter->fhash.fnum >= adapter->fhash.fmax)
@@ -2235,8 +2235,7 @@ qlcnic_xmit_frame(struct sk_buff *skb, struct net_device *netdev)
 
         if (adapter->flags & QLCNIC_MACSPOOF) {
                 phdr = (struct ethhdr *)skb->data;
-                if (compare_ether_addr(phdr->h_source,
-                                        adapter->mac_addr))
+                if (!ether_addr_equal(phdr->h_source, adapter->mac_addr))
                         goto drop_packet;
         }
 
diff --git a/drivers/net/ethernet/sfc/ethtool.c b/drivers/net/ethernet/sfc/ethtool.c
index b0a4558de248..03ded364c8da 100644
--- a/drivers/net/ethernet/sfc/ethtool.c
+++ b/drivers/net/ethernet/sfc/ethtool.c
@@ -1023,7 +1023,7 @@ static int efx_ethtool_set_class_rule(struct efx_nic *efx,
                         return -EINVAL;
 
                 /* Is it a default UC or MC filter? */
-                if (!compare_ether_addr(mac_mask->h_dest, mac_addr_mc_mask) &&
+                if (ether_addr_equal(mac_mask->h_dest, mac_addr_mc_mask) &&
                     vlan_tag_mask == 0) {
                         if (is_multicast_ether_addr(mac_entry->h_dest))
                                 rc = efx_filter_set_mc_def(&spec);
diff --git a/drivers/net/ethernet/sun/sunvnet.c b/drivers/net/ethernet/sun/sunvnet.c
index 38e3ae9155b7..a108db35924e 100644
--- a/drivers/net/ethernet/sun/sunvnet.c
+++ b/drivers/net/ethernet/sun/sunvnet.c
@@ -618,7 +618,7 @@ struct vnet_port *__tx_port_find(struct vnet *vp, struct sk_buff *skb)
         struct vnet_port *port;
 
         hlist_for_each_entry(port, n, hp, hash) {
-                if (!compare_ether_addr(port->raddr, skb->data))
+                if (ether_addr_equal(port->raddr, skb->data))
                         return port;
         }
         port = NULL;
diff --git a/drivers/net/ethernet/tile/tilepro.c b/drivers/net/ethernet/tile/tilepro.c
index 3d501ec7fad7..96070e9b50dc 100644
--- a/drivers/net/ethernet/tile/tilepro.c
+++ b/drivers/net/ethernet/tile/tilepro.c
@@ -843,7 +843,7 @@ static bool tile_net_poll_aux(struct tile_net_cpu *info, int index)
                 if (!is_multicast_ether_addr(buf)) {
                         /* Filter packets not for our address. */
                         const u8 *mine = dev->dev_addr;
-                        filter = compare_ether_addr(mine, buf);
+                        filter = !ether_addr_equal(mine, buf);
                 }
         }
 
diff --git a/drivers/net/ethernet/toshiba/ps3_gelic_wireless.c b/drivers/net/ethernet/toshiba/ps3_gelic_wireless.c
index 5c14f82c4954..961c8321451f 100644
--- a/drivers/net/ethernet/toshiba/ps3_gelic_wireless.c
+++ b/drivers/net/ethernet/toshiba/ps3_gelic_wireless.c
@@ -1590,8 +1590,8 @@ static void gelic_wl_scan_complete_event(struct gelic_wl_info *wl)
                 found = 0;
                 oldest = NULL;
                 list_for_each_entry(target, &wl->network_list, list) {
-                        if (!compare_ether_addr(&target->hwinfo->bssid[2],
-                                                &scan_info->bssid[2])) {
+                        if (ether_addr_equal(&target->hwinfo->bssid[2],
+                                             &scan_info->bssid[2])) {
                                 found = 1;
                                 pr_debug("%s: same BBS found scanned list\n",
                                          __func__);
@@ -1691,8 +1691,8 @@ struct gelic_wl_scan_info *gelic_wl_find_best_bss(struct gelic_wl_info *wl)
 
                 /* If bss specified, check it only */
                 if (test_bit(GELIC_WL_STAT_BSSID_SET, &wl->stat)) {
-                        if (!compare_ether_addr(&scan_info->hwinfo->bssid[2],
-                                                wl->bssid)) {
+                        if (ether_addr_equal(&scan_info->hwinfo->bssid[2],
+                                             wl->bssid)) {
                                 best_bss = scan_info;
                                 pr_debug("%s: bssid matched\n", __func__);
                                 break;