ethtool: fix drvinfo strings set in drivers

Use strlcpy where possible to ensure the string is \0 terminated.
Use always sizeof(string) instead of 32, ETHTOOL_BUSINFO_LEN
and custom defines.
Use snprintf instead of sprint.
Remove unnecessary inits of ->fw_version
Remove unnecessary inits of drvinfo struct.

Signed-off-by: Jiri Pirko <jiri@resnulli.us>
Signed-off-by: David S. Miller <davem@davemloft.net>

1 files changed, 2 insertions, 3 deletions

diff --git a/drivers/net/ethernet/xilinx/xilinx_axienet_main.c b/drivers/net/ethernet/xilinx/xilinx_axienet_main.c
index d9f69b82cc4f..d3b3571b6013 100644
--- a/drivers/net/ethernet/xilinx/xilinx_axienet_main.c
+++ b/drivers/net/ethernet/xilinx/xilinx_axienet_main.c
@@ -1124,9 +1124,8 @@ static int axienet_ethtools_set_settings(struct net_device *ndev,
 static void axienet_ethtools_get_drvinfo(struct net_device *ndev,
                                          struct ethtool_drvinfo *ed)
 {
-        memset(ed, 0, sizeof(struct ethtool_drvinfo));
-        strcpy(ed->driver, DRIVER_NAME);
-        strcpy(ed->version, DRIVER_VERSION);
+        strlcpy(ed->driver, DRIVER_NAME, sizeof(ed->driver));
+        strlcpy(ed->version, DRIVER_VERSION, sizeof(ed->version));
         ed->regdump_len = sizeof(u32) * AXIENET_REGS_N;
 }