aboutsummaryrefslogtreecommitdiffstats
path: root/drivers/net/ethernet/sun/niu.c
diff options
context:
space:
mode:
authorJiri Pirko <jiri@resnulli.us>2013-01-07 20:38:26 -0500
committerDavid S. Miller <davem@davemloft.net>2013-01-08 21:00:48 -0500
commitaaeb6cdfa5c07533c2cd6d2c381374c69f7db9dc (patch)
treef6d51541dbee2d6e1810fd7b5e44d149b1a01750 /drivers/net/ethernet/sun/niu.c
parent948b337e62ca96b6e7de06fdd5f6fe44769d7e9c (diff)
remove init of dev->perm_addr in drivers
perm_addr is initialized correctly in register_netdevice() so to init it in drivers is no longer needed. Signed-off-by: Jiri Pirko <jiri@resnulli.us> Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'drivers/net/ethernet/sun/niu.c')
-rw-r--r--drivers/net/ethernet/sun/niu.c46
1 files changed, 20 insertions, 26 deletions
diff --git a/drivers/net/ethernet/sun/niu.c b/drivers/net/ethernet/sun/niu.c
index a0bdf0779466..c8c491564f9d 100644
--- a/drivers/net/ethernet/sun/niu.c
+++ b/drivers/net/ethernet/sun/niu.c
@@ -8366,14 +8366,12 @@ static void niu_pci_vpd_validate(struct niu *np)
8366 return; 8366 return;
8367 } 8367 }
8368 8368
8369 memcpy(dev->perm_addr, vpd->local_mac, ETH_ALEN); 8369 memcpy(dev->dev_addr, vpd->local_mac, ETH_ALEN);
8370 8370
8371 val8 = dev->perm_addr[5]; 8371 val8 = dev->dev_addr[5];
8372 dev->perm_addr[5] += np->port; 8372 dev->dev_addr[5] += np->port;
8373 if (dev->perm_addr[5] < val8) 8373 if (dev->dev_addr[5] < val8)
8374 dev->perm_addr[4]++; 8374 dev->dev_addr[4]++;
8375
8376 memcpy(dev->dev_addr, dev->perm_addr, dev->addr_len);
8377} 8375}
8378 8376
8379static int niu_pci_probe_sprom(struct niu *np) 8377static int niu_pci_probe_sprom(struct niu *np)
@@ -8470,29 +8468,27 @@ static int niu_pci_probe_sprom(struct niu *np)
8470 val = nr64(ESPC_MAC_ADDR0); 8468 val = nr64(ESPC_MAC_ADDR0);
8471 netif_printk(np, probe, KERN_DEBUG, np->dev, 8469 netif_printk(np, probe, KERN_DEBUG, np->dev,
8472 "SPROM: MAC_ADDR0[%08llx]\n", (unsigned long long)val); 8470 "SPROM: MAC_ADDR0[%08llx]\n", (unsigned long long)val);
8473 dev->perm_addr[0] = (val >> 0) & 0xff; 8471 dev->dev_addr[0] = (val >> 0) & 0xff;
8474 dev->perm_addr[1] = (val >> 8) & 0xff; 8472 dev->dev_addr[1] = (val >> 8) & 0xff;
8475 dev->perm_addr[2] = (val >> 16) & 0xff; 8473 dev->dev_addr[2] = (val >> 16) & 0xff;
8476 dev->perm_addr[3] = (val >> 24) & 0xff; 8474 dev->dev_addr[3] = (val >> 24) & 0xff;
8477 8475
8478 val = nr64(ESPC_MAC_ADDR1); 8476 val = nr64(ESPC_MAC_ADDR1);
8479 netif_printk(np, probe, KERN_DEBUG, np->dev, 8477 netif_printk(np, probe, KERN_DEBUG, np->dev,
8480 "SPROM: MAC_ADDR1[%08llx]\n", (unsigned long long)val); 8478 "SPROM: MAC_ADDR1[%08llx]\n", (unsigned long long)val);
8481 dev->perm_addr[4] = (val >> 0) & 0xff; 8479 dev->dev_addr[4] = (val >> 0) & 0xff;
8482 dev->perm_addr[5] = (val >> 8) & 0xff; 8480 dev->dev_addr[5] = (val >> 8) & 0xff;
8483 8481
8484 if (!is_valid_ether_addr(&dev->perm_addr[0])) { 8482 if (!is_valid_ether_addr(&dev->dev_addr[0])) {
8485 dev_err(np->device, "SPROM MAC address invalid [ %pM ]\n", 8483 dev_err(np->device, "SPROM MAC address invalid [ %pM ]\n",
8486 dev->perm_addr); 8484 dev->dev_addr);
8487 return -EINVAL; 8485 return -EINVAL;
8488 } 8486 }
8489 8487
8490 val8 = dev->perm_addr[5]; 8488 val8 = dev->dev_addr[5];
8491 dev->perm_addr[5] += np->port; 8489 dev->dev_addr[5] += np->port;
8492 if (dev->perm_addr[5] < val8) 8490 if (dev->dev_addr[5] < val8)
8493 dev->perm_addr[4]++; 8491 dev->dev_addr[4]++;
8494
8495 memcpy(dev->dev_addr, dev->perm_addr, dev->addr_len);
8496 8492
8497 val = nr64(ESPC_MOD_STR_LEN); 8493 val = nr64(ESPC_MOD_STR_LEN);
8498 netif_printk(np, probe, KERN_DEBUG, np->dev, 8494 netif_printk(np, probe, KERN_DEBUG, np->dev,
@@ -9267,16 +9263,14 @@ static int niu_get_of_props(struct niu *np)
9267 netdev_err(dev, "%s: OF MAC address prop len (%d) is wrong\n", 9263 netdev_err(dev, "%s: OF MAC address prop len (%d) is wrong\n",
9268 dp->full_name, prop_len); 9264 dp->full_name, prop_len);
9269 } 9265 }
9270 memcpy(dev->perm_addr, mac_addr, dev->addr_len); 9266 memcpy(dev->dev_addr, mac_addr, dev->addr_len);
9271 if (!is_valid_ether_addr(&dev->perm_addr[0])) { 9267 if (!is_valid_ether_addr(&dev->dev_addr[0])) {
9272 netdev_err(dev, "%s: OF MAC address is invalid\n", 9268 netdev_err(dev, "%s: OF MAC address is invalid\n",
9273 dp->full_name); 9269 dp->full_name);
9274 netdev_err(dev, "%s: [ %pM ]\n", dp->full_name, dev->perm_addr); 9270 netdev_err(dev, "%s: [ %pM ]\n", dp->full_name, dev->dev_addr);
9275 return -EINVAL; 9271 return -EINVAL;
9276 } 9272 }
9277 9273
9278 memcpy(dev->dev_addr, dev->perm_addr, dev->addr_len);
9279
9280 model = of_get_property(dp, "model", &prop_len); 9274 model = of_get_property(dp, "model", &prop_len);
9281 9275
9282 if (model) 9276 if (model)