qlcnic: Enhance virtual NIC logging

Signed-off-by: Manish Chopra <manish.chopra@qlogic.com>
Signed-off-by: Shahed Shaikh <shahed.shaikh@qlogic.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

3 files changed, 41 insertions, 40 deletions

diff --git a/drivers/net/ethernet/qlogic/qlcnic/qlcnic.h b/drivers/net/ethernet/qlogic/qlcnic/qlcnic.h
index e6f8beccbf3e..00a09573faab 100644
--- a/drivers/net/ethernet/qlogic/qlcnic/qlcnic.h
+++ b/drivers/net/ethernet/qlogic/qlcnic/qlcnic.h
@@ -442,6 +442,7 @@ struct qlcnic_hardware_context {
         u16 max_mtu;
         u32 msg_enable;
         u16 act_pci_func;
+        u16 max_pci_func;
 
         u32 capabilities;
         u32 capabilities2;
diff --git a/drivers/net/ethernet/qlogic/qlcnic/qlcnic_83xx_hw.c b/drivers/net/ethernet/qlogic/qlcnic/qlcnic_83xx_hw.c
index 1e699e6f29c8..f63a69570256 100644
--- a/drivers/net/ethernet/qlogic/qlcnic/qlcnic_83xx_hw.c
+++ b/drivers/net/ethernet/qlogic/qlcnic/qlcnic_83xx_hw.c
@@ -2134,26 +2134,25 @@ out:
 int qlcnic_83xx_get_pci_info(struct qlcnic_adapter *adapter,
                              struct qlcnic_pci_info *pci_info)
 {
+        struct qlcnic_hardware_context *ahw = adapter->ahw;
+        struct device *dev = &adapter->pdev->dev;
+        struct qlcnic_cmd_args cmd;
         int i, err = 0, j = 0;
         u32 temp;
-        struct qlcnic_cmd_args cmd;
 
         qlcnic_alloc_mbx_args(&cmd, adapter, QLCNIC_CMD_GET_PCI_INFO);
         err = qlcnic_issue_cmd(adapter, &cmd);
 
-        adapter->ahw->act_pci_func = 0;
+        ahw->act_pci_func = 0;
         if (err == QLCNIC_RCODE_SUCCESS) {
-                pci_info->func_count = cmd.rsp.arg[1] & 0xFF;
-                dev_info(&adapter->pdev->dev,
-                         "%s: total functions = %d\n",
-                         __func__, pci_info->func_count);
+                ahw->max_pci_func = cmd.rsp.arg[1] & 0xFF;
                 for (i = 2, j = 0; j < QLCNIC_MAX_PCI_FUNC; j++, pci_info++) {
                         pci_info->id = cmd.rsp.arg[i] & 0xFFFF;
                         pci_info->active = (cmd.rsp.arg[i] & 0xFFFF0000) >> 16;
                         i++;
                         pci_info->type = cmd.rsp.arg[i] & 0xFFFF;
                         if (pci_info->type == QLCNIC_TYPE_NIC)
-                                adapter->ahw->act_pci_func++;
+                                ahw->act_pci_func++;
                         temp = (cmd.rsp.arg[i] & 0xFFFF0000) >> 16;
                         pci_info->default_port = temp;
                         i++;
@@ -2165,18 +2164,21 @@ int qlcnic_83xx_get_pci_info(struct qlcnic_adapter *adapter,
                         i++;
                         memcpy(pci_info->mac + sizeof(u32), &cmd.rsp.arg[i], 2);
                         i = i + 3;
-
-                        dev_info(&adapter->pdev->dev, "%s:\n"
-                                 "\tid = %d active = %d type = %d\n"
-                                 "\tport = %d min bw = %d max bw = %d\n"
-                                 "\tmac_addr =  %pM\n", __func__,
-                                 pci_info->id, pci_info->active, pci_info->type,
-                                 pci_info->default_port, pci_info->tx_min_bw,
-                                 pci_info->tx_max_bw, pci_info->mac);
+                        if (ahw->op_mode == QLCNIC_MGMT_FUNC)
+                                dev_info(dev, "id = %d active = %d type = %d\n"
+                                         "\tport = %d min bw = %d max bw = %d\n"
+                                         "\tmac_addr =  %pM\n", pci_info->id,
+                                         pci_info->active, pci_info->type,
+                                         pci_info->default_port,
+                                         pci_info->tx_min_bw,
+                                         pci_info->tx_max_bw, pci_info->mac);
                 }
+                if (ahw->op_mode == QLCNIC_MGMT_FUNC)
+                        dev_info(dev, "Max vNIC functions = %d, active vNIC functions = %d\n",
+                                 ahw->max_pci_func, ahw->act_pci_func);
+
         } else {
-                dev_err(&adapter->pdev->dev, "Failed to get PCI Info%d\n",
-                        err);
+                dev_err(dev, "Failed to get PCI Info, error = %d\n", err);
                 err = -EIO;
         }
 
diff --git a/drivers/net/ethernet/qlogic/qlcnic/qlcnic_ctx.c b/drivers/net/ethernet/qlogic/qlcnic/qlcnic_ctx.c
index d63b5f728d75..9d0ae11589ce 100644
--- a/drivers/net/ethernet/qlogic/qlcnic/qlcnic_ctx.c
+++ b/drivers/net/ethernet/qlogic/qlcnic/qlcnic_ctx.c
@@ -883,11 +883,12 @@ int qlcnic_82xx_get_pci_info(struct qlcnic_adapter *adapter,
 
 /* Configure eSwitch for port mirroring */
 int qlcnic_config_port_mirroring(struct qlcnic_adapter *adapter, u8 id,
-                                u8 enable_mirroring, u8 pci_func)
+                                 u8 enable_mirroring, u8 pci_func)
 {
+        struct device *dev = &adapter->pdev->dev;
+        struct qlcnic_cmd_args cmd;
         int err = -EIO;
         u32 arg1;
-        struct qlcnic_cmd_args cmd;
 
         if (adapter->ahw->op_mode != QLCNIC_MGMT_FUNC ||
             !(adapter->eswitch[id].flags & QLCNIC_SWITCH_ENABLE))
@@ -901,13 +902,11 @@ int qlcnic_config_port_mirroring(struct qlcnic_adapter *adapter, u8 id,
         err = qlcnic_issue_cmd(adapter, &cmd);
 
         if (err != QLCNIC_RCODE_SUCCESS)
-                dev_err(&adapter->pdev->dev,
-                        "Failed to configure port mirroring%d on eswitch:%d\n",
+                dev_err(dev, "Failed to configure port mirroring for vNIC function %d on eSwitch %d\n",
                         pci_func, id);
         else
-                dev_info(&adapter->pdev->dev,
-                        "Configured eSwitch %d for port mirroring:%d\n",
-                        id, pci_func);
+                dev_info(dev, "Configured port mirroring for vNIC function %d on eSwitch %d\n",
+                         pci_func, id);
         qlcnic_free_mbx_args(&cmd);
 
         return err;
@@ -1122,14 +1121,13 @@ err_ret:
         return -EIO;
 }
 
-static int
-__qlcnic_get_eswitch_port_config(struct qlcnic_adapter *adapter,
-                                        u32 *arg1, u32 *arg2)
+static int __qlcnic_get_eswitch_port_config(struct qlcnic_adapter *adapter,
+                                            u32 *arg1, u32 *arg2)
 {
-        int err = -EIO;
+        struct device *dev = &adapter->pdev->dev;
         struct qlcnic_cmd_args cmd;
-        u8 pci_func;
-        pci_func = (*arg1 >> 8);
+        u8 pci_func = *arg1 >> 8;
+        int err = -EIO;
 
         qlcnic_alloc_mbx_args(&cmd, adapter,
                               QLCNIC_CMD_GET_ESWITCH_PORT_CONFIG);
@@ -1140,12 +1138,11 @@ __qlcnic_get_eswitch_port_config(struct qlcnic_adapter *adapter,
         qlcnic_free_mbx_args(&cmd);
 
         if (err == QLCNIC_RCODE_SUCCESS)
-                dev_info(&adapter->pdev->dev,
-                         "eSwitch port config for pci func %d\n", pci_func);
+                dev_info(dev, "Get eSwitch port config for vNIC function %d\n",
+                         pci_func);
         else
-                dev_err(&adapter->pdev->dev,
-                        "Failed to get eswitch port config for pci func %d\n",
-                                                                pci_func);
+                dev_err(dev, "Failed to get eswitch port config for vNIC function %d\n",
+                        pci_func);
         return err;
 }
 /* Configure eSwitch port
@@ -1158,9 +1155,10 @@ op_type = 1 for port vlan_id
 int qlcnic_config_switch_port(struct qlcnic_adapter *adapter,
                 struct qlcnic_esw_func_cfg *esw_cfg)
 {
+        struct device *dev = &adapter->pdev->dev;
+        struct qlcnic_cmd_args cmd;
         int err = -EIO, index;
         u32 arg1, arg2 = 0;
-        struct qlcnic_cmd_args cmd;
         u8 pci_func;
 
         if (adapter->ahw->op_mode != QLCNIC_MGMT_FUNC)
@@ -1217,11 +1215,11 @@ int qlcnic_config_switch_port(struct qlcnic_adapter *adapter,
         qlcnic_free_mbx_args(&cmd);
 
         if (err != QLCNIC_RCODE_SUCCESS)
-                dev_err(&adapter->pdev->dev,
-                        "Failed to configure eswitch pci func %d\n", pci_func);
+                dev_err(dev, "Failed to configure eswitch for vNIC function %d\n",
+                        pci_func);
         else
-                dev_info(&adapter->pdev->dev,
-                         "Configured eSwitch for pci func %d\n", pci_func);
+                dev_info(dev, "Configured eSwitch for vNIC function %d\n",
+                         pci_func);
 
         return err;
 }