diff options
author | Joachim Eastwood <manabian@gmail.com> | 2012-11-15 23:47:15 -0500 |
---|---|---|
committer | David S. Miller <davem@davemloft.net> | 2012-11-19 19:01:18 -0500 |
commit | c867b55eb4831a493631205f2744b2e77ce0983b (patch) | |
tree | c8d603edb45c8b7e97ce765f908efa5d60f4d76d /drivers/net/ethernet/nxp/lpc_eth.c | |
parent | ae4b46e9d7128d2d76e6857fe0b9fc240e8ac695 (diff) |
net/ethernet: remove useless is_valid_ether_addr from drivers ndo_open
If ndo_validate_addr is set to the generic eth_validate_addr
function there is no point in calling is_valid_ether_addr
from driver ndo_open if ndo_open is not used elsewhere in
the driver.
With this change is_valid_ether_addr will be called from the
generic eth_validate_addr function. So there should be no change
in the actual behavior.
Signed-off-by: Joachim Eastwood <manabian@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'drivers/net/ethernet/nxp/lpc_eth.c')
-rw-r--r-- | drivers/net/ethernet/nxp/lpc_eth.c | 4 |
1 files changed, 1 insertions, 3 deletions
diff --git a/drivers/net/ethernet/nxp/lpc_eth.c b/drivers/net/ethernet/nxp/lpc_eth.c index af8b4142088c..db6e1019be18 100644 --- a/drivers/net/ethernet/nxp/lpc_eth.c +++ b/drivers/net/ethernet/nxp/lpc_eth.c | |||
@@ -1219,9 +1219,6 @@ static int lpc_eth_open(struct net_device *ndev) | |||
1219 | if (netif_msg_ifup(pldat)) | 1219 | if (netif_msg_ifup(pldat)) |
1220 | dev_dbg(&pldat->pdev->dev, "enabling %s\n", ndev->name); | 1220 | dev_dbg(&pldat->pdev->dev, "enabling %s\n", ndev->name); |
1221 | 1221 | ||
1222 | if (!is_valid_ether_addr(ndev->dev_addr)) | ||
1223 | return -EADDRNOTAVAIL; | ||
1224 | |||
1225 | __lpc_eth_clock_enable(pldat, true); | 1222 | __lpc_eth_clock_enable(pldat, true); |
1226 | 1223 | ||
1227 | /* Reset and initialize */ | 1224 | /* Reset and initialize */ |
@@ -1301,6 +1298,7 @@ static const struct net_device_ops lpc_netdev_ops = { | |||
1301 | .ndo_set_rx_mode = lpc_eth_set_multicast_list, | 1298 | .ndo_set_rx_mode = lpc_eth_set_multicast_list, |
1302 | .ndo_do_ioctl = lpc_eth_ioctl, | 1299 | .ndo_do_ioctl = lpc_eth_ioctl, |
1303 | .ndo_set_mac_address = lpc_set_mac_address, | 1300 | .ndo_set_mac_address = lpc_set_mac_address, |
1301 | .ndo_validate_addr = eth_validate_addr, | ||
1304 | .ndo_change_mtu = eth_change_mtu, | 1302 | .ndo_change_mtu = eth_change_mtu, |
1305 | }; | 1303 | }; |
1306 | 1304 | ||