diff options
| author | Rick Jones <rick.jones2@hp.com> | 2011-11-07 08:29:27 -0500 |
|---|---|---|
| committer | David S. Miller <davem@davemloft.net> | 2011-11-08 15:11:57 -0500 |
| commit | 68aad78c5023b8aa82da99b47f9d8cf40e8ca453 (patch) | |
| tree | c9f90903bd2e7831ea6fc5231affa3b9fc908b73 /drivers/net/ethernet/natsemi | |
| parent | 34d2d89f2d7da3b72b3157e778bbf709047ded97 (diff) | |
sweep the floors and convert some .get_drvinfo routines to strlcpy
Per the mention made by Ben Hutchings that strlcpy is now the preferred
string copy routine for a .get_drvinfo routine, do a bit of floor
sweeping and convert some of the as-yet unconverted ethernet drivers to
it.
Signed-off-by: Rick Jones <rick.jones2@hp.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'drivers/net/ethernet/natsemi')
| -rw-r--r-- | drivers/net/ethernet/natsemi/natsemi.c | 6 | ||||
| -rw-r--r-- | drivers/net/ethernet/natsemi/ns83820.c | 6 |
2 files changed, 6 insertions, 6 deletions
diff --git a/drivers/net/ethernet/natsemi/natsemi.c b/drivers/net/ethernet/natsemi/natsemi.c index 6ca047aab793..ac7b16b6e7af 100644 --- a/drivers/net/ethernet/natsemi/natsemi.c +++ b/drivers/net/ethernet/natsemi/natsemi.c | |||
| @@ -2555,9 +2555,9 @@ static void set_rx_mode(struct net_device *dev) | |||
| 2555 | static void get_drvinfo(struct net_device *dev, struct ethtool_drvinfo *info) | 2555 | static void get_drvinfo(struct net_device *dev, struct ethtool_drvinfo *info) |
| 2556 | { | 2556 | { |
| 2557 | struct netdev_private *np = netdev_priv(dev); | 2557 | struct netdev_private *np = netdev_priv(dev); |
| 2558 | strncpy(info->driver, DRV_NAME, ETHTOOL_BUSINFO_LEN); | 2558 | strlcpy(info->driver, DRV_NAME, sizeof(info->driver)); |
| 2559 | strncpy(info->version, DRV_VERSION, ETHTOOL_BUSINFO_LEN); | 2559 | strlcpy(info->version, DRV_VERSION, sizeof(info->version)); |
| 2560 | strncpy(info->bus_info, pci_name(np->pci_dev), ETHTOOL_BUSINFO_LEN); | 2560 | strlcpy(info->bus_info, pci_name(np->pci_dev), sizeof(info->bus_info)); |
| 2561 | } | 2561 | } |
| 2562 | 2562 | ||
| 2563 | static int get_regs_len(struct net_device *dev) | 2563 | static int get_regs_len(struct net_device *dev) |
diff --git a/drivers/net/ethernet/natsemi/ns83820.c b/drivers/net/ethernet/natsemi/ns83820.c index 2b8f64ddfb55..c24b46cbfe27 100644 --- a/drivers/net/ethernet/natsemi/ns83820.c +++ b/drivers/net/ethernet/natsemi/ns83820.c | |||
| @@ -1364,9 +1364,9 @@ static int ns83820_set_settings(struct net_device *ndev, | |||
| 1364 | static void ns83820_get_drvinfo(struct net_device *ndev, struct ethtool_drvinfo *info) | 1364 | static void ns83820_get_drvinfo(struct net_device *ndev, struct ethtool_drvinfo *info) |
| 1365 | { | 1365 | { |
| 1366 | struct ns83820 *dev = PRIV(ndev); | 1366 | struct ns83820 *dev = PRIV(ndev); |
| 1367 | strcpy(info->driver, "ns83820"); | 1367 | strlcpy(info->driver, "ns83820", sizeof(info->driver)); |
| 1368 | strcpy(info->version, VERSION); | 1368 | strlcpy(info->version, VERSION, sizeof(info->version)); |
| 1369 | strcpy(info->bus_info, pci_name(dev->pci_dev)); | 1369 | strlcpy(info->bus_info, pci_name(dev->pci_dev), sizeof(info->bus_info)); |
| 1370 | } | 1370 | } |
| 1371 | 1371 | ||
| 1372 | static u32 ns83820_get_link(struct net_device *ndev) | 1372 | static u32 ns83820_get_link(struct net_device *ndev) |
