net/mlx4_core: Dynamic VST to VST vlan/qos changes

Within VST mode, enable modifying the vlan and/or qos
for a VF without requiring unbind/rebind.

This requires firmware which supports the UPDATE_QP command.
(If the command is not available, we fall back to requiring
unbind/bind to activate these changes).

To avoid race conditions with modify-qp on QPs that are affected
by update-qp, this operation is performed on the comm_wq.

If the update operation succeeds for all the necessary QPs, a
vlan_unregister is performed for the abandoned vlan id.

Signed-off-by: Jack Morgenstein <jackm@dev.mellanox.co.il>
Signed-off-by: Or Gerlitz <ogerlitz@mellanox.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

1 files changed, 117 insertions, 5 deletions

diff --git a/drivers/net/ethernet/mellanox/mlx4/cmd.c b/drivers/net/ethernet/mellanox/mlx4/cmd.c
index df04c8206ebe..7b927891dc35 100644
--- a/drivers/net/ethernet/mellanox/mlx4/cmd.c
+++ b/drivers/net/ethernet/mellanox/mlx4/cmd.c
@@ -112,6 +112,14 @@ enum {
         GO_BIT_TIMEOUT_MSECS    = 10000
 };
 
+enum mlx4_vlan_transition {
+        MLX4_VLAN_TRANSITION_VST_VST = 0,
+        MLX4_VLAN_TRANSITION_VST_VGT = 1,
+        MLX4_VLAN_TRANSITION_VGT_VST = 2,
+        MLX4_VLAN_TRANSITION_VGT_VGT = 3,
+};
+
+
 struct mlx4_cmd_context {
         struct completion       done;
         int                     result;
@@ -792,6 +800,15 @@ static int mlx4_MAD_IFC_wrapper(struct mlx4_dev *dev, int slave,
                                     vhcr->op, MLX4_CMD_TIME_CLASS_C, MLX4_CMD_NATIVE);
 }
 
+int MLX4_CMD_UPDATE_QP_wrapper(struct mlx4_dev *dev, int slave,
+                     struct mlx4_vhcr *vhcr,
+                     struct mlx4_cmd_mailbox *inbox,
+                     struct mlx4_cmd_mailbox *outbox,
+                     struct mlx4_cmd_info *cmd)
+{
+        return -EPERM;
+}
+
 int mlx4_DMA_wrapper(struct mlx4_dev *dev, int slave,
                      struct mlx4_vhcr *vhcr,
                      struct mlx4_cmd_mailbox *inbox,
@@ -1226,6 +1243,15 @@ static struct mlx4_cmd_info cmd_info[] = {
                 .wrapper = mlx4_GEN_QP_wrapper
         },
         {
+                .opcode = MLX4_CMD_UPDATE_QP,
+                .has_inbox = false,
+                .has_outbox = false,
+                .out_is_imm = false,
+                .encode_slave_id = false,
+                .verify = NULL,
+                .wrapper = MLX4_CMD_UPDATE_QP_wrapper
+        },
+        {
                 .opcode = MLX4_CMD_CONF_SPECIAL_QP,
                 .has_inbox = false,
                 .has_outbox = false,
@@ -1495,6 +1521,72 @@ out:
         return ret;
 }
 
+
+int mlx4_master_immediate_activate_vlan_qos(struct mlx4_priv *priv,
+                                            int slave, int port)
+{
+        struct mlx4_vport_oper_state *vp_oper;
+        struct mlx4_vport_state *vp_admin;
+        struct mlx4_vf_immed_vlan_work *work;
+        int err;
+        int admin_vlan_ix = NO_INDX;
+
+        vp_oper = &priv->mfunc.master.vf_oper[slave].vport[port];
+        vp_admin = &priv->mfunc.master.vf_admin[slave].vport[port];
+
+        if (vp_oper->state.default_vlan == vp_admin->default_vlan &&
+            vp_oper->state.default_qos == vp_admin->default_qos)
+                return 0;
+
+        work = kzalloc(sizeof(*work), GFP_KERNEL);
+        if (!work)
+                return -ENOMEM;
+
+        if (vp_oper->state.default_vlan != vp_admin->default_vlan) {
+                err = __mlx4_register_vlan(&priv->dev, port,
+                                           vp_admin->default_vlan,
+                                           &admin_vlan_ix);
+                if (err) {
+                        mlx4_warn((&priv->dev),
+                                  "No vlan resources slave %d, port %d\n",
+                                  slave, port);
+                        return err;
+                }
+                work->flags |= MLX4_VF_IMMED_VLAN_FLAG_VLAN;
+                mlx4_dbg((&(priv->dev)),
+                         "alloc vlan %d idx  %d slave %d port %d\n",
+                         (int)(vp_admin->default_vlan),
+                         admin_vlan_ix, slave, port);
+        }
+
+        /* save original vlan ix and vlan id */
+        work->orig_vlan_id = vp_oper->state.default_vlan;
+        work->orig_vlan_ix = vp_oper->vlan_idx;
+
+        /* handle new qos */
+        if (vp_oper->state.default_qos != vp_admin->default_qos)
+                work->flags |= MLX4_VF_IMMED_VLAN_FLAG_QOS;
+
+        if (work->flags & MLX4_VF_IMMED_VLAN_FLAG_VLAN)
+                vp_oper->vlan_idx = admin_vlan_ix;
+
+        vp_oper->state.default_vlan = vp_admin->default_vlan;
+        vp_oper->state.default_qos = vp_admin->default_qos;
+
+        /* iterate over QPs owned by this slave, using UPDATE_QP */
+        work->port = port;
+        work->slave = slave;
+        work->qos = vp_oper->state.default_qos;
+        work->vlan_id = vp_oper->state.default_vlan;
+        work->vlan_ix = vp_oper->vlan_idx;
+        work->priv = priv;
+        INIT_WORK(&work->work, mlx4_vf_immed_vlan_work_handler);
+        queue_work(priv->mfunc.master.comm_wq, &work->work);
+
+        return 0;
+}
+
+
 static int mlx4_master_activate_admin_state(struct mlx4_priv *priv, int slave)
 {
         int port, err;
@@ -2109,11 +2201,18 @@ int mlx4_set_vf_mac(struct mlx4_dev *dev, int port, int vf, u64 mac)
 }
 EXPORT_SYMBOL_GPL(mlx4_set_vf_mac);
 
+static int calculate_transition(u16 oper_vlan, u16 admin_vlan)
+{
+        return (2 * (oper_vlan == MLX4_VGT) + (admin_vlan == MLX4_VGT));
+}
+
 int mlx4_set_vf_vlan(struct mlx4_dev *dev, int port, int vf, u16 vlan, u8 qos)
 {
         struct mlx4_priv *priv = mlx4_priv(dev);
-        struct mlx4_vport_state *s_info;
+        struct mlx4_vport_oper_state *vf_oper;
+        struct mlx4_vport_state *vf_admin;
         int slave;
+        enum mlx4_vlan_transition vlan_trans;
 
         if ((!mlx4_is_master(dev)) ||
             !(dev->caps.flags2 & MLX4_DEV_CAP_FLAG2_VLAN_CONTROL))
@@ -2126,12 +2225,25 @@ int mlx4_set_vf_vlan(struct mlx4_dev *dev, int port, int vf, u16 vlan, u8 qos)
         if (slave < 0)
                 return -EINVAL;
 
-        s_info = &priv->mfunc.master.vf_admin[slave].vport[port];
+        vf_admin = &priv->mfunc.master.vf_admin[slave].vport[port];
+        vf_oper = &priv->mfunc.master.vf_oper[slave].vport[port];
+
         if ((0 == vlan) && (0 == qos))
-                s_info->default_vlan = MLX4_VGT;
+                vf_admin->default_vlan = MLX4_VGT;
         else
-                s_info->default_vlan = vlan;
-        s_info->default_qos = qos;
+                vf_admin->default_vlan = vlan;
+        vf_admin->default_qos = qos;
+
+        vlan_trans = calculate_transition(vf_oper->state.default_vlan,
+                                          vf_admin->default_vlan);
+
+        if (priv->mfunc.master.slave_state[slave].active &&
+            dev->caps.flags2 & MLX4_DEV_CAP_FLAG2_UPDATE_QP &&
+            vlan_trans == MLX4_VLAN_TRANSITION_VST_VST) {
+                mlx4_info(dev, "updating vf %d port %d config params immediately\n",
+                          vf, port);
+                mlx4_master_immediate_activate_vlan_qos(priv, slave, port);
+        }
         return 0;
 }
 EXPORT_SYMBOL_GPL(mlx4_set_vf_vlan);