diff options
author | Joe Perches <joe@perches.com> | 2012-03-18 13:37:58 -0400 |
---|---|---|
committer | David S. Miller <davem@davemloft.net> | 2012-03-19 16:53:08 -0400 |
commit | 449e39d9d7a889f4467ca7c590390e4a0f610b70 (patch) | |
tree | 0df5da259e3722792160ec88e53a0e080b69e506 /drivers/net/ethernet/intel/igbvf | |
parent | c81f212450e4d85ed1ed3777316e8355caeb3848 (diff) |
igbvf: Use ETH_ALEN
Remove an unnecessary #define and use memcpy
instead of a loop to copy an ethernet address.
Signed-off-by: Joe Perches <joe@perches.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'drivers/net/ethernet/intel/igbvf')
-rw-r--r-- | drivers/net/ethernet/intel/igbvf/defines.h | 4 | ||||
-rw-r--r-- | drivers/net/ethernet/intel/igbvf/vf.c | 7 |
2 files changed, 2 insertions, 9 deletions
diff --git a/drivers/net/ethernet/intel/igbvf/defines.h b/drivers/net/ethernet/intel/igbvf/defines.h index 33f40d3474ae..3e18045d8f89 100644 --- a/drivers/net/ethernet/intel/igbvf/defines.h +++ b/drivers/net/ethernet/intel/igbvf/defines.h | |||
@@ -97,10 +97,6 @@ | |||
97 | #define E1000_ERR_MAC_INIT 5 | 97 | #define E1000_ERR_MAC_INIT 5 |
98 | #define E1000_ERR_MBX 15 | 98 | #define E1000_ERR_MBX 15 |
99 | 99 | ||
100 | #ifndef ETH_ADDR_LEN | ||
101 | #define ETH_ADDR_LEN 6 | ||
102 | #endif | ||
103 | |||
104 | /* SRRCTL bit definitions */ | 100 | /* SRRCTL bit definitions */ |
105 | #define E1000_SRRCTL_BSIZEPKT_SHIFT 10 /* Shift _right_ */ | 101 | #define E1000_SRRCTL_BSIZEPKT_SHIFT 10 /* Shift _right_ */ |
106 | #define E1000_SRRCTL_BSIZEHDRSIZE_MASK 0x00000F00 | 102 | #define E1000_SRRCTL_BSIZEHDRSIZE_MASK 0x00000F00 |
diff --git a/drivers/net/ethernet/intel/igbvf/vf.c b/drivers/net/ethernet/intel/igbvf/vf.c index 19551977b352..30a6cc426037 100644 --- a/drivers/net/ethernet/intel/igbvf/vf.c +++ b/drivers/net/ethernet/intel/igbvf/vf.c | |||
@@ -246,7 +246,7 @@ static void e1000_update_mc_addr_list_vf(struct e1000_hw *hw, | |||
246 | for (i = 0; i < cnt; i++) { | 246 | for (i = 0; i < cnt; i++) { |
247 | hash_value = e1000_hash_mc_addr_vf(hw, mc_addr_list); | 247 | hash_value = e1000_hash_mc_addr_vf(hw, mc_addr_list); |
248 | hash_list[i] = hash_value & 0x0FFFF; | 248 | hash_list[i] = hash_value & 0x0FFFF; |
249 | mc_addr_list += ETH_ADDR_LEN; | 249 | mc_addr_list += ETH_ALEN; |
250 | } | 250 | } |
251 | 251 | ||
252 | mbx->ops.write_posted(hw, msgbuf, E1000_VFMAILBOX_SIZE); | 252 | mbx->ops.write_posted(hw, msgbuf, E1000_VFMAILBOX_SIZE); |
@@ -333,10 +333,7 @@ static void e1000_rar_set_vf(struct e1000_hw *hw, u8 * addr, u32 index) | |||
333 | **/ | 333 | **/ |
334 | static s32 e1000_read_mac_addr_vf(struct e1000_hw *hw) | 334 | static s32 e1000_read_mac_addr_vf(struct e1000_hw *hw) |
335 | { | 335 | { |
336 | int i; | 336 | memcpy(hw->mac.addr, hw->mac.perm_addr, ETH_ALEN); |
337 | |||
338 | for (i = 0; i < ETH_ADDR_LEN; i++) | ||
339 | hw->mac.addr[i] = hw->mac.perm_addr[i]; | ||
340 | 337 | ||
341 | return E1000_SUCCESS; | 338 | return E1000_SUCCESS; |
342 | } | 339 | } |