aboutsummaryrefslogtreecommitdiffstats
path: root/drivers/net/ethernet/intel/i40evf/i40evf_main.c
diff options
context:
space:
mode:
authorMitch Williams <mitch.a.williams@intel.com>2014-05-10 00:49:04 -0400
committerJeff Kirsher <jeffrey.t.kirsher@intel.com>2014-06-08 05:01:29 -0400
commit249c8b8d7e2d1bf9505dc46458537e77326c24fd (patch)
tree310078585460899c462c9d787ebf59b0e94bf866 /drivers/net/ethernet/intel/i40evf/i40evf_main.c
parenta5282f447d5e50cf285770226156a566e73687c2 (diff)
i40evf: remove unnecessary log messages
We don't need to print log messages when we encounter an out-of-memory condition, as the allocator will do this for us. Also, remove a Tx hang message that duplicates the one emitted by the netdev layer, and a duplicate message in the watchdog. Change-ID: If2056e6135fe248f66ea939778f9895660f4d189 Signed-off-by: Mitch Williams <mitch.a.williams@intel.com> Tested-by: Sibai Li <sibai.li@intel.com> Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
Diffstat (limited to 'drivers/net/ethernet/intel/i40evf/i40evf_main.c')
-rw-r--r--drivers/net/ethernet/intel/i40evf/i40evf_main.c19
1 files changed, 5 insertions, 14 deletions
diff --git a/drivers/net/ethernet/intel/i40evf/i40evf_main.c b/drivers/net/ethernet/intel/i40evf/i40evf_main.c
index feff317befb6..360a91188437 100644
--- a/drivers/net/ethernet/intel/i40evf/i40evf_main.c
+++ b/drivers/net/ethernet/intel/i40evf/i40evf_main.c
@@ -172,7 +172,6 @@ static void i40evf_tx_timeout(struct net_device *netdev)
172 struct i40evf_adapter *adapter = netdev_priv(netdev); 172 struct i40evf_adapter *adapter = netdev_priv(netdev);
173 173
174 adapter->tx_timeout_count++; 174 adapter->tx_timeout_count++;
175 dev_info(&adapter->pdev->dev, "TX timeout detected.\n");
176 if (!(adapter->flags & I40EVF_FLAG_RESET_PENDING)) { 175 if (!(adapter->flags & I40EVF_FLAG_RESET_PENDING)) {
177 adapter->flags |= I40EVF_FLAG_RESET_NEEDED; 176 adapter->flags |= I40EVF_FLAG_RESET_NEEDED;
178 schedule_work(&adapter->reset_task); 177 schedule_work(&adapter->reset_task);
@@ -662,12 +661,9 @@ i40evf_vlan_filter *i40evf_add_vlan(struct i40evf_adapter *adapter, u16 vlan)
662 f = i40evf_find_vlan(adapter, vlan); 661 f = i40evf_find_vlan(adapter, vlan);
663 if (NULL == f) { 662 if (NULL == f) {
664 f = kzalloc(sizeof(*f), GFP_ATOMIC); 663 f = kzalloc(sizeof(*f), GFP_ATOMIC);
665 if (NULL == f) { 664 if (NULL == f)
666 dev_info(&adapter->pdev->dev,
667 "%s: no memory for new VLAN filter\n",
668 __func__);
669 return NULL; 665 return NULL;
670 } 666
671 f->vlan = vlan; 667 f->vlan = vlan;
672 668
673 INIT_LIST_HEAD(&f->list); 669 INIT_LIST_HEAD(&f->list);
@@ -771,8 +767,6 @@ i40evf_mac_filter *i40evf_add_filter(struct i40evf_adapter *adapter,
771 if (NULL == f) { 767 if (NULL == f) {
772 f = kzalloc(sizeof(*f), GFP_ATOMIC); 768 f = kzalloc(sizeof(*f), GFP_ATOMIC);
773 if (NULL == f) { 769 if (NULL == f) {
774 dev_info(&adapter->pdev->dev,
775 "%s: no memory for new filter\n", __func__);
776 clear_bit(__I40EVF_IN_CRITICAL_TASK, 770 clear_bit(__I40EVF_IN_CRITICAL_TASK,
777 &adapter->crit_section); 771 &adapter->crit_section);
778 return NULL; 772 return NULL;
@@ -1332,8 +1326,7 @@ static void i40evf_watchdog_task(struct work_struct *work)
1332 (rd32(hw, I40E_VFGEN_RSTAT) & 0x3) != I40E_VFR_VFACTIVE) { 1326 (rd32(hw, I40E_VFGEN_RSTAT) & 0x3) != I40E_VFR_VFACTIVE) {
1333 adapter->state = __I40EVF_RESETTING; 1327 adapter->state = __I40EVF_RESETTING;
1334 adapter->flags |= I40EVF_FLAG_RESET_PENDING; 1328 adapter->flags |= I40EVF_FLAG_RESET_PENDING;
1335 dev_err(&adapter->pdev->dev, "Hardware reset detected.\n"); 1329 dev_err(&adapter->pdev->dev, "Hardware reset detected\n");
1336 dev_info(&adapter->pdev->dev, "Scheduling reset task\n");
1337 schedule_work(&adapter->reset_task); 1330 schedule_work(&adapter->reset_task);
1338 adapter->aq_pending = 0; 1331 adapter->aq_pending = 0;
1339 adapter->aq_required = 0; 1332 adapter->aq_required = 0;
@@ -1610,11 +1603,9 @@ static void i40evf_adminq_task(struct work_struct *work)
1610 1603
1611 event.msg_size = I40EVF_MAX_AQ_BUF_SIZE; 1604 event.msg_size = I40EVF_MAX_AQ_BUF_SIZE;
1612 event.msg_buf = kzalloc(event.msg_size, GFP_KERNEL); 1605 event.msg_buf = kzalloc(event.msg_size, GFP_KERNEL);
1613 if (!event.msg_buf) { 1606 if (!event.msg_buf)
1614 dev_info(&adapter->pdev->dev, "%s: no memory for ARQ clean\n",
1615 __func__);
1616 return; 1607 return;
1617 } 1608
1618 v_msg = (struct i40e_virtchnl_msg *)&event.desc; 1609 v_msg = (struct i40e_virtchnl_msg *)&event.desc;
1619 do { 1610 do {
1620 ret = i40evf_clean_arq_element(hw, &event, &pending); 1611 ret = i40evf_clean_arq_element(hw, &event, &pending);