diff options
author | Jesse Brandeburg <jesse.brandeburg@intel.com> | 2013-11-28 01:39:27 -0500 |
---|---|---|
committer | Jeff Kirsher <jeffrey.t.kirsher@intel.com> | 2014-01-05 01:13:45 -0500 |
commit | f62b5060d6701dcc8c072f7fc2160f71a2cbc183 (patch) | |
tree | ce3572cf5ca1f29d4762bd4970d654dbcedac489 /drivers/net/ethernet/intel/i40e/i40e_common.c | |
parent | a45e88c9db90c869365d8e258989639a09cf19dc (diff) |
i40e: fix mac address checking
Remove custom i40e functions around ethernet addresses that are
duplicating already existing kernel functionality.
Also ends up fixing a bug with multicast addresses.
Signed-off-by: Jesse Brandeburg <jesse.brandeburg@intel.com>
Tested-by: Kavindya Deegala <kavindya.s.deegala@intel.com>
Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
Diffstat (limited to 'drivers/net/ethernet/intel/i40e/i40e_common.c')
-rw-r--r-- | drivers/net/ethernet/intel/i40e/i40e_common.c | 27 |
1 files changed, 0 insertions, 27 deletions
diff --git a/drivers/net/ethernet/intel/i40e/i40e_common.c b/drivers/net/ethernet/intel/i40e/i40e_common.c index d84fca1b3f28..e5694b9f4e95 100644 --- a/drivers/net/ethernet/intel/i40e/i40e_common.c +++ b/drivers/net/ethernet/intel/i40e/i40e_common.c | |||
@@ -240,33 +240,6 @@ i40e_status i40e_get_mac_addr(struct i40e_hw *hw, u8 *mac_addr) | |||
240 | } | 240 | } |
241 | 241 | ||
242 | /** | 242 | /** |
243 | * i40e_validate_mac_addr - Validate MAC address | ||
244 | * @mac_addr: pointer to MAC address | ||
245 | * | ||
246 | * Tests a MAC address to ensure it is a valid Individual Address | ||
247 | **/ | ||
248 | i40e_status i40e_validate_mac_addr(u8 *mac_addr) | ||
249 | { | ||
250 | i40e_status status = 0; | ||
251 | |||
252 | /* Make sure it is not a multicast address */ | ||
253 | if (I40E_IS_MULTICAST(mac_addr)) { | ||
254 | hw_dbg(hw, "MAC address is multicast\n"); | ||
255 | status = I40E_ERR_INVALID_MAC_ADDR; | ||
256 | /* Not a broadcast address */ | ||
257 | } else if (I40E_IS_BROADCAST(mac_addr)) { | ||
258 | hw_dbg(hw, "MAC address is broadcast\n"); | ||
259 | status = I40E_ERR_INVALID_MAC_ADDR; | ||
260 | /* Reject the zero address */ | ||
261 | } else if (mac_addr[0] == 0 && mac_addr[1] == 0 && mac_addr[2] == 0 && | ||
262 | mac_addr[3] == 0 && mac_addr[4] == 0 && mac_addr[5] == 0) { | ||
263 | hw_dbg(hw, "MAC address is all zeros\n"); | ||
264 | status = I40E_ERR_INVALID_MAC_ADDR; | ||
265 | } | ||
266 | return status; | ||
267 | } | ||
268 | |||
269 | /** | ||
270 | * i40e_get_media_type - Gets media type | 243 | * i40e_get_media_type - Gets media type |
271 | * @hw: pointer to the hardware structure | 244 | * @hw: pointer to the hardware structure |
272 | **/ | 245 | **/ |