aboutsummaryrefslogtreecommitdiffstats
path: root/drivers/net/ethernet/intel/e1000e/82571.c
diff options
context:
space:
mode:
authorTushar Dave <tushar.n.dave@intel.com>2012-07-30 22:02:43 -0400
committerPeter P Waskiewicz Jr <peter.p.waskiewicz.jr@intel.com>2012-08-07 03:40:08 -0400
commitb7ec70be01a87f2c85df3ae11046e74f9b67e323 (patch)
tree046a28fb61ae7df7e3fe60451f8d69044f73e9c1 /drivers/net/ethernet/intel/e1000e/82571.c
parent5d299f3d3c8a2fbc732b1bf03af36333ccec3130 (diff)
e1000e: NIC goes up and immediately goes down
Found that commit d478eb44 was a bad commit. If the link partner is transmitting codeword (even if NULL codeword), then the RXCW.C bit will be set so check for RXCW.CW is unnecessary. Ref: RH BZ 840642 Reported-by: Fabio Futigami <ffutigam@redhat.com> Signed-off-by: Tushar Dave <tushar.n.dave@intel.com> CC: Marcelo Ricardo Leitner <mleitner@redhat.com> CC: stable <stable@vger.kernel.org> [2.6.38+] Tested-by: Aaron Brown <aaron.f.brown@intel.com> Signed-off-by: Peter P Waskiewicz Jr <peter.p.waskiewicz.jr@intel.com>
Diffstat (limited to 'drivers/net/ethernet/intel/e1000e/82571.c')
-rw-r--r--drivers/net/ethernet/intel/e1000e/82571.c4
1 files changed, 1 insertions, 3 deletions
diff --git a/drivers/net/ethernet/intel/e1000e/82571.c b/drivers/net/ethernet/intel/e1000e/82571.c
index 0b3bade957fd..2a4ded2fd6e5 100644
--- a/drivers/net/ethernet/intel/e1000e/82571.c
+++ b/drivers/net/ethernet/intel/e1000e/82571.c
@@ -1601,10 +1601,8 @@ static s32 e1000_check_for_serdes_link_82571(struct e1000_hw *hw)
1601 * auto-negotiation in the TXCW register and disable 1601 * auto-negotiation in the TXCW register and disable
1602 * forced link in the Device Control register in an 1602 * forced link in the Device Control register in an
1603 * attempt to auto-negotiate with our link partner. 1603 * attempt to auto-negotiate with our link partner.
1604 * If the partner code word is null, stop forcing
1605 * and restart auto negotiation.
1606 */ 1604 */
1607 if ((rxcw & E1000_RXCW_C) || !(rxcw & E1000_RXCW_CW)) { 1605 if (rxcw & E1000_RXCW_C) {
1608 /* Enable autoneg, and unforce link up */ 1606 /* Enable autoneg, and unforce link up */
1609 ew32(TXCW, mac->txcw); 1607 ew32(TXCW, mac->txcw);
1610 ew32(CTRL, (ctrl & ~E1000_CTRL_SLU)); 1608 ew32(CTRL, (ctrl & ~E1000_CTRL_SLU));