aboutsummaryrefslogtreecommitdiffstats
path: root/drivers/net/ethernet/intel/e1000/e1000.h
diff options
context:
space:
mode:
authorDean Nelson <dnelson@redhat.com>2011-08-25 10:39:24 -0400
committerDavid S. Miller <davem@davemloft.net>2011-08-26 12:55:18 -0400
commit31c15a2f24ebdab14333d9bf5df49757842ae2ec (patch)
treeef89d4b94c4f41f6d18c923490441189ff95b52d /drivers/net/ethernet/intel/e1000/e1000.h
parent363437f40a23bacdead80bb80d08d8193a20cfce (diff)
e1000: save skb counts in TX to avoid cache misses
Virtual Machines with emulated e1000 network adapter running on Parallels' server were seeing kernel panics due to the e1000 driver dereferencing an unexpected NULL pointer retrieved from buffer_info->skb. The problem has been addressed for the e1000e driver, but not for the e1000. Since the two drivers share similar code in the affected area, a port of the following e1000e driver commit solves the issue for the e1000 driver: commit 9ed318d546a29d7a591dbe648fd1a2efe3be1180 Author: Tom Herbert <therbert@google.com> Date: Wed May 5 14:02:27 2010 +0000 e1000e: save skb counts in TX to avoid cache misses In e1000_tx_map, precompute number of segements and bytecounts which are derived from fields in skb; these are stored in buffer_info. When cleaning tx in e1000_clean_tx_irq use the values in the associated buffer_info for statistics counting, this eliminates cache misses on skb fields. Signed-off-by: Dean Nelson <dnelson@redhat.com> Acked-by: Jeff Kirsher <jeffrey.t.kirsher@intel.com> Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'drivers/net/ethernet/intel/e1000/e1000.h')
-rw-r--r--drivers/net/ethernet/intel/e1000/e1000.h2
1 files changed, 2 insertions, 0 deletions
diff --git a/drivers/net/ethernet/intel/e1000/e1000.h b/drivers/net/ethernet/intel/e1000/e1000.h
index 24f41da8c4be..4ea87b19ac1a 100644
--- a/drivers/net/ethernet/intel/e1000/e1000.h
+++ b/drivers/net/ethernet/intel/e1000/e1000.h
@@ -150,6 +150,8 @@ struct e1000_buffer {
150 unsigned long time_stamp; 150 unsigned long time_stamp;
151 u16 length; 151 u16 length;
152 u16 next_to_watch; 152 u16 next_to_watch;
153 unsigned int segs;
154 unsigned int bytecount;
153 u16 mapped_as_page; 155 u16 mapped_as_page;
154}; 156};
155 157