diff options
author | Kyle Moffett <Kyle.D.Moffett@boeing.com> | 2011-11-14 21:32:10 -0500 |
---|---|---|
committer | Benjamin Herrenschmidt <benh@kernel.crashing.org> | 2015-03-16 20:25:50 -0400 |
commit | b05ae4ee602b7dc90771408ccf0972e1b3801a35 (patch) | |
tree | 920cd6b70fcbd4fe86375b6f59618edc9948e3a8 /drivers/net/ethernet/ibm/emac | |
parent | 9eccca0843205f87c00404b663188b88eb248051 (diff) |
powerpc: Remove duplicate cacheable_memcpy/memzero functions
These functions are only used from one place each. If the cacheable_*
versions really are more efficient, then those changes should be
migrated into the common code instead.
NOTE: The old routines are just flat buggy on kernels that support
hardware with different cacheline sizes.
Signed-off-by: Kyle Moffett <Kyle.D.Moffett@boeing.com>
Signed-off-by: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Diffstat (limited to 'drivers/net/ethernet/ibm/emac')
-rw-r--r-- | drivers/net/ethernet/ibm/emac/core.c | 12 |
1 files changed, 2 insertions, 10 deletions
diff --git a/drivers/net/ethernet/ibm/emac/core.c b/drivers/net/ethernet/ibm/emac/core.c index 162762d1a12c..220bae6f5e43 100644 --- a/drivers/net/ethernet/ibm/emac/core.c +++ b/drivers/net/ethernet/ibm/emac/core.c | |||
@@ -79,13 +79,6 @@ MODULE_AUTHOR | |||
79 | ("Eugene Surovegin <eugene.surovegin@zultys.com> or <ebs@ebshome.net>"); | 79 | ("Eugene Surovegin <eugene.surovegin@zultys.com> or <ebs@ebshome.net>"); |
80 | MODULE_LICENSE("GPL"); | 80 | MODULE_LICENSE("GPL"); |
81 | 81 | ||
82 | /* | ||
83 | * PPC64 doesn't (yet) have a cacheable_memcpy | ||
84 | */ | ||
85 | #ifdef CONFIG_PPC64 | ||
86 | #define cacheable_memcpy(d,s,n) memcpy((d),(s),(n)) | ||
87 | #endif | ||
88 | |||
89 | /* minimum number of free TX descriptors required to wake up TX process */ | 82 | /* minimum number of free TX descriptors required to wake up TX process */ |
90 | #define EMAC_TX_WAKEUP_THRESH (NUM_TX_BUFF / 4) | 83 | #define EMAC_TX_WAKEUP_THRESH (NUM_TX_BUFF / 4) |
91 | 84 | ||
@@ -1673,7 +1666,7 @@ static inline int emac_rx_sg_append(struct emac_instance *dev, int slot) | |||
1673 | dev_kfree_skb(dev->rx_sg_skb); | 1666 | dev_kfree_skb(dev->rx_sg_skb); |
1674 | dev->rx_sg_skb = NULL; | 1667 | dev->rx_sg_skb = NULL; |
1675 | } else { | 1668 | } else { |
1676 | cacheable_memcpy(skb_tail_pointer(dev->rx_sg_skb), | 1669 | memcpy(skb_tail_pointer(dev->rx_sg_skb), |
1677 | dev->rx_skb[slot]->data, len); | 1670 | dev->rx_skb[slot]->data, len); |
1678 | skb_put(dev->rx_sg_skb, len); | 1671 | skb_put(dev->rx_sg_skb, len); |
1679 | emac_recycle_rx_skb(dev, slot, len); | 1672 | emac_recycle_rx_skb(dev, slot, len); |
@@ -1730,8 +1723,7 @@ static int emac_poll_rx(void *param, int budget) | |||
1730 | goto oom; | 1723 | goto oom; |
1731 | 1724 | ||
1732 | skb_reserve(copy_skb, EMAC_RX_SKB_HEADROOM + 2); | 1725 | skb_reserve(copy_skb, EMAC_RX_SKB_HEADROOM + 2); |
1733 | cacheable_memcpy(copy_skb->data - 2, skb->data - 2, | 1726 | memcpy(copy_skb->data - 2, skb->data - 2, len + 2); |
1734 | len + 2); | ||
1735 | emac_recycle_rx_skb(dev, slot, len); | 1727 | emac_recycle_rx_skb(dev, slot, len); |
1736 | skb = copy_skb; | 1728 | skb = copy_skb; |
1737 | } else if (unlikely(emac_alloc_rx_skb(dev, slot, GFP_ATOMIC))) | 1729 | } else if (unlikely(emac_alloc_rx_skb(dev, slot, GFP_ATOMIC))) |