aboutsummaryrefslogtreecommitdiffstats
path: root/drivers/net/ethernet/emulex
diff options
context:
space:
mode:
authorVasundhara Volam <vasundhara.volam@emulex.com>2014-01-15 02:53:35 -0500
committerDavid S. Miller <davem@davemloft.net>2014-01-15 18:52:02 -0500
commitff32f8abbe4469c409a8e92fa63c2da0d7da55e2 (patch)
tree04077d555a6d3b6b37020ae8951ace8b08d6448f /drivers/net/ethernet/emulex
parentbaaa08d148ac2d02567126e85213e82675ca55c0 (diff)
be2net: ignore mac-addr set call for an already programmed mac-addr
An ndo_set_mac_addr() call may be issued for a mac-addr that is already active on an interface. If so, silently ignore the request. Sending such a request to the FW, causes a "mac collision" error. The error is harmless but is avoidable noise in the kernel log. Signed-off-by: Vasundhara Volam <vasundhara.volam@emulex.com> Signed-off-by: Sathya Perla <sathya.perla@emulex.com> Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'drivers/net/ethernet/emulex')
-rw-r--r--drivers/net/ethernet/emulex/benet/be_main.c6
1 files changed, 6 insertions, 0 deletions
diff --git a/drivers/net/ethernet/emulex/benet/be_main.c b/drivers/net/ethernet/emulex/benet/be_main.c
index 0710f9a84de3..ce589b43bd51 100644
--- a/drivers/net/ethernet/emulex/benet/be_main.c
+++ b/drivers/net/ethernet/emulex/benet/be_main.c
@@ -258,6 +258,12 @@ static int be_mac_addr_set(struct net_device *netdev, void *p)
258 if (!is_valid_ether_addr(addr->sa_data)) 258 if (!is_valid_ether_addr(addr->sa_data))
259 return -EADDRNOTAVAIL; 259 return -EADDRNOTAVAIL;
260 260
261 /* Proceed further only if, User provided MAC is different
262 * from active MAC
263 */
264 if (ether_addr_equal(addr->sa_data, netdev->dev_addr))
265 return 0;
266
261 /* The PMAC_ADD cmd may fail if the VF doesn't have FILTMGMT 267 /* The PMAC_ADD cmd may fail if the VF doesn't have FILTMGMT
262 * privilege or if PF did not provision the new MAC address. 268 * privilege or if PF did not provision the new MAC address.
263 * On BE3, this cmd will always fail if the VF doesn't have the 269 * On BE3, this cmd will always fail if the VF doesn't have the