diff options
| author | Sathya Perla <sathya.perla@emulex.com> | 2015-02-23 04:20:09 -0500 |
|---|---|---|
| committer | David S. Miller <davem@davemloft.net> | 2015-02-23 15:08:31 -0500 |
| commit | 6b085ba9271a252b1e3f836ab5df202c51be4f2f (patch) | |
| tree | 4969e0cd5c26b32f545ccaad0de762866e8dac09 /drivers/net/ethernet/emulex/benet | |
| parent | 78fad34eb8b22ce588b9ebdab39965210588e4b5 (diff) | |
be2net: get rid of be_get_initial_config() call from be_probe()
Most of the code to fetch the adapter state is in be_setup()->be_get_config().
So, move the code from be_get_initial_config() to be_get_config().
Signed-off-by: Sathya Perla <sathya.perla@emulex.com>
Signed-off-by: Kalesh AP <kalesh.purayil@emulex.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'drivers/net/ethernet/emulex/benet')
| -rw-r--r-- | drivers/net/ethernet/emulex/benet/be_main.c | 38 |
1 files changed, 13 insertions, 25 deletions
diff --git a/drivers/net/ethernet/emulex/benet/be_main.c b/drivers/net/ethernet/emulex/benet/be_main.c index ae8ad5502db0..40c8f85dbd0d 100644 --- a/drivers/net/ethernet/emulex/benet/be_main.c +++ b/drivers/net/ethernet/emulex/benet/be_main.c | |||
| @@ -3771,13 +3771,25 @@ static void be_sriov_config(struct be_adapter *adapter) | |||
| 3771 | 3771 | ||
| 3772 | static int be_get_config(struct be_adapter *adapter) | 3772 | static int be_get_config(struct be_adapter *adapter) |
| 3773 | { | 3773 | { |
| 3774 | int status, level; | ||
| 3774 | u16 profile_id; | 3775 | u16 profile_id; |
| 3775 | int status; | 3776 | |
| 3777 | status = be_cmd_get_cntl_attributes(adapter); | ||
| 3778 | if (status) | ||
| 3779 | return status; | ||
| 3776 | 3780 | ||
| 3777 | status = be_cmd_query_fw_cfg(adapter); | 3781 | status = be_cmd_query_fw_cfg(adapter); |
| 3778 | if (status) | 3782 | if (status) |
| 3779 | return status; | 3783 | return status; |
| 3780 | 3784 | ||
| 3785 | if (BEx_chip(adapter)) { | ||
| 3786 | level = be_cmd_get_fw_log_level(adapter); | ||
| 3787 | adapter->msg_enable = | ||
| 3788 | level <= FW_LOG_LEVEL_DEFAULT ? NETIF_MSG_HW : 0; | ||
| 3789 | } | ||
| 3790 | |||
| 3791 | be_cmd_get_acpi_wol_cap(adapter); | ||
| 3792 | |||
| 3781 | be_cmd_query_port_name(adapter); | 3793 | be_cmd_query_port_name(adapter); |
| 3782 | 3794 | ||
| 3783 | if (be_physfn(adapter)) { | 3795 | if (be_physfn(adapter)) { |
| @@ -3967,8 +3979,6 @@ static int be_setup(struct be_adapter *adapter) | |||
| 3967 | 3979 | ||
| 3968 | be_set_rx_mode(adapter->netdev); | 3980 | be_set_rx_mode(adapter->netdev); |
| 3969 | 3981 | ||
| 3970 | be_cmd_get_acpi_wol_cap(adapter); | ||
| 3971 | |||
| 3972 | status = be_cmd_set_flow_control(adapter, adapter->tx_fc, | 3982 | status = be_cmd_set_flow_control(adapter, adapter->tx_fc, |
| 3973 | adapter->rx_fc); | 3983 | adapter->rx_fc); |
| 3974 | if (status) | 3984 | if (status) |
| @@ -5179,24 +5189,6 @@ static void be_remove(struct pci_dev *pdev) | |||
| 5179 | free_netdev(adapter->netdev); | 5189 | free_netdev(adapter->netdev); |
| 5180 | } | 5190 | } |
| 5181 | 5191 | ||
| 5182 | static int be_get_initial_config(struct be_adapter *adapter) | ||
| 5183 | { | ||
| 5184 | int status, level; | ||
| 5185 | |||
| 5186 | status = be_cmd_get_cntl_attributes(adapter); | ||
| 5187 | if (status) | ||
| 5188 | return status; | ||
| 5189 | |||
| 5190 | if (BEx_chip(adapter)) { | ||
| 5191 | level = be_cmd_get_fw_log_level(adapter); | ||
| 5192 | adapter->msg_enable = | ||
| 5193 | level <= FW_LOG_LEVEL_DEFAULT ? NETIF_MSG_HW : 0; | ||
| 5194 | } | ||
| 5195 | |||
| 5196 | return 0; | ||
| 5197 | } | ||
| 5198 | |||
| 5199 | |||
| 5200 | /* If any VFs are already enabled don't FLR the PF */ | 5192 | /* If any VFs are already enabled don't FLR the PF */ |
| 5201 | static bool be_reset_required(struct be_adapter *adapter) | 5193 | static bool be_reset_required(struct be_adapter *adapter) |
| 5202 | { | 5194 | { |
| @@ -5333,10 +5325,6 @@ static int be_probe(struct pci_dev *pdev, const struct pci_device_id *pdev_id) | |||
| 5333 | if (status) | 5325 | if (status) |
| 5334 | goto drv_cleanup; | 5326 | goto drv_cleanup; |
| 5335 | 5327 | ||
| 5336 | status = be_get_initial_config(adapter); | ||
| 5337 | if (status) | ||
| 5338 | goto drv_cleanup; | ||
| 5339 | |||
| 5340 | status = be_setup(adapter); | 5328 | status = be_setup(adapter); |
| 5341 | if (status) | 5329 | if (status) |
| 5342 | goto drv_cleanup; | 5330 | goto drv_cleanup; |
