diff options
author | Florian Fainelli <f.fainelli@gmail.com> | 2014-01-12 22:05:55 -0500 |
---|---|---|
committer | David S. Miller <davem@davemloft.net> | 2014-01-14 21:19:20 -0500 |
commit | 5571415c9685acc2c768b33d0be40b3f46869f14 (patch) | |
tree | 535488b719744a19d08b1b1ea3d77e9cd47ce437 /drivers/net/ethernet/broadcom | |
parent | ec35b61ea59aa6b1ecc8d8452b225e4677e32627 (diff) |
bgmac: propagate error codes in bgmac_probe()
bgmac_mii_register() and register_netdev() both return appropriate error
codes for the failures they would encounter, propagate this error code
instead of overriding the value with -ENOTSUPP which is not the correct
error code to return.
Signed-off-by: Florian Fainelli <f.fainelli@gmail.com>
Acked-by: Rafał Miłecki <zajec5@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'drivers/net/ethernet/broadcom')
-rw-r--r-- | drivers/net/ethernet/broadcom/bgmac.c | 2 |
1 files changed, 0 insertions, 2 deletions
diff --git a/drivers/net/ethernet/broadcom/bgmac.c b/drivers/net/ethernet/broadcom/bgmac.c index 7f968a9b52c8..0297a79a38e1 100644 --- a/drivers/net/ethernet/broadcom/bgmac.c +++ b/drivers/net/ethernet/broadcom/bgmac.c | |||
@@ -1518,14 +1518,12 @@ static int bgmac_probe(struct bcma_device *core) | |||
1518 | err = bgmac_mii_register(bgmac); | 1518 | err = bgmac_mii_register(bgmac); |
1519 | if (err) { | 1519 | if (err) { |
1520 | bgmac_err(bgmac, "Cannot register MDIO\n"); | 1520 | bgmac_err(bgmac, "Cannot register MDIO\n"); |
1521 | err = -ENOTSUPP; | ||
1522 | goto err_dma_free; | 1521 | goto err_dma_free; |
1523 | } | 1522 | } |
1524 | 1523 | ||
1525 | err = register_netdev(bgmac->net_dev); | 1524 | err = register_netdev(bgmac->net_dev); |
1526 | if (err) { | 1525 | if (err) { |
1527 | bgmac_err(bgmac, "Cannot register net device\n"); | 1526 | bgmac_err(bgmac, "Cannot register net device\n"); |
1528 | err = -ENOTSUPP; | ||
1529 | goto err_mii_unregister; | 1527 | goto err_mii_unregister; |
1530 | } | 1528 | } |
1531 | 1529 | ||