diff options
author | Florian Fainelli <florian@openwrt.org> | 2013-01-13 19:52:52 -0500 |
---|---|---|
committer | David S. Miller <davem@davemloft.net> | 2013-01-14 15:11:50 -0500 |
commit | f9a8f83b04e0c362a2fc660dbad980d24af209fc (patch) | |
tree | 055b2c8f2d32f3cfd0dc84fd3f8d971a34aeed85 /drivers/net/ethernet/8390 | |
parent | c1b52739e45f5969b208ebc377f52468280af11e (diff) |
net: phy: remove flags argument from phy_{attach, connect, connect_direct}
The flags argument of the phy_{attach,connect,connect_direct} functions
is then used to assign a struct phy_device dev_flags with its value.
All callers but the tg3 driver pass the flag 0, which results in the
underlying PHY drivers in drivers/net/phy/ not being able to actually
use any of the flags they would set in dev_flags. This patch gets rid of
the flags argument, and passes phydev->dev_flags to the internal PHY
library call phy_attach_direct() such that drivers which actually modify
a phy device dev_flags get the value preserved for use by the underlying
phy driver.
Acked-by: Kosta Zertsekel <konszert@marvell.com>
Signed-off-by: Florian Fainelli <florian@openwrt.org>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'drivers/net/ethernet/8390')
-rw-r--r-- | drivers/net/ethernet/8390/ax88796.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/net/ethernet/8390/ax88796.c b/drivers/net/ethernet/8390/ax88796.c index 7eeddf01307f..cab306a9888e 100644 --- a/drivers/net/ethernet/8390/ax88796.c +++ b/drivers/net/ethernet/8390/ax88796.c | |||
@@ -358,7 +358,7 @@ static int ax_mii_probe(struct net_device *dev) | |||
358 | return -ENODEV; | 358 | return -ENODEV; |
359 | } | 359 | } |
360 | 360 | ||
361 | ret = phy_connect_direct(dev, phy_dev, ax_handle_link_change, 0, | 361 | ret = phy_connect_direct(dev, phy_dev, ax_handle_link_change, |
362 | PHY_INTERFACE_MODE_MII); | 362 | PHY_INTERFACE_MODE_MII); |
363 | if (ret) { | 363 | if (ret) { |
364 | netdev_err(dev, "Could not attach to PHY\n"); | 364 | netdev_err(dev, "Could not attach to PHY\n"); |