Merge branch 'wip-2.6.34' into old-private-masterarchived-private-master

1 files changed, 39 insertions, 18 deletions

diff --git a/drivers/net/e100.c b/drivers/net/e100.c
index d269a68ce354..791080303db1 100644
--- a/drivers/net/e100.c
+++ b/drivers/net/e100.c
@@ -166,6 +166,7 @@
 #include <linux/ethtool.h>
 #include <linux/string.h>
 #include <linux/firmware.h>
+#include <linux/rtnetlink.h>
 #include <asm/unaligned.h>
 
 
@@ -208,7 +209,7 @@ MODULE_PARM_DESC(use_io, "Force use of i/o access mode");
 #define INTEL_8255X_ETHERNET_DEVICE(device_id, ich) {\
         PCI_VENDOR_ID_INTEL, device_id, PCI_ANY_ID, PCI_ANY_ID, \
         PCI_CLASS_NETWORK_ETHERNET << 8, 0xFFFF00, ich }
-static struct pci_device_id e100_id_table[] = {
+static DEFINE_PCI_DEVICE_TABLE(e100_id_table) = {
         INTEL_8255X_ETHERNET_DEVICE(0x1029, 0),
         INTEL_8255X_ETHERNET_DEVICE(0x1030, 0),
         INTEL_8255X_ETHERNET_DEVICE(0x1031, 3),
@@ -624,6 +625,7 @@ struct nic {
         u16 eeprom_wc;
         __le16 eeprom[256];
         spinlock_t mdio_lock;
+        const struct firmware *fw;
 };
 
 static inline void e100_write_flush(struct nic *nic)
@@ -1225,9 +1227,9 @@ static void e100_configure(struct nic *nic, struct cb *cb, struct sk_buff *skb)
 static const struct firmware *e100_request_firmware(struct nic *nic)
 {
         const char *fw_name;
-        const struct firmware *fw;
+        const struct firmware *fw = nic->fw;
         u8 timer, bundle, min_size;
-        int err;
+        int err = 0;
 
         /* do not load u-code for ICH devices */
         if (nic->flags & ich)
@@ -1243,12 +1245,20 @@ static const struct firmware *e100_request_firmware(struct nic *nic)
         else /* No ucode on other devices */
                 return NULL;
 
-        err = request_firmware(&fw, fw_name, &nic->pdev->dev);
+        /* If the firmware has not previously been loaded, request a pointer
+         * to it. If it was previously loaded, we are reinitializing the
+         * adapter, possibly in a resume from hibernate, in which case
+         * request_firmware() cannot be used.
+         */
+        if (!fw)
+                err = request_firmware(&fw, fw_name, &nic->pdev->dev);
+
         if (err) {
                 DPRINTK(PROBE, ERR, "Failed to load firmware \"%s\": %d\n",
                         fw_name, err);
                 return ERR_PTR(err);
         }
+
         /* Firmware should be precisely UCODE_SIZE (words) plus three bytes
            indicating the offsets for BUNDLESMALL, BUNDLEMAX, INTDELAY */
         if (fw->size != UCODE_SIZE * 4 + 3) {
@@ -1271,7 +1281,10 @@ static const struct firmware *e100_request_firmware(struct nic *nic)
                 release_firmware(fw);
                 return ERR_PTR(-EINVAL);
         }
-        /* OK, firmware is validated and ready to use... */
+
+        /* OK, firmware is validated and ready to use. Save a pointer
+         * to it in the nic */
+        nic->fw = fw;
         return fw;
 }
 
@@ -1525,14 +1538,18 @@ static int e100_hw_init(struct nic *nic)
 static void e100_multi(struct nic *nic, struct cb *cb, struct sk_buff *skb)
 {
         struct net_device *netdev = nic->netdev;
-        struct dev_mc_list *list = netdev->mc_list;
-        u16 i, count = min(netdev->mc_count, E100_MAX_MULTICAST_ADDRS);
+        struct dev_mc_list *list;
+        u16 i, count = min(netdev_mc_count(netdev), E100_MAX_MULTICAST_ADDRS);
 
         cb->command = cpu_to_le16(cb_multi);
         cb->u.multi.count = cpu_to_le16(count * ETH_ALEN);
-        for (i = 0; list && i < count; i++, list = list->next)
-                memcpy(&cb->u.multi.addr[i*ETH_ALEN], &list->dmi_addr,
+        i = 0;
+        netdev_for_each_mc_addr(list, netdev) {
+                if (i == count)
+                        break;
+                memcpy(&cb->u.multi.addr[i++ * ETH_ALEN], &list->dmi_addr,
                         ETH_ALEN);
+        }
 }
 
 static void e100_set_multicast_list(struct net_device *netdev)
@@ -1540,7 +1557,7 @@ static void e100_set_multicast_list(struct net_device *netdev)
         struct nic *nic = netdev_priv(netdev);
 
         DPRINTK(HW, DEBUG, "mc_count=%d, flags=0x%04X\n",
-                netdev->mc_count, netdev->flags);
+                netdev_mc_count(netdev), netdev->flags);
 
         if (netdev->flags & IFF_PROMISC)
                 nic->flags |= promiscuous;
@@ -1548,7 +1565,7 @@ static void e100_set_multicast_list(struct net_device *netdev)
                 nic->flags &= ~promiscuous;
 
         if (netdev->flags & IFF_ALLMULTI ||
-                netdev->mc_count > E100_MAX_MULTICAST_ADDRS)
+                netdev_mc_count(netdev) > E100_MAX_MULTICAST_ADDRS)
                 nic->flags |= multicast_all;
         else
                 nic->flags &= ~multicast_all;
@@ -1817,6 +1834,7 @@ static int e100_alloc_cbs(struct nic *nic)
                                   &nic->cbs_dma_addr);
         if (!nic->cbs)
                 return -ENOMEM;
+        memset(nic->cbs, 0, count * sizeof(struct cb));
 
         for (cb = nic->cbs, i = 0; i < count; cb++, i++) {
                 cb->next = (i + 1 < count) ? cb + 1 : nic->cbs;
@@ -1825,7 +1843,6 @@ static int e100_alloc_cbs(struct nic *nic)
                 cb->dma_addr = nic->cbs_dma_addr + i * sizeof(struct cb);
                 cb->link = cpu_to_le32(nic->cbs_dma_addr +
                         ((i+1) % count) * sizeof(struct cb));
-                cb->skb = NULL;
         }
 
         nic->cb_to_use = nic->cb_to_send = nic->cb_to_clean = nic->cbs;
@@ -1852,11 +1869,10 @@ static inline void e100_start_receiver(struct nic *nic, struct rx *rx)
 #define RFD_BUF_LEN (sizeof(struct rfd) + VLAN_ETH_FRAME_LEN)
 static int e100_rx_alloc_skb(struct nic *nic, struct rx *rx)
 {
-        if (!(rx->skb = netdev_alloc_skb(nic->netdev, RFD_BUF_LEN + NET_IP_ALIGN)))
+        if (!(rx->skb = netdev_alloc_skb_ip_align(nic->netdev, RFD_BUF_LEN)))
                 return -ENOMEM;
 
-        /* Align, init, and map the RFD. */
-        skb_reserve(rx->skb, NET_IP_ALIGN);
+        /* Init, and map the RFD. */
         skb_copy_to_linear_data(rx->skb, &nic->blank_rfd, sizeof(struct rfd));
         rx->dma_addr = pci_map_single(nic->pdev, rx->skb->data,
                 RFD_BUF_LEN, PCI_DMA_BIDIRECTIONAL);
@@ -2250,8 +2266,13 @@ static void e100_tx_timeout_task(struct work_struct *work)
 
         DPRINTK(TX_ERR, DEBUG, "scb.status=0x%02X\n",
                 ioread8(&nic->csr->scb.status));
-        e100_down(netdev_priv(netdev));
-        e100_up(netdev_priv(netdev));
+
+        rtnl_lock();
+        if (netif_running(netdev)) {
+                e100_down(netdev_priv(netdev));
+                e100_up(netdev_priv(netdev));
+        }
+        rtnl_unlock();
 }
 
 static int e100_loopback_test(struct nic *nic, enum loopback loopback_mode)
@@ -2843,7 +2864,7 @@ static int __devinit e100_probe(struct pci_dev *pdev,
         }
         nic->cbs_pool = pci_pool_create(netdev->name,
                            nic->pdev,
-                           nic->params.cbs.count * sizeof(struct cb),
+                           nic->params.cbs.max * sizeof(struct cb),
                            sizeof(u32),
                            0);
         DPRINTK(PROBE, INFO, "addr 0x%llx, irq %d, MAC addr %pM\n",