ethtool: Use full 32 bit speed range in ethtool's set_settings

This makes sure the ethtool's set_settings() callback of network
drivers don't ignore the 16 most significant bits when ethtool calls
their set_settings().

All drivers compiled with make allyesconfig on x86_64 have been
updated.

Signed-off-by: David Decotigny <decot@google.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

1 files changed, 6 insertions, 5 deletions

diff --git a/drivers/net/cxgb4/cxgb4_main.c b/drivers/net/cxgb4/cxgb4_main.c
index bdc868ca47ec..c02b4d3b73fc 100644
--- a/drivers/net/cxgb4/cxgb4_main.c
+++ b/drivers/net/cxgb4/cxgb4_main.c
@@ -1460,6 +1460,7 @@ static int set_settings(struct net_device *dev, struct ethtool_cmd *cmd)
         unsigned int cap;
         struct port_info *p = netdev_priv(dev);
         struct link_config *lc = &p->link_cfg;
+        u32 speed = ethtool_cmd_speed(cmd);
 
         if (cmd->duplex != DUPLEX_FULL)     /* only full-duplex supported */
                 return -EINVAL;
@@ -1470,16 +1471,16 @@ static int set_settings(struct net_device *dev, struct ethtool_cmd *cmd)
                  * being requested.
                  */
                 if (cmd->autoneg == AUTONEG_DISABLE &&
-                    (lc->supported & speed_to_caps(cmd->speed)))
-                                return 0;
+                    (lc->supported & speed_to_caps(speed)))
+                        return 0;
                 return -EINVAL;
         }
 
         if (cmd->autoneg == AUTONEG_DISABLE) {
-                cap = speed_to_caps(cmd->speed);
+                cap = speed_to_caps(speed);
 
-                if (!(lc->supported & cap) || cmd->speed == SPEED_1000 ||
-                    cmd->speed == SPEED_10000)
+                if (!(lc->supported & cap) || (speed == SPEED_1000) ||
+                    (speed == SPEED_10000))
                         return -EINVAL;
                 lc->requested_speed = cap;
                 lc->advertising = 0;