aboutsummaryrefslogtreecommitdiffstats
path: root/drivers/net/can
diff options
context:
space:
mode:
authorStephane Grosjean <s.grosjean@peak-system.com>2015-03-16 06:57:52 -0400
committerMarc Kleine-Budde <mkl@pengutronix.de>2015-03-22 13:14:50 -0400
commit3ef5247e033972ddbd16f65ec2ad8a7dfc2e4170 (patch)
treef37dc001d7bc9870d7b023305d7c8dc3cc6e75e9 /drivers/net/can
parent37920a74abd6fdf0696730ba80a07843a62c9c54 (diff)
can: peak_usb: rename usb option cmds definition and structs
The PUCAN_CMD_RX_FRAME_(ENABLE|DISABLE) command has extended its purpose and was therefore renamed to PUCAN_CMD_SET_(EN|DIS)_OPTION. Signed-off-by: Stephane Grosjean <s.grosjean@peak-system.com> Signed-off-by: Oliver Hartkopp <socketcan@hartkopp.net> Tested-by: Oliver Hartkopp <socketcan@hartkopp.net> Signed-off-by: Marc Kleine-Budde <mkl@pengutronix.de>
Diffstat (limited to 'drivers/net/can')
-rw-r--r--drivers/net/can/usb/peak_usb/pcan_ucan.h14
-rw-r--r--drivers/net/can/usb/peak_usb/pcan_usb_fd.c42
2 files changed, 28 insertions, 28 deletions
diff --git a/drivers/net/can/usb/peak_usb/pcan_ucan.h b/drivers/net/can/usb/peak_usb/pcan_ucan.h
index 1ba7c25002e1..1fb33307be4e 100644
--- a/drivers/net/can/usb/peak_usb/pcan_ucan.h
+++ b/drivers/net/can/usb/peak_usb/pcan_ucan.h
@@ -26,8 +26,8 @@
26#define PUCAN_CMD_FILTER_STD 0x008 26#define PUCAN_CMD_FILTER_STD 0x008
27#define PUCAN_CMD_TX_ABORT 0x009 27#define PUCAN_CMD_TX_ABORT 0x009
28#define PUCAN_CMD_WR_ERR_CNT 0x00a 28#define PUCAN_CMD_WR_ERR_CNT 0x00a
29#define PUCAN_CMD_RX_FRAME_ENABLE 0x00b 29#define PUCAN_CMD_SET_EN_OPTION 0x00b
30#define PUCAN_CMD_RX_FRAME_DISABLE 0x00c 30#define PUCAN_CMD_CLR_DIS_OPTION 0x00c
31#define PUCAN_CMD_END_OF_COLLECTION 0x3ff 31#define PUCAN_CMD_END_OF_COLLECTION 0x3ff
32 32
33/* uCAN received messages list */ 33/* uCAN received messages list */
@@ -101,14 +101,14 @@ struct __packed pucan_wr_err_cnt {
101 u16 unused; 101 u16 unused;
102}; 102};
103 103
104/* uCAN RX_FRAME_ENABLE command fields */ 104/* uCAN SET_EN/CLR_DIS _OPTION command fields */
105#define PUCAN_FLTEXT_ERROR 0x0001 105#define PUCAN_OPTION_ERROR 0x0001
106#define PUCAN_FLTEXT_BUSLOAD 0x0002 106#define PUCAN_OPTION_BUSLOAD 0x0002
107 107
108struct __packed pucan_filter_ext { 108struct __packed pucan_options {
109 __le16 opcode_channel; 109 __le16 opcode_channel;
110 110
111 __le16 ext_mask; 111 __le16 options;
112 u32 unused; 112 u32 unused;
113}; 113};
114 114
diff --git a/drivers/net/can/usb/peak_usb/pcan_usb_fd.c b/drivers/net/can/usb/peak_usb/pcan_usb_fd.c
index 0bac0f14edc3..7506a8352edd 100644
--- a/drivers/net/can/usb/peak_usb/pcan_usb_fd.c
+++ b/drivers/net/can/usb/peak_usb/pcan_usb_fd.c
@@ -110,13 +110,13 @@ struct __packed pcan_ufd_led {
110 u8 unused[5]; 110 u8 unused[5];
111}; 111};
112 112
113/* Extended usage of uCAN commands CMD_RX_FRAME_xxxABLE for PCAN-USB Pro FD */ 113/* Extended usage of uCAN commands CMD_xxx_xx_OPTION for PCAN-USB Pro FD */
114#define PCAN_UFD_FLTEXT_CALIBRATION 0x8000 114#define PCAN_UFD_FLTEXT_CALIBRATION 0x8000
115 115
116struct __packed pcan_ufd_filter_ext { 116struct __packed pcan_ufd_options {
117 __le16 opcode_channel; 117 __le16 opcode_channel;
118 118
119 __le16 ext_mask; 119 __le16 ucan_mask;
120 u16 unused; 120 u16 unused;
121 __le16 usb_mask; 121 __le16 usb_mask;
122}; 122};
@@ -321,21 +321,21 @@ static int pcan_usb_fd_set_filter_std(struct peak_usb_device *dev, int idx,
321 return pcan_usb_fd_send_cmd(dev, cmd); 321 return pcan_usb_fd_send_cmd(dev, cmd);
322} 322}
323 323
324/* set/unset notifications filter: 324/* set/unset options
325 * 325 *
326 * onoff sets(1)/unset(0) notifications 326 * onoff set(1)/unset(0) options
327 * mask each bit defines a kind of notification to set/unset 327 * mask each bit defines a kind of options to set/unset
328 */ 328 */
329static int pcan_usb_fd_set_filter_ext(struct peak_usb_device *dev, 329static int pcan_usb_fd_set_options(struct peak_usb_device *dev,
330 bool onoff, u16 ext_mask, u16 usb_mask) 330 bool onoff, u16 ucan_mask, u16 usb_mask)
331{ 331{
332 struct pcan_ufd_filter_ext *cmd = pcan_usb_fd_cmd_buffer(dev); 332 struct pcan_ufd_options *cmd = pcan_usb_fd_cmd_buffer(dev);
333 333
334 cmd->opcode_channel = pucan_cmd_opcode_channel(dev, 334 cmd->opcode_channel = pucan_cmd_opcode_channel(dev,
335 (onoff) ? PUCAN_CMD_RX_FRAME_ENABLE : 335 (onoff) ? PUCAN_CMD_SET_EN_OPTION :
336 PUCAN_CMD_RX_FRAME_DISABLE); 336 PUCAN_CMD_CLR_DIS_OPTION);
337 337
338 cmd->ext_mask = cpu_to_le16(ext_mask); 338 cmd->ucan_mask = cpu_to_le16(ucan_mask);
339 cmd->usb_mask = cpu_to_le16(usb_mask); 339 cmd->usb_mask = cpu_to_le16(usb_mask);
340 340
341 /* send the command */ 341 /* send the command */
@@ -770,9 +770,9 @@ static int pcan_usb_fd_start(struct peak_usb_device *dev)
770 &pcan_usb_pro_fd); 770 &pcan_usb_pro_fd);
771 771
772 /* enable USB calibration messages */ 772 /* enable USB calibration messages */
773 err = pcan_usb_fd_set_filter_ext(dev, 1, 773 err = pcan_usb_fd_set_options(dev, 1,
774 PUCAN_FLTEXT_ERROR, 774 PUCAN_OPTION_ERROR,
775 PCAN_UFD_FLTEXT_CALIBRATION); 775 PCAN_UFD_FLTEXT_CALIBRATION);
776 } 776 }
777 777
778 pdev->usb_if->dev_opened_count++; 778 pdev->usb_if->dev_opened_count++;
@@ -806,9 +806,9 @@ static int pcan_usb_fd_stop(struct peak_usb_device *dev)
806 806
807 /* turn off special msgs for that interface if no other dev opened */ 807 /* turn off special msgs for that interface if no other dev opened */
808 if (pdev->usb_if->dev_opened_count == 1) 808 if (pdev->usb_if->dev_opened_count == 1)
809 pcan_usb_fd_set_filter_ext(dev, 0, 809 pcan_usb_fd_set_options(dev, 0,
810 PUCAN_FLTEXT_ERROR, 810 PUCAN_OPTION_ERROR,
811 PCAN_UFD_FLTEXT_CALIBRATION); 811 PCAN_UFD_FLTEXT_CALIBRATION);
812 pdev->usb_if->dev_opened_count--; 812 pdev->usb_if->dev_opened_count--;
813 813
814 return 0; 814 return 0;
@@ -937,9 +937,9 @@ static void pcan_usb_fd_exit(struct peak_usb_device *dev)
937 if (dev->ctrl_idx == 0) { 937 if (dev->ctrl_idx == 0) {
938 /* turn off calibration message if any device were opened */ 938 /* turn off calibration message if any device were opened */
939 if (pdev->usb_if->dev_opened_count > 0) 939 if (pdev->usb_if->dev_opened_count > 0)
940 pcan_usb_fd_set_filter_ext(dev, 0, 940 pcan_usb_fd_set_options(dev, 0,
941 PUCAN_FLTEXT_ERROR, 941 PUCAN_OPTION_ERROR,
942 PCAN_UFD_FLTEXT_CALIBRATION); 942 PCAN_UFD_FLTEXT_CALIBRATION);
943 943
944 /* tell USB adapter that the driver is being unloaded */ 944 /* tell USB adapter that the driver is being unloaded */
945 pcan_usb_fd_drv_loaded(dev, 0); 945 pcan_usb_fd_drv_loaded(dev, 0);