aboutsummaryrefslogtreecommitdiffstats
path: root/drivers/net/bonding
diff options
context:
space:
mode:
authornikolay@redhat.com <nikolay@redhat.com>2013-06-26 11:13:37 -0400
committerDavid S. Miller <davem@davemloft.net>2013-06-28 01:50:15 -0400
commit8d2ada77f8a7f8f65fcbf71b23cbac54b64151a6 (patch)
treebf48e3ada33e8b2cc151c3a23adef15e188d85eb /drivers/net/bonding
parent3a36515f729458c8efa0c124c7262d5843ad5c37 (diff)
bonding: remove unnecessary setup_by_slave member
We have a member called setup_by_slave in struct bonding to denote if the bond dev has different type than ARPHRD_ETHER, but that is already denoted in bond's netdev type variable if it was setup by the slave, so use that instead of the member. Signed-off-by: Nikolay Aleksandrov <nikolay@redhat.com> Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'drivers/net/bonding')
-rw-r--r--drivers/net/bonding/bond_main.c5
-rw-r--r--drivers/net/bonding/bonding.h1
2 files changed, 1 insertions, 5 deletions
diff --git a/drivers/net/bonding/bond_main.c b/drivers/net/bonding/bond_main.c
index 142d55dc526e..2e8b9f1e2747 100644
--- a/drivers/net/bonding/bond_main.c
+++ b/drivers/net/bonding/bond_main.c
@@ -1382,8 +1382,6 @@ done:
1382static void bond_setup_by_slave(struct net_device *bond_dev, 1382static void bond_setup_by_slave(struct net_device *bond_dev,
1383 struct net_device *slave_dev) 1383 struct net_device *slave_dev)
1384{ 1384{
1385 struct bonding *bond = netdev_priv(bond_dev);
1386
1387 bond_dev->header_ops = slave_dev->header_ops; 1385 bond_dev->header_ops = slave_dev->header_ops;
1388 1386
1389 bond_dev->type = slave_dev->type; 1387 bond_dev->type = slave_dev->type;
@@ -1392,7 +1390,6 @@ static void bond_setup_by_slave(struct net_device *bond_dev,
1392 1390
1393 memcpy(bond_dev->broadcast, slave_dev->broadcast, 1391 memcpy(bond_dev->broadcast, slave_dev->broadcast,
1394 slave_dev->addr_len); 1392 slave_dev->addr_len);
1395 bond->setup_by_slave = 1;
1396} 1393}
1397 1394
1398/* On bonding slaves other than the currently active slave, suppress 1395/* On bonding slaves other than the currently active slave, suppress
@@ -3187,7 +3184,7 @@ static int bond_slave_netdev_event(unsigned long event,
3187 3184
3188 switch (event) { 3185 switch (event) {
3189 case NETDEV_UNREGISTER: 3186 case NETDEV_UNREGISTER:
3190 if (bond->setup_by_slave) 3187 if (bond_dev->type != ARPHRD_ETHER)
3191 bond_release_and_destroy(bond_dev, slave_dev); 3188 bond_release_and_destroy(bond_dev, slave_dev);
3192 else 3189 else
3193 bond_release(bond_dev, slave_dev); 3190 bond_release(bond_dev, slave_dev);
diff --git a/drivers/net/bonding/bonding.h b/drivers/net/bonding/bonding.h
index 3fb73cc8c34a..c6c8d03562e5 100644
--- a/drivers/net/bonding/bonding.h
+++ b/drivers/net/bonding/bonding.h
@@ -226,7 +226,6 @@ struct bonding {
226 rwlock_t lock; 226 rwlock_t lock;
227 rwlock_t curr_slave_lock; 227 rwlock_t curr_slave_lock;
228 u8 send_peer_notif; 228 u8 send_peer_notif;
229 s8 setup_by_slave;
230 u8 igmp_retrans; 229 u8 igmp_retrans;
231#ifdef CONFIG_PROC_FS 230#ifdef CONFIG_PROC_FS
232 struct proc_dir_entry *proc_entry; 231 struct proc_dir_entry *proc_entry;