aboutsummaryrefslogtreecommitdiffstats
path: root/drivers/mtd/devices
diff options
context:
space:
mode:
authorArtem Bityutskiy <artem.bityutskiy@linux.intel.com>2011-12-29 04:40:00 -0500
committerDavid Woodhouse <David.Woodhouse@intel.com>2012-01-09 13:25:53 -0500
commitbea7fe031e5b81629f264f48335f1af74900f4b9 (patch)
treebbbaa526668a53dd1d4fbdc14b7b01ad4d3e8e8a /drivers/mtd/devices
parent122f81d773a464220d64f1a382bde073df281d5a (diff)
mtd: doc: do not initialize mtd_info fields to 0 or NULL
The 'struct mtd_info' object is allocated with 'kzalloc()', so it contains only zeroes - no need to initialize various fields to 0 or NULL. Signed-off-by: Artem Bityutskiy <artem.bityutskiy@linux.intel.com> Signed-off-by: David Woodhouse <David.Woodhouse@intel.com>
Diffstat (limited to 'drivers/mtd/devices')
-rw-r--r--drivers/mtd/devices/doc2000.c9
-rw-r--r--drivers/mtd/devices/doc2001.c8
-rw-r--r--drivers/mtd/devices/doc2001plus.c9
-rw-r--r--drivers/mtd/devices/docg3.c3
4 files changed, 0 insertions, 29 deletions
diff --git a/drivers/mtd/devices/doc2000.c b/drivers/mtd/devices/doc2000.c
index e9fad9151219..b1cdf6479019 100644
--- a/drivers/mtd/devices/doc2000.c
+++ b/drivers/mtd/devices/doc2000.c
@@ -562,23 +562,14 @@ void DoC2k_init(struct mtd_info *mtd)
562 562
563 mtd->type = MTD_NANDFLASH; 563 mtd->type = MTD_NANDFLASH;
564 mtd->flags = MTD_CAP_NANDFLASH; 564 mtd->flags = MTD_CAP_NANDFLASH;
565 mtd->size = 0;
566 mtd->erasesize = 0;
567 mtd->writesize = 512; 565 mtd->writesize = 512;
568 mtd->oobsize = 16; 566 mtd->oobsize = 16;
569 mtd->owner = THIS_MODULE; 567 mtd->owner = THIS_MODULE;
570 mtd->erase = doc_erase; 568 mtd->erase = doc_erase;
571 mtd->point = NULL;
572 mtd->unpoint = NULL;
573 mtd->read = doc_read; 569 mtd->read = doc_read;
574 mtd->write = doc_write; 570 mtd->write = doc_write;
575 mtd->read_oob = doc_read_oob; 571 mtd->read_oob = doc_read_oob;
576 mtd->write_oob = doc_write_oob; 572 mtd->write_oob = doc_write_oob;
577 mtd->sync = NULL;
578
579 this->totlen = 0;
580 this->numchips = 0;
581
582 this->curfloor = -1; 573 this->curfloor = -1;
583 this->curchip = -1; 574 this->curchip = -1;
584 mutex_init(&this->lock); 575 mutex_init(&this->lock);
diff --git a/drivers/mtd/devices/doc2001.c b/drivers/mtd/devices/doc2001.c
index a3f7a27499be..7543b98f46c4 100644
--- a/drivers/mtd/devices/doc2001.c
+++ b/drivers/mtd/devices/doc2001.c
@@ -343,25 +343,17 @@ void DoCMil_init(struct mtd_info *mtd)
343 343
344 mtd->type = MTD_NANDFLASH; 344 mtd->type = MTD_NANDFLASH;
345 mtd->flags = MTD_CAP_NANDFLASH; 345 mtd->flags = MTD_CAP_NANDFLASH;
346 mtd->size = 0;
347 346
348 /* FIXME: erase size is not always 8KiB */ 347 /* FIXME: erase size is not always 8KiB */
349 mtd->erasesize = 0x2000; 348 mtd->erasesize = 0x2000;
350
351 mtd->writesize = 512; 349 mtd->writesize = 512;
352 mtd->oobsize = 16; 350 mtd->oobsize = 16;
353 mtd->owner = THIS_MODULE; 351 mtd->owner = THIS_MODULE;
354 mtd->erase = doc_erase; 352 mtd->erase = doc_erase;
355 mtd->point = NULL;
356 mtd->unpoint = NULL;
357 mtd->read = doc_read; 353 mtd->read = doc_read;
358 mtd->write = doc_write; 354 mtd->write = doc_write;
359 mtd->read_oob = doc_read_oob; 355 mtd->read_oob = doc_read_oob;
360 mtd->write_oob = doc_write_oob; 356 mtd->write_oob = doc_write_oob;
361 mtd->sync = NULL;
362
363 this->totlen = 0;
364 this->numchips = 0;
365 this->curfloor = -1; 357 this->curfloor = -1;
366 this->curchip = -1; 358 this->curchip = -1;
367 359
diff --git a/drivers/mtd/devices/doc2001plus.c b/drivers/mtd/devices/doc2001plus.c
index 99351bc3e0ed..177510d0e7ee 100644
--- a/drivers/mtd/devices/doc2001plus.c
+++ b/drivers/mtd/devices/doc2001plus.c
@@ -467,23 +467,14 @@ void DoCMilPlus_init(struct mtd_info *mtd)
467 467
468 mtd->type = MTD_NANDFLASH; 468 mtd->type = MTD_NANDFLASH;
469 mtd->flags = MTD_CAP_NANDFLASH; 469 mtd->flags = MTD_CAP_NANDFLASH;
470 mtd->size = 0;
471
472 mtd->erasesize = 0;
473 mtd->writesize = 512; 470 mtd->writesize = 512;
474 mtd->oobsize = 16; 471 mtd->oobsize = 16;
475 mtd->owner = THIS_MODULE; 472 mtd->owner = THIS_MODULE;
476 mtd->erase = doc_erase; 473 mtd->erase = doc_erase;
477 mtd->point = NULL;
478 mtd->unpoint = NULL;
479 mtd->read = doc_read; 474 mtd->read = doc_read;
480 mtd->write = doc_write; 475 mtd->write = doc_write;
481 mtd->read_oob = doc_read_oob; 476 mtd->read_oob = doc_read_oob;
482 mtd->write_oob = doc_write_oob; 477 mtd->write_oob = doc_write_oob;
483 mtd->sync = NULL;
484
485 this->totlen = 0;
486 this->numchips = 0;
487 this->curfloor = -1; 478 this->curfloor = -1;
488 this->curchip = -1; 479 this->curchip = -1;
489 480
diff --git a/drivers/mtd/devices/docg3.c b/drivers/mtd/devices/docg3.c
index 22d5099f7786..ad11ef0a81f4 100644
--- a/drivers/mtd/devices/docg3.c
+++ b/drivers/mtd/devices/docg3.c
@@ -1821,13 +1821,10 @@ static void __init doc_set_driver_info(int chip_id, struct mtd_info *mtd)
1821 mtd->oobsize = DOC_LAYOUT_OOB_SIZE; 1821 mtd->oobsize = DOC_LAYOUT_OOB_SIZE;
1822 mtd->owner = THIS_MODULE; 1822 mtd->owner = THIS_MODULE;
1823 mtd->erase = doc_erase; 1823 mtd->erase = doc_erase;
1824 mtd->point = NULL;
1825 mtd->unpoint = NULL;
1826 mtd->read = doc_read; 1824 mtd->read = doc_read;
1827 mtd->write = doc_write; 1825 mtd->write = doc_write;
1828 mtd->read_oob = doc_read_oob; 1826 mtd->read_oob = doc_read_oob;
1829 mtd->write_oob = doc_write_oob; 1827 mtd->write_oob = doc_write_oob;
1830 mtd->sync = NULL;
1831 mtd->block_isbad = doc_block_isbad; 1828 mtd->block_isbad = doc_block_isbad;
1832 mtd->ecclayout = &docg3_oobinfo; 1829 mtd->ecclayout = &docg3_oobinfo;
1833} 1830}