diff options
author | Pekon Gupta <pekon@ti.com> | 2014-03-20 09:18:34 -0400 |
---|---|---|
committer | Brian Norris <computersforpeace@gmail.com> | 2014-03-26 02:08:52 -0400 |
commit | 3f4eb14bdbe148fcc3a8e02f506ccc9b8c955ad4 (patch) | |
tree | eff0b8120b1a9d7c21cb97bbde936fa3e829228d /drivers/mtd/devices | |
parent | d9ba46d32c0edc5207fec424230dfa786a24a117 (diff) |
mtd: devices: elm: check for hardware engine's design constraints
ELM hardware engine is used by BCH ecc-schemes for detecting and locating ECC
errors. This patch adds the following checks for ELM hardware engine:
- ELM internal buffers are of 1K,
so it cannot process data with ecc-step-size > 1K.
- ELM engine can execute upto maximum of 8 threads in parallel,
so in *page-mode* (when complete page is processed in single iteration),
ELM cannot support ecc-steps > 8.
Signed-off-by: Pekon Gupta <pekon@ti.com>
Reviewed-by: Ezequiel Garcia <ezequiel.garcia@free-electrons.com>
Signed-off-by: Brian Norris <computersforpeace@gmail.com>
Diffstat (limited to 'drivers/mtd/devices')
-rw-r--r-- | drivers/mtd/devices/elm.c | 13 |
1 files changed, 12 insertions, 1 deletions
diff --git a/drivers/mtd/devices/elm.c b/drivers/mtd/devices/elm.c index f160d2c6cd59..c51752ad072e 100644 --- a/drivers/mtd/devices/elm.c +++ b/drivers/mtd/devices/elm.c | |||
@@ -103,7 +103,8 @@ static u32 elm_read_reg(struct elm_info *info, int offset) | |||
103 | * @dev: ELM device | 103 | * @dev: ELM device |
104 | * @bch_type: Type of BCH ecc | 104 | * @bch_type: Type of BCH ecc |
105 | */ | 105 | */ |
106 | int elm_config(struct device *dev, enum bch_ecc bch_type) | 106 | int elm_config(struct device *dev, enum bch_ecc bch_type, |
107 | int ecc_steps, int ecc_step_size, int ecc_syndrome_size) | ||
107 | { | 108 | { |
108 | u32 reg_val; | 109 | u32 reg_val; |
109 | struct elm_info *info = dev_get_drvdata(dev); | 110 | struct elm_info *info = dev_get_drvdata(dev); |
@@ -112,6 +113,16 @@ int elm_config(struct device *dev, enum bch_ecc bch_type) | |||
112 | dev_err(dev, "Unable to configure elm - device not probed?\n"); | 113 | dev_err(dev, "Unable to configure elm - device not probed?\n"); |
113 | return -ENODEV; | 114 | return -ENODEV; |
114 | } | 115 | } |
116 | /* ELM cannot detect ECC errors for chunks > 1KB */ | ||
117 | if (ecc_step_size > ((ELM_ECC_SIZE + 1) / 2)) { | ||
118 | dev_err(dev, "unsupported config ecc-size=%d\n", ecc_step_size); | ||
119 | return -EINVAL; | ||
120 | } | ||
121 | /* ELM support 8 error syndrome process */ | ||
122 | if (ecc_steps > ERROR_VECTOR_MAX) { | ||
123 | dev_err(dev, "unsupported config ecc-step=%d\n", ecc_steps); | ||
124 | return -EINVAL; | ||
125 | } | ||
115 | 126 | ||
116 | reg_val = (bch_type & ECC_BCH_LEVEL_MASK) | (ELM_ECC_SIZE << 16); | 127 | reg_val = (bch_type & ECC_BCH_LEVEL_MASK) | (ELM_ECC_SIZE << 16); |
117 | elm_write_reg(info, ELM_LOCATION_CONFIG, reg_val); | 128 | elm_write_reg(info, ELM_LOCATION_CONFIG, reg_val); |