aboutsummaryrefslogtreecommitdiffstats
path: root/drivers/mmc
diff options
context:
space:
mode:
authorSebastian Hesselbarth <sebastian.hesselbarth@gmail.com>2014-04-26 15:34:14 -0400
committerChris Ball <chris@printf.net>2014-05-12 18:05:46 -0400
commitb78871d0cf13d37e7bdcf39c49782ca3885343bc (patch)
tree64e3035476499b4ecbe4215dae28248f924e3ea2 /drivers/mmc
parentfcf902bea30a57bd6fa8820619ecdce51e847832 (diff)
mmc: mvsdio: workaround for spurious irqs
SDIO controllers found on Marvell Kirkwood SoCs seem to cause a late, spurious irq although all interrupts have been disabled. This irq doesn't do any harm, neither to HW nor driver. To avoid some "unexpected irq" warning later, we workaround above issue by bailing out of irq handler early, if we didn't expect any. Signed-off-by: Sebastian Hesselbarth <sebastian.hesselbarth@gmail.com> Acked-by: Jason Cooper <jason@lakedaemon.net> Signed-off-by: Ulf Hansson <ulf.hansson@linaro.org> Signed-off-by: Chris Ball <chris@printf.net>
Diffstat (limited to 'drivers/mmc')
-rw-r--r--drivers/mmc/host/mvsdio.c14
1 files changed, 14 insertions, 0 deletions
diff --git a/drivers/mmc/host/mvsdio.c b/drivers/mmc/host/mvsdio.c
index 41aca7f28c23..9377284f8544 100644
--- a/drivers/mmc/host/mvsdio.c
+++ b/drivers/mmc/host/mvsdio.c
@@ -354,6 +354,20 @@ static irqreturn_t mvsd_irq(int irq, void *dev)
354 intr_status, mvsd_read(MVSD_NOR_INTR_EN), 354 intr_status, mvsd_read(MVSD_NOR_INTR_EN),
355 mvsd_read(MVSD_HW_STATE)); 355 mvsd_read(MVSD_HW_STATE));
356 356
357 /*
358 * It looks like, SDIO IP can issue one late, spurious irq
359 * although all irqs should be disabled. To work around this,
360 * bail out early, if we didn't expect any irqs to occur.
361 */
362 if (!mvsd_read(MVSD_NOR_INTR_EN) && !mvsd_read(MVSD_ERR_INTR_EN)) {
363 dev_dbg(host->dev, "spurious irq detected intr 0x%04x intr_en 0x%04x erri 0x%04x erri_en 0x%04x\n",
364 mvsd_read(MVSD_NOR_INTR_STATUS),
365 mvsd_read(MVSD_NOR_INTR_EN),
366 mvsd_read(MVSD_ERR_INTR_STATUS),
367 mvsd_read(MVSD_ERR_INTR_EN));
368 return IRQ_HANDLED;
369 }
370
357 spin_lock(&host->lock); 371 spin_lock(&host->lock);
358 372
359 /* PIO handling, if needed. Messy business... */ 373 /* PIO handling, if needed. Messy business... */