aboutsummaryrefslogtreecommitdiffstats
path: root/drivers/mmc/card/block.c
diff options
context:
space:
mode:
authorAdrian Hunter <adrian.hunter@nokia.com>2010-01-08 17:43:00 -0500
committerLinus Torvalds <torvalds@linux-foundation.org>2010-01-11 12:34:06 -0500
commit5fa83ce284a4b7cd9dcfadd01500b0ed4ab9b740 (patch)
tree853c2e06c085fba633bcfef2c624a068adf2bbf5 /drivers/mmc/card/block.c
parent0a74ff29b8dd8b748f8856352f9a9b5c6cc362cc (diff)
mmc_block: fix queue cleanup
The main bug was that 'blk_cleanup_queue()' was called while the block device could still be in use, for example, because the card was removed while files were still open. In addition, to be sure that 'mmc_request()' will get called for all new requests (so it can error them out), the queue is emptied during cleanup. This is done after the worker thread is stopped to avoid racing with it. Finally, it is not a device error for this to be happening, so quiet the (sometimes very many) error messages. Signed-off-by: Adrian Hunter <adrian.hunter@nokia.com> Cc: <linux-mmc@vger.kernel.org> Cc: <stable@kernel.org> Signed-off-by: Andrew Morton <akpm@linux-foundation.org> Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Diffstat (limited to 'drivers/mmc/card/block.c')
-rw-r--r--drivers/mmc/card/block.c2
1 files changed, 2 insertions, 0 deletions
diff --git a/drivers/mmc/card/block.c b/drivers/mmc/card/block.c
index ee879117017f..1f552c6e7579 100644
--- a/drivers/mmc/card/block.c
+++ b/drivers/mmc/card/block.c
@@ -91,6 +91,8 @@ static void mmc_blk_put(struct mmc_blk_data *md)
91 if (!devmaj) 91 if (!devmaj)
92 devidx = md->disk->first_minor >> MMC_SHIFT; 92 devidx = md->disk->first_minor >> MMC_SHIFT;
93 93
94 blk_cleanup_queue(md->queue.queue);
95
94 __clear_bit(devidx, dev_use); 96 __clear_bit(devidx, dev_use);
95 97
96 put_disk(md->disk); 98 put_disk(md->disk);