[SCSI] enclosure: fix error path - actually return ERR_PTR() on error

we also need to clean up and free the cdev.

Reported-by: Jani Nikula <ext-jani.1.nikula@nokia.com>
Cc: Stable Tree <stable@kernel.org>
Signed-off-by: James Bottomley <James.Bottomley@suse.de>

1 files changed, 5 insertions, 2 deletions

diff --git a/drivers/misc/enclosure.c b/drivers/misc/enclosure.c
index 48c84a58163e..00e5fcac8fdf 100644
--- a/drivers/misc/enclosure.c
+++ b/drivers/misc/enclosure.c
@@ -285,8 +285,11 @@ enclosure_component_register(struct enclosure_device *edev,
         cdev->groups = enclosure_groups;
 
         err = device_register(cdev);
-        if (err)
-                ERR_PTR(err);
+        if (err) {
+                ecomp->number = -1;
+                put_device(cdev);
+                return ERR_PTR(err);
+        }
 
         return ecomp;
 }