aboutsummaryrefslogtreecommitdiffstats
path: root/drivers/misc
diff options
context:
space:
mode:
authorTomas Winkler <tomas.winkler@intel.com>2015-02-10 03:39:38 -0500
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>2015-03-01 22:37:00 -0500
commit4e097bc5d5c948ff8a60ac38a5826f5b6699603d (patch)
treeb764ec7602d340c24c90536a6d9d2d78f6180015 /drivers/misc
parentdb4756fd2f16efae8469dd1e37710919a0af9370 (diff)
mei: iamthif: remove useless iamthif_ioctl variable
iamthif_ioctl is obsolete and can be safely dropped Currently it is set to true during driver runtime Signed-off-by: Tomas Winkler <tomas.winkler@intel.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Diffstat (limited to 'drivers/misc')
-rw-r--r--drivers/misc/mei/amthif.c11
-rw-r--r--drivers/misc/mei/interrupt.c1
-rw-r--r--drivers/misc/mei/mei_dev.h2
3 files changed, 3 insertions, 11 deletions
diff --git a/drivers/misc/mei/amthif.c b/drivers/misc/mei/amthif.c
index 2ad2f94678c8..788b00e23353 100644
--- a/drivers/misc/mei/amthif.c
+++ b/drivers/misc/mei/amthif.c
@@ -52,7 +52,6 @@ void mei_amthif_reset_params(struct mei_device *dev)
52 dev->iamthif_msg_buf_size = 0; 52 dev->iamthif_msg_buf_size = 0;
53 dev->iamthif_msg_buf_index = 0; 53 dev->iamthif_msg_buf_index = 0;
54 dev->iamthif_canceled = false; 54 dev->iamthif_canceled = false;
55 dev->iamthif_ioctl = false;
56 dev->iamthif_state = MEI_IAMTHIF_IDLE; 55 dev->iamthif_state = MEI_IAMTHIF_IDLE;
57 dev->iamthif_timer = 0; 56 dev->iamthif_timer = 0;
58 dev->iamthif_stall_timer = 0; 57 dev->iamthif_stall_timer = 0;
@@ -279,7 +278,6 @@ static int mei_amthif_send_cmd(struct mei_device *dev, struct mei_cl_cb *cb)
279 dev->iamthif_current_cb = cb; 278 dev->iamthif_current_cb = cb;
280 dev->iamthif_file_object = cb->file_object; 279 dev->iamthif_file_object = cb->file_object;
281 dev->iamthif_canceled = false; 280 dev->iamthif_canceled = false;
282 dev->iamthif_ioctl = true;
283 dev->iamthif_msg_buf_size = cb->request_buffer.size; 281 dev->iamthif_msg_buf_size = cb->request_buffer.size;
284 memcpy(dev->iamthif_msg_buf, cb->request_buffer.data, 282 memcpy(dev->iamthif_msg_buf, cb->request_buffer.data,
285 cb->request_buffer.size); 283 cb->request_buffer.size);
@@ -375,7 +373,6 @@ void mei_amthif_run_next_cmd(struct mei_device *dev)
375 dev->iamthif_msg_buf_size = 0; 373 dev->iamthif_msg_buf_size = 0;
376 dev->iamthif_msg_buf_index = 0; 374 dev->iamthif_msg_buf_index = 0;
377 dev->iamthif_canceled = false; 375 dev->iamthif_canceled = false;
378 dev->iamthif_ioctl = true;
379 dev->iamthif_state = MEI_IAMTHIF_IDLE; 376 dev->iamthif_state = MEI_IAMTHIF_IDLE;
380 dev->iamthif_timer = 0; 377 dev->iamthif_timer = 0;
381 dev->iamthif_file_object = NULL; 378 dev->iamthif_file_object = NULL;
@@ -554,11 +551,9 @@ int mei_amthif_irq_read_msg(struct mei_cl *cl,
554 dev->iamthif_stall_timer = 0; 551 dev->iamthif_stall_timer = 0;
555 cb->buf_idx = dev->iamthif_msg_buf_index; 552 cb->buf_idx = dev->iamthif_msg_buf_index;
556 cb->read_time = jiffies; 553 cb->read_time = jiffies;
557 if (dev->iamthif_ioctl) { 554
558 /* found the iamthif cb */ 555 dev_dbg(dev->dev, "complete the amthif read cb.\n ");
559 dev_dbg(dev->dev, "complete the amthif read cb.\n "); 556 list_add_tail(&cb->list, &complete_list->list);
560 list_add_tail(&cb->list, &complete_list->list);
561 }
562 557
563 return 0; 558 return 0;
564 559
diff --git a/drivers/misc/mei/interrupt.c b/drivers/misc/mei/interrupt.c
index 151f0c84a65e..4cb602fba593 100644
--- a/drivers/misc/mei/interrupt.c
+++ b/drivers/misc/mei/interrupt.c
@@ -589,7 +589,6 @@ void mei_timer(struct work_struct *work)
589 dev->iamthif_msg_buf_size = 0; 589 dev->iamthif_msg_buf_size = 0;
590 dev->iamthif_msg_buf_index = 0; 590 dev->iamthif_msg_buf_index = 0;
591 dev->iamthif_canceled = false; 591 dev->iamthif_canceled = false;
592 dev->iamthif_ioctl = true;
593 dev->iamthif_state = MEI_IAMTHIF_IDLE; 592 dev->iamthif_state = MEI_IAMTHIF_IDLE;
594 dev->iamthif_timer = 0; 593 dev->iamthif_timer = 0;
595 594
diff --git a/drivers/misc/mei/mei_dev.h b/drivers/misc/mei/mei_dev.h
index b74d156ed600..6cc68de580ba 100644
--- a/drivers/misc/mei/mei_dev.h
+++ b/drivers/misc/mei/mei_dev.h
@@ -488,7 +488,6 @@ const char *mei_pg_state_str(enum mei_pg_state state);
488 * @iamthif_msg_buf_index : current index in amthif message request buffer 488 * @iamthif_msg_buf_index : current index in amthif message request buffer
489 * @iamthif_state : amthif processor state 489 * @iamthif_state : amthif processor state
490 * @iamthif_flow_control_pending: amthif waits for flow control 490 * @iamthif_flow_control_pending: amthif waits for flow control
491 * @iamthif_ioctl : wait for completion if amthif control message
492 * @iamthif_canceled : current amthif command is canceled 491 * @iamthif_canceled : current amthif command is canceled
493 * 492 *
494 * @init_work : work item for the device init 493 * @init_work : work item for the device init
@@ -588,7 +587,6 @@ struct mei_device {
588 u32 iamthif_msg_buf_index; 587 u32 iamthif_msg_buf_index;
589 enum iamthif_states iamthif_state; 588 enum iamthif_states iamthif_state;
590 bool iamthif_flow_control_pending; 589 bool iamthif_flow_control_pending;
591 bool iamthif_ioctl;
592 bool iamthif_canceled; 590 bool iamthif_canceled;
593 591
594 struct work_struct init_work; 592 struct work_struct init_work;