Merge tag 'omap-devel-am33xx-for-v3.7' of git://git.kernel.org/pub/scm/linux/kernel/git/tmlind/linux-omap into next/soc

From Tony Lindgren:
From Paul Walmsley <paul@pwsan.com>:

AM33xx hwmod data and miscellaneous clock and hwmod fixes.  AM33xx
should now boot on mainline after this is applied, according to
Vaibhav.

(The shortlog makes no sense here since it contains mostly the dependent
cleanups that are part of the preceding branches).

Signed-off-by: Olof Johansson <olof@lixom.net>

1 files changed, 59 insertions, 69 deletions

diff --git a/drivers/misc/pti.c b/drivers/misc/pti.c
index b7eb545394b1..4999b34b7a60 100644
--- a/drivers/misc/pti.c
+++ b/drivers/misc/pti.c
@@ -60,7 +60,7 @@ struct pti_tty {
 };
 
 struct pti_dev {
-        struct tty_port port;
+        struct tty_port port[PTITTY_MINOR_NUM];
         unsigned long pti_addr;
         unsigned long aperture_base;
         void __iomem *pti_ioaddr;
@@ -76,7 +76,7 @@ struct pti_dev {
  */
 static DEFINE_MUTEX(alloclock);
 
-static struct pci_device_id pci_ids[] __devinitconst = {
+static const struct pci_device_id pci_ids[] __devinitconst = {
                 {PCI_DEVICE(PCI_VENDOR_ID_INTEL, 0x82B)},
                 {0}
 };
@@ -393,25 +393,6 @@ void pti_writedata(struct pti_masterchannel *mc, u8 *buf, int count)
 }
 EXPORT_SYMBOL_GPL(pti_writedata);
 
-/**
- * pti_pci_remove()- Driver exit method to remove PTI from
- *                 PCI bus.
- * @pdev: variable containing pci info of PTI.
- */
-static void __devexit pti_pci_remove(struct pci_dev *pdev)
-{
-        struct pti_dev *drv_data;
-
-        drv_data = pci_get_drvdata(pdev);
-        if (drv_data != NULL) {
-                pci_iounmap(pdev, drv_data->pti_ioaddr);
-                pci_set_drvdata(pdev, NULL);
-                kfree(drv_data);
-                pci_release_region(pdev, 1);
-                pci_disable_device(pdev);
-        }
-}
-
 /*
  * for the tty_driver_*() basic function descriptions, see tty_driver.h.
  * Specific header comments made for PTI-related specifics.
@@ -446,7 +427,7 @@ static int pti_tty_driver_open(struct tty_struct *tty, struct file *filp)
          * also removes a locking requirement for the actual write
          * procedure.
          */
-        return tty_port_open(&drv_data->port, tty, filp);
+        return tty_port_open(tty->port, tty, filp);
 }
 
 /**
@@ -462,7 +443,7 @@ static int pti_tty_driver_open(struct tty_struct *tty, struct file *filp)
  */
 static void pti_tty_driver_close(struct tty_struct *tty, struct file *filp)
 {
-        tty_port_close(&drv_data->port, tty, filp);
+        tty_port_close(tty->port, tty, filp);
 }
 
 /**
@@ -818,6 +799,7 @@ static const struct tty_port_operations tty_port_ops = {
 static int __devinit pti_pci_probe(struct pci_dev *pdev,
                 const struct pci_device_id *ent)
 {
+        unsigned int a;
         int retval = -EINVAL;
         int pci_bar = 1;
 
@@ -830,7 +812,7 @@ static int __devinit pti_pci_probe(struct pci_dev *pdev,
                         __func__, __LINE__);
                 pr_err("%s(%d): Error value returned: %d\n",
                         __func__, __LINE__, retval);
-                return retval;
+                goto err;
         }
 
         retval = pci_enable_device(pdev);
@@ -838,17 +820,16 @@ static int __devinit pti_pci_probe(struct pci_dev *pdev,
                 dev_err(&pdev->dev,
                         "%s: pci_enable_device() returned error %d\n",
                         __func__, retval);
-                return retval;
+                goto err_unreg_misc;
         }
 
         drv_data = kzalloc(sizeof(*drv_data), GFP_KERNEL);
-
         if (drv_data == NULL) {
                 retval = -ENOMEM;
                 dev_err(&pdev->dev,
                         "%s(%d): kmalloc() returned NULL memory.\n",
                         __func__, __LINE__);
-                return retval;
+                goto err_disable_pci;
         }
         drv_data->pti_addr = pci_resource_start(pdev, pci_bar);
 
@@ -857,33 +838,65 @@ static int __devinit pti_pci_probe(struct pci_dev *pdev,
                 dev_err(&pdev->dev,
                         "%s(%d): pci_request_region() returned error %d\n",
                         __func__, __LINE__, retval);
-                kfree(drv_data);
-                return retval;
+                goto err_free_dd;
         }
         drv_data->aperture_base = drv_data->pti_addr+APERTURE_14;
         drv_data->pti_ioaddr =
                 ioremap_nocache((u32)drv_data->aperture_base,
                 APERTURE_LEN);
         if (!drv_data->pti_ioaddr) {
-                pci_release_region(pdev, pci_bar);
                 retval = -ENOMEM;
-                kfree(drv_data);
-                return retval;
+                goto err_rel_reg;
         }
 
         pci_set_drvdata(pdev, drv_data);
 
-        tty_port_init(&drv_data->port);
-        drv_data->port.ops = &tty_port_ops;
+        for (a = 0; a < PTITTY_MINOR_NUM; a++) {
+                struct tty_port *port = &drv_data->port[a];
+                tty_port_init(port);
+                port->ops = &tty_port_ops;
 
-        tty_register_device(pti_tty_driver, 0, &pdev->dev);
-        tty_register_device(pti_tty_driver, 1, &pdev->dev);
+                tty_port_register_device(port, pti_tty_driver, a, &pdev->dev);
+        }
 
         register_console(&pti_console);
 
+        return 0;
+err_rel_reg:
+        pci_release_region(pdev, pci_bar);
+err_free_dd:
+        kfree(drv_data);
+err_disable_pci:
+        pci_disable_device(pdev);
+err_unreg_misc:
+        misc_deregister(&pti_char_driver);
+err:
         return retval;
 }
 
+/**
+ * pti_pci_remove()- Driver exit method to remove PTI from
+ *                 PCI bus.
+ * @pdev: variable containing pci info of PTI.
+ */
+static void __devexit pti_pci_remove(struct pci_dev *pdev)
+{
+        struct pti_dev *drv_data = pci_get_drvdata(pdev);
+
+        unregister_console(&pti_console);
+
+        tty_unregister_device(pti_tty_driver, 0);
+        tty_unregister_device(pti_tty_driver, 1);
+
+        iounmap(drv_data->pti_ioaddr);
+        pci_set_drvdata(pdev, NULL);
+        kfree(drv_data);
+        pci_release_region(pdev, 1);
+        pci_disable_device(pdev);
+
+        misc_deregister(&pti_char_driver);
+}
+
 static struct pci_driver pti_pci_driver = {
         .name           = PCINAME,
         .id_table       = pci_ids,
@@ -933,25 +946,24 @@ static int __init pti_init(void)
                 pr_err("%s(%d): Error value returned: %d\n",
                         __func__, __LINE__, retval);
 
-                pti_tty_driver = NULL;
-                return retval;
+                goto put_tty;
         }
 
         retval = pci_register_driver(&pti_pci_driver);
-
         if (retval) {
                 pr_err("%s(%d): PCI registration failed of pti driver\n",
                         __func__, __LINE__);
                 pr_err("%s(%d): Error value returned: %d\n",
                         __func__, __LINE__, retval);
-
-                tty_unregister_driver(pti_tty_driver);
-                pr_err("%s(%d): Unregistering TTY part of pti driver\n",
-                        __func__, __LINE__);
-                pti_tty_driver = NULL;
-                return retval;
+                goto unreg_tty;
         }
 
+        return 0;
+unreg_tty:
+        tty_unregister_driver(pti_tty_driver);
+put_tty:
+        put_tty_driver(pti_tty_driver);
+        pti_tty_driver = NULL;
         return retval;
 }
 
@@ -960,31 +972,9 @@ static int __init pti_init(void)
  */
 static void __exit pti_exit(void)
 {
-        int retval;
-
-        tty_unregister_device(pti_tty_driver, 0);
-        tty_unregister_device(pti_tty_driver, 1);
-
-        retval = tty_unregister_driver(pti_tty_driver);
-        if (retval) {
-                pr_err("%s(%d): TTY unregistration failed of pti driver\n",
-                        __func__, __LINE__);
-                pr_err("%s(%d): Error value returned: %d\n",
-                        __func__, __LINE__, retval);
-        }
-
+        tty_unregister_driver(pti_tty_driver);
         pci_unregister_driver(&pti_pci_driver);
-
-        retval = misc_deregister(&pti_char_driver);
-        if (retval) {
-                pr_err("%s(%d): CHAR unregistration failed of pti driver\n",
-                        __func__, __LINE__);
-                pr_err("%s(%d): Error value returned: %d\n",
-                        __func__, __LINE__, retval);
-        }
-
-        unregister_console(&pti_console);
-        return;
+        put_tty_driver(pti_tty_driver);
 }
 
 module_init(pti_init);