diff options
author | Wei WANG <wei_wang@realsil.com.cn> | 2013-09-13 05:45:43 -0400 |
---|---|---|
committer | Lee Jones <lee.jones@linaro.org> | 2013-10-23 11:20:59 -0400 |
commit | 26b818511c6562ce372566c219a2ef1afea35fe6 (patch) | |
tree | c6fc61d336ddea8d72dd8b6deb6cd1ec435bc5b8 /drivers/mfd/rts5249.c | |
parent | 7902fe8cbc58ae2bd3dad1a8ecf28ce83b1ba3a8 (diff) |
mfd: rtsx: Modify rts5249_optimize_phy
In some platforms, specially Thinkpad series, rts5249 won't be
initialized properly. So we need adjust some phy parameters to
improve the compatibility issue.
It is a little different between simulation and real chip. We have
no idea about which configuration is better before tape-out. We set
default settings according to simulation, but need to tune these
parameters after getting the real chip.
I can't explain every change in detail here. The below information is
just a rough description:
PHY_REG_REV: Disable internal clkreq_tx, enable rx_pwst
PHY_BPCR: No change, just turn the magic number to macro definitions
PHY_PCR: Change OOBS sensitivity, from 60mV to 90mV
PHY_RCR2: Control charge-pump current automatically
PHY_FLD4: Use TX cmu reference clock
PHY_RDR: Change RXDSEL from 30nF to 1.9nF
PHY_RCR1: Change the duration between adp_st and asserting cp_en from
0.32 us to 0.64us
PHY_FLD3: Adjust internal timers
PHY_TUNE: Fine tune the regulator12 output voltage
Signed-off-by: Wei WANG <wei_wang@realsil.com.cn>
Signed-off-by: Lee Jones <lee.jones@linaro.org>
Diffstat (limited to 'drivers/mfd/rts5249.c')
-rw-r--r-- | drivers/mfd/rts5249.c | 48 |
1 files changed, 46 insertions, 2 deletions
diff --git a/drivers/mfd/rts5249.c b/drivers/mfd/rts5249.c index 3b835f593e35..573de7bfcced 100644 --- a/drivers/mfd/rts5249.c +++ b/drivers/mfd/rts5249.c | |||
@@ -130,13 +130,57 @@ static int rts5249_optimize_phy(struct rtsx_pcr *pcr) | |||
130 | { | 130 | { |
131 | int err; | 131 | int err; |
132 | 132 | ||
133 | err = rtsx_pci_write_phy_register(pcr, PHY_REG_REV, 0xFE46); | 133 | err = rtsx_pci_write_phy_register(pcr, PHY_REG_REV, |
134 | PHY_REG_REV_RESV | PHY_REG_REV_RXIDLE_LATCHED | | ||
135 | PHY_REG_REV_P1_EN | PHY_REG_REV_RXIDLE_EN | | ||
136 | PHY_REG_REV_RX_PWST | PHY_REG_REV_CLKREQ_DLY_TIMER_1_0 | | ||
137 | PHY_REG_REV_STOP_CLKRD | PHY_REG_REV_STOP_CLKWR); | ||
134 | if (err < 0) | 138 | if (err < 0) |
135 | return err; | 139 | return err; |
136 | 140 | ||
137 | msleep(1); | 141 | msleep(1); |
138 | 142 | ||
139 | return rtsx_pci_write_phy_register(pcr, PHY_BPCR, 0x05C0); | 143 | err = rtsx_pci_write_phy_register(pcr, PHY_BPCR, |
144 | PHY_BPCR_IBRXSEL | PHY_BPCR_IBTXSEL | | ||
145 | PHY_BPCR_IB_FILTER | PHY_BPCR_CMIRROR_EN); | ||
146 | if (err < 0) | ||
147 | return err; | ||
148 | err = rtsx_pci_write_phy_register(pcr, PHY_PCR, | ||
149 | PHY_PCR_FORCE_CODE | PHY_PCR_OOBS_CALI_50 | | ||
150 | PHY_PCR_OOBS_VCM_08 | PHY_PCR_OOBS_SEN_90 | | ||
151 | PHY_PCR_RSSI_EN); | ||
152 | if (err < 0) | ||
153 | return err; | ||
154 | err = rtsx_pci_write_phy_register(pcr, PHY_RCR2, | ||
155 | PHY_RCR2_EMPHASE_EN | PHY_RCR2_NADJR | | ||
156 | PHY_RCR2_CDR_CP_10 | PHY_RCR2_CDR_SR_2 | | ||
157 | PHY_RCR2_FREQSEL_12 | PHY_RCR2_CPADJEN | | ||
158 | PHY_RCR2_CDR_SC_8 | PHY_RCR2_CALIB_LATE); | ||
159 | if (err < 0) | ||
160 | return err; | ||
161 | err = rtsx_pci_write_phy_register(pcr, PHY_FLD4, | ||
162 | PHY_FLD4_FLDEN_SEL | PHY_FLD4_REQ_REF | | ||
163 | PHY_FLD4_RXAMP_OFF | PHY_FLD4_REQ_ADDA | | ||
164 | PHY_FLD4_BER_COUNT | PHY_FLD4_BER_TIMER | | ||
165 | PHY_FLD4_BER_CHK_EN); | ||
166 | if (err < 0) | ||
167 | return err; | ||
168 | err = rtsx_pci_write_phy_register(pcr, PHY_RDR, PHY_RDR_RXDSEL_1_9); | ||
169 | if (err < 0) | ||
170 | return err; | ||
171 | err = rtsx_pci_write_phy_register(pcr, PHY_RCR1, | ||
172 | PHY_RCR1_ADP_TIME | PHY_RCR1_VCO_COARSE); | ||
173 | if (err < 0) | ||
174 | return err; | ||
175 | err = rtsx_pci_write_phy_register(pcr, PHY_FLD3, | ||
176 | PHY_FLD3_TIMER_4 | PHY_FLD3_TIMER_6 | | ||
177 | PHY_FLD3_RXDELINK); | ||
178 | if (err < 0) | ||
179 | return err; | ||
180 | return rtsx_pci_write_phy_register(pcr, PHY_TUNE, | ||
181 | PHY_TUNE_TUNEREF_1_0 | PHY_TUNE_VBGSEL_1252 | | ||
182 | PHY_TUNE_SDBUS_33 | PHY_TUNE_TUNED18 | | ||
183 | PHY_TUNE_TUNED12); | ||
140 | } | 184 | } |
141 | 185 | ||
142 | static int rts5249_turn_on_led(struct rtsx_pcr *pcr) | 186 | static int rts5249_turn_on_led(struct rtsx_pcr *pcr) |