diff options
| author | Al Viro <viro@zeniv.linux.org.uk> | 2013-05-05 21:52:57 -0400 |
|---|---|---|
| committer | Al Viro <viro@zeniv.linux.org.uk> | 2013-05-07 02:16:21 -0400 |
| commit | db2a144bedd58b3dcf19950c2f476c58c9f39d18 (patch) | |
| tree | 931f1b5a8e6bafe388b317bce02a9fd9af309d38 /drivers/message | |
| parent | a8ca889ed9585894d53fd8919d80cbe8baff09e7 (diff) | |
block_device_operations->release() should return void
The value passed is 0 in all but "it can never happen" cases (and those
only in a couple of drivers) *and* it would've been lost on the way
out anyway, even if something tried to pass something meaningful.
Just don't bother.
Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
Diffstat (limited to 'drivers/message')
| -rw-r--r-- | drivers/message/i2o/i2o_block.c | 8 |
1 files changed, 2 insertions, 6 deletions
diff --git a/drivers/message/i2o/i2o_block.c b/drivers/message/i2o/i2o_block.c index 49e86aed2bc4..6fc3866965df 100644 --- a/drivers/message/i2o/i2o_block.c +++ b/drivers/message/i2o/i2o_block.c | |||
| @@ -600,10 +600,8 @@ static int i2o_block_open(struct block_device *bdev, fmode_t mode) | |||
| 600 | * | 600 | * |
| 601 | * Unlock and unmount the media, and power down the device. Gets called if | 601 | * Unlock and unmount the media, and power down the device. Gets called if |
| 602 | * the block device is closed. | 602 | * the block device is closed. |
| 603 | * | ||
| 604 | * Returns 0 on success or negative error code on failure. | ||
| 605 | */ | 603 | */ |
| 606 | static int i2o_block_release(struct gendisk *disk, fmode_t mode) | 604 | static void i2o_block_release(struct gendisk *disk, fmode_t mode) |
| 607 | { | 605 | { |
| 608 | struct i2o_block_device *dev = disk->private_data; | 606 | struct i2o_block_device *dev = disk->private_data; |
| 609 | u8 operation; | 607 | u8 operation; |
| @@ -617,7 +615,7 @@ static int i2o_block_release(struct gendisk *disk, fmode_t mode) | |||
| 617 | * the TID no longer exists. | 615 | * the TID no longer exists. |
| 618 | */ | 616 | */ |
| 619 | if (!dev->i2o_dev) | 617 | if (!dev->i2o_dev) |
| 620 | return 0; | 618 | return; |
| 621 | 619 | ||
| 622 | mutex_lock(&i2o_block_mutex); | 620 | mutex_lock(&i2o_block_mutex); |
| 623 | i2o_block_device_flush(dev->i2o_dev); | 621 | i2o_block_device_flush(dev->i2o_dev); |
| @@ -631,8 +629,6 @@ static int i2o_block_release(struct gendisk *disk, fmode_t mode) | |||
| 631 | 629 | ||
| 632 | i2o_block_device_power(dev, operation); | 630 | i2o_block_device_power(dev, operation); |
| 633 | mutex_unlock(&i2o_block_mutex); | 631 | mutex_unlock(&i2o_block_mutex); |
| 634 | |||
| 635 | return 0; | ||
| 636 | } | 632 | } |
| 637 | 633 | ||
| 638 | static int i2o_block_getgeo(struct block_device *bdev, struct hd_geometry *geo) | 634 | static int i2o_block_getgeo(struct block_device *bdev, struct hd_geometry *geo) |
