aboutsummaryrefslogtreecommitdiffstats
path: root/drivers/media
diff options
context:
space:
mode:
authorPeter Senna Tschudin <peter.senna@gmail.com>2012-09-14 11:46:52 -0400
committerMauro Carvalho Chehab <mchehab@redhat.com>2012-10-06 10:30:35 -0400
commitac0fe5ba7f2b81a0bc4a7b97455d26e127875393 (patch)
tree44d843f4f78acd02b551c3a7fb07f5a96d6a13f3 /drivers/media
parent20eb13a77ebcba4341095c453c33dacba44519f9 (diff)
[media] drivers/media/platform/davinci/vpbe.c: Remove unused label and rename remaining labels
Remove unused label and rename remaining labels Signed-off-by: Peter Senna Tschudin <peter.senna@gmail.com> Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
Diffstat (limited to 'drivers/media')
-rw-r--r--drivers/media/platform/davinci/vpbe.c25
1 files changed, 12 insertions, 13 deletions
diff --git a/drivers/media/platform/davinci/vpbe.c b/drivers/media/platform/davinci/vpbe.c
index 953cf8ca3a95..69d7a58c92c3 100644
--- a/drivers/media/platform/davinci/vpbe.c
+++ b/drivers/media/platform/davinci/vpbe.c
@@ -610,11 +610,11 @@ static int vpbe_initialize(struct device *dev, struct vpbe_device *vpbe_dev)
610 vpbe_dev->dac_clk = clk_get(vpbe_dev->pdev, "vpss_dac"); 610 vpbe_dev->dac_clk = clk_get(vpbe_dev->pdev, "vpss_dac");
611 if (IS_ERR(vpbe_dev->dac_clk)) { 611 if (IS_ERR(vpbe_dev->dac_clk)) {
612 ret = PTR_ERR(vpbe_dev->dac_clk); 612 ret = PTR_ERR(vpbe_dev->dac_clk);
613 goto vpbe_unlock; 613 goto fail_mutex_unlock;
614 } 614 }
615 if (clk_enable(vpbe_dev->dac_clk)) { 615 if (clk_enable(vpbe_dev->dac_clk)) {
616 ret = -ENODEV; 616 ret = -ENODEV;
617 goto vpbe_unlock; 617 goto fail_mutex_unlock;
618 } 618 }
619 } 619 }
620 620
@@ -626,7 +626,7 @@ static int vpbe_initialize(struct device *dev, struct vpbe_device *vpbe_dev)
626 if (ret) { 626 if (ret) {
627 v4l2_err(dev->driver, 627 v4l2_err(dev->driver,
628 "Unable to register v4l2 device.\n"); 628 "Unable to register v4l2 device.\n");
629 goto vpbe_fail_clock; 629 goto fail_clk_put;
630 } 630 }
631 v4l2_info(&vpbe_dev->v4l2_dev, "vpbe v4l2 device registered\n"); 631 v4l2_info(&vpbe_dev->v4l2_dev, "vpbe v4l2 device registered\n");
632 632
@@ -642,7 +642,7 @@ static int vpbe_initialize(struct device *dev, struct vpbe_device *vpbe_dev)
642 v4l2_err(&vpbe_dev->v4l2_dev, 642 v4l2_err(&vpbe_dev->v4l2_dev,
643 "vpbe unable to init venc sub device\n"); 643 "vpbe unable to init venc sub device\n");
644 ret = -ENODEV; 644 ret = -ENODEV;
645 goto vpbe_fail_v4l2_device; 645 goto fail_dev_unregister;
646 } 646 }
647 /* initialize osd device */ 647 /* initialize osd device */
648 osd_device = vpbe_dev->osd_device; 648 osd_device = vpbe_dev->osd_device;
@@ -653,7 +653,7 @@ static int vpbe_initialize(struct device *dev, struct vpbe_device *vpbe_dev)
653 v4l2_err(&vpbe_dev->v4l2_dev, 653 v4l2_err(&vpbe_dev->v4l2_dev,
654 "unable to initialize the OSD device"); 654 "unable to initialize the OSD device");
655 err = -ENOMEM; 655 err = -ENOMEM;
656 goto vpbe_fail_v4l2_device; 656 goto fail_dev_unregister;
657 } 657 }
658 } 658 }
659 659
@@ -669,7 +669,7 @@ static int vpbe_initialize(struct device *dev, struct vpbe_device *vpbe_dev)
669 v4l2_err(&vpbe_dev->v4l2_dev, 669 v4l2_err(&vpbe_dev->v4l2_dev,
670 "unable to allocate memory for encoders sub devices"); 670 "unable to allocate memory for encoders sub devices");
671 ret = -ENOMEM; 671 ret = -ENOMEM;
672 goto vpbe_fail_v4l2_device; 672 goto fail_dev_unregister;
673 } 673 }
674 674
675 i2c_adap = i2c_get_adapter(vpbe_dev->cfg->i2c_adapter_id); 675 i2c_adap = i2c_get_adapter(vpbe_dev->cfg->i2c_adapter_id);
@@ -695,7 +695,7 @@ static int vpbe_initialize(struct device *dev, struct vpbe_device *vpbe_dev)
695 " failed to register", 695 " failed to register",
696 enc_info->module_name); 696 enc_info->module_name);
697 ret = -ENODEV; 697 ret = -ENODEV;
698 goto vpbe_fail_sd_register; 698 goto fail_kfree_encoders;
699 } 699 }
700 } else 700 } else
701 v4l2_warn(&vpbe_dev->v4l2_dev, "non-i2c encoders" 701 v4l2_warn(&vpbe_dev->v4l2_dev, "non-i2c encoders"
@@ -714,7 +714,7 @@ static int vpbe_initialize(struct device *dev, struct vpbe_device *vpbe_dev)
714 "amplifier %s failed to register", 714 "amplifier %s failed to register",
715 amp_info->module_name); 715 amp_info->module_name);
716 ret = -ENODEV; 716 ret = -ENODEV;
717 goto vpbe_fail_amp_register; 717 goto fail_kfree_encoders;
718 } 718 }
719 v4l2_info(&vpbe_dev->v4l2_dev, 719 v4l2_info(&vpbe_dev->v4l2_dev,
720 "v4l2 sub device %s registered\n", 720 "v4l2 sub device %s registered\n",
@@ -754,15 +754,14 @@ static int vpbe_initialize(struct device *dev, struct vpbe_device *vpbe_dev)
754 /* TBD handling of bootargs for default output and mode */ 754 /* TBD handling of bootargs for default output and mode */
755 return 0; 755 return 0;
756 756
757vpbe_fail_amp_register: 757fail_kfree_encoders:
758vpbe_fail_sd_register:
759 kfree(vpbe_dev->encoders); 758 kfree(vpbe_dev->encoders);
760vpbe_fail_v4l2_device: 759fail_dev_unregister:
761 v4l2_device_unregister(&vpbe_dev->v4l2_dev); 760 v4l2_device_unregister(&vpbe_dev->v4l2_dev);
762vpbe_fail_clock: 761fail_clk_put:
763 if (strcmp(vpbe_dev->cfg->module_name, "dm644x-vpbe-display") != 0) 762 if (strcmp(vpbe_dev->cfg->module_name, "dm644x-vpbe-display") != 0)
764 clk_put(vpbe_dev->dac_clk); 763 clk_put(vpbe_dev->dac_clk);
765vpbe_unlock: 764fail_mutex_unlock:
766 mutex_unlock(&vpbe_dev->lock); 765 mutex_unlock(&vpbe_dev->lock);
767 return ret; 766 return ret;
768} 767}