diff options
author | Tomi Valkeinen <tomi.valkeinen@ti.com> | 2012-11-12 08:17:39 -0500 |
---|---|---|
committer | Tomi Valkeinen <tomi.valkeinen@ti.com> | 2012-11-29 12:09:16 -0500 |
commit | 950e2fb420d54bf0ee0de2fb0f146827a98330bf (patch) | |
tree | 77751ca395115f2c0eef332e2e3179c15faeb0af /drivers/media | |
parent | bdb736abfad5d61d1004dcc11dae2f7b651e5bb4 (diff) |
[media] omap_vout: use omapdss's version instead of cpu_is_*
cpu_is_* class functions create a dependency to OMAP platform code.
omapdss driver, which omap_vout uses, exposes a function to get the
version of the DSS hardware.
To remove the dependency to OMAP platform code this patch changes
omap_vout to use the omapdss version. For most of the checks, the ones
dealing with DSS differences, this is actually more correct than using
cpu_is_* functions. For the check whether VRFB is available or not this
is not really correct, but still works fine.
Signed-off-by: Tomi Valkeinen <tomi.valkeinen@ti.com>
Tested-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Acked-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Acked-by: Mauro Carvalho Chehab <mchehab@redhat.com>
Diffstat (limited to 'drivers/media')
-rw-r--r-- | drivers/media/platform/omap/omap_vout.c | 3 | ||||
-rw-r--r-- | drivers/media/platform/omap/omap_voutlib.c | 38 | ||||
-rw-r--r-- | drivers/media/platform/omap/omap_voutlib.h | 3 |
3 files changed, 32 insertions, 12 deletions
diff --git a/drivers/media/platform/omap/omap_vout.c b/drivers/media/platform/omap/omap_vout.c index 3ff94a30fde4..7b1afc8585c6 100644 --- a/drivers/media/platform/omap/omap_vout.c +++ b/drivers/media/platform/omap/omap_vout.c | |||
@@ -44,7 +44,6 @@ | |||
44 | #include <media/v4l2-device.h> | 44 | #include <media/v4l2-device.h> |
45 | #include <media/v4l2-ioctl.h> | 45 | #include <media/v4l2-ioctl.h> |
46 | 46 | ||
47 | #include <plat/cpu.h> | ||
48 | #include <plat/dma.h> | 47 | #include <plat/dma.h> |
49 | #include <video/omapvrfb.h> | 48 | #include <video/omapvrfb.h> |
50 | #include <video/omapdss.h> | 49 | #include <video/omapdss.h> |
@@ -2064,7 +2063,7 @@ static int __init omap_vout_create_video_devices(struct platform_device *pdev) | |||
2064 | vout->vid_info.id = k + 1; | 2063 | vout->vid_info.id = k + 1; |
2065 | 2064 | ||
2066 | /* Set VRFB as rotation_type for omap2 and omap3 */ | 2065 | /* Set VRFB as rotation_type for omap2 and omap3 */ |
2067 | if (cpu_is_omap24xx() || cpu_is_omap34xx()) | 2066 | if (omap_vout_dss_omap24xx() || omap_vout_dss_omap34xx()) |
2068 | vout->vid_info.rotation_type = VOUT_ROT_VRFB; | 2067 | vout->vid_info.rotation_type = VOUT_ROT_VRFB; |
2069 | 2068 | ||
2070 | /* Setup the default configuration for the video devices | 2069 | /* Setup the default configuration for the video devices |
diff --git a/drivers/media/platform/omap/omap_voutlib.c b/drivers/media/platform/omap/omap_voutlib.c index 115408b9274f..80b0d88f125c 100644 --- a/drivers/media/platform/omap/omap_voutlib.c +++ b/drivers/media/platform/omap/omap_voutlib.c | |||
@@ -26,7 +26,7 @@ | |||
26 | 26 | ||
27 | #include <linux/dma-mapping.h> | 27 | #include <linux/dma-mapping.h> |
28 | 28 | ||
29 | #include <plat/cpu.h> | 29 | #include <video/omapdss.h> |
30 | 30 | ||
31 | #include "omap_voutlib.h" | 31 | #include "omap_voutlib.h" |
32 | 32 | ||
@@ -124,7 +124,7 @@ int omap_vout_new_window(struct v4l2_rect *crop, | |||
124 | win->chromakey = new_win->chromakey; | 124 | win->chromakey = new_win->chromakey; |
125 | 125 | ||
126 | /* Adjust the cropping window to allow for resizing limitation */ | 126 | /* Adjust the cropping window to allow for resizing limitation */ |
127 | if (cpu_is_omap24xx()) { | 127 | if (omap_vout_dss_omap24xx()) { |
128 | /* For 24xx limit is 8x to 1/2x scaling. */ | 128 | /* For 24xx limit is 8x to 1/2x scaling. */ |
129 | if ((crop->height/win->w.height) >= 2) | 129 | if ((crop->height/win->w.height) >= 2) |
130 | crop->height = win->w.height * 2; | 130 | crop->height = win->w.height * 2; |
@@ -140,7 +140,7 @@ int omap_vout_new_window(struct v4l2_rect *crop, | |||
140 | if (crop->height != win->w.height) | 140 | if (crop->height != win->w.height) |
141 | crop->width = 768; | 141 | crop->width = 768; |
142 | } | 142 | } |
143 | } else if (cpu_is_omap34xx()) { | 143 | } else if (omap_vout_dss_omap34xx()) { |
144 | /* For 34xx limit is 8x to 1/4x scaling. */ | 144 | /* For 34xx limit is 8x to 1/4x scaling. */ |
145 | if ((crop->height/win->w.height) >= 4) | 145 | if ((crop->height/win->w.height) >= 4) |
146 | crop->height = win->w.height * 4; | 146 | crop->height = win->w.height * 4; |
@@ -196,7 +196,7 @@ int omap_vout_new_crop(struct v4l2_pix_format *pix, | |||
196 | if (try_crop.width <= 0 || try_crop.height <= 0) | 196 | if (try_crop.width <= 0 || try_crop.height <= 0) |
197 | return -EINVAL; | 197 | return -EINVAL; |
198 | 198 | ||
199 | if (cpu_is_omap24xx()) { | 199 | if (omap_vout_dss_omap24xx()) { |
200 | if (try_crop.height != win->w.height) { | 200 | if (try_crop.height != win->w.height) { |
201 | /* If we're resizing vertically, we can't support a | 201 | /* If we're resizing vertically, we can't support a |
202 | * crop width wider than 768 pixels. | 202 | * crop width wider than 768 pixels. |
@@ -207,9 +207,9 @@ int omap_vout_new_crop(struct v4l2_pix_format *pix, | |||
207 | } | 207 | } |
208 | /* vertical resizing */ | 208 | /* vertical resizing */ |
209 | vresize = (1024 * try_crop.height) / win->w.height; | 209 | vresize = (1024 * try_crop.height) / win->w.height; |
210 | if (cpu_is_omap24xx() && (vresize > 2048)) | 210 | if (omap_vout_dss_omap24xx() && (vresize > 2048)) |
211 | vresize = 2048; | 211 | vresize = 2048; |
212 | else if (cpu_is_omap34xx() && (vresize > 4096)) | 212 | else if (omap_vout_dss_omap34xx() && (vresize > 4096)) |
213 | vresize = 4096; | 213 | vresize = 4096; |
214 | 214 | ||
215 | win->w.height = ((1024 * try_crop.height) / vresize) & ~1; | 215 | win->w.height = ((1024 * try_crop.height) / vresize) & ~1; |
@@ -226,9 +226,9 @@ int omap_vout_new_crop(struct v4l2_pix_format *pix, | |||
226 | } | 226 | } |
227 | /* horizontal resizing */ | 227 | /* horizontal resizing */ |
228 | hresize = (1024 * try_crop.width) / win->w.width; | 228 | hresize = (1024 * try_crop.width) / win->w.width; |
229 | if (cpu_is_omap24xx() && (hresize > 2048)) | 229 | if (omap_vout_dss_omap24xx() && (hresize > 2048)) |
230 | hresize = 2048; | 230 | hresize = 2048; |
231 | else if (cpu_is_omap34xx() && (hresize > 4096)) | 231 | else if (omap_vout_dss_omap34xx() && (hresize > 4096)) |
232 | hresize = 4096; | 232 | hresize = 4096; |
233 | 233 | ||
234 | win->w.width = ((1024 * try_crop.width) / hresize) & ~1; | 234 | win->w.width = ((1024 * try_crop.width) / hresize) & ~1; |
@@ -243,7 +243,7 @@ int omap_vout_new_crop(struct v4l2_pix_format *pix, | |||
243 | if (try_crop.width == 0) | 243 | if (try_crop.width == 0) |
244 | try_crop.width = 2; | 244 | try_crop.width = 2; |
245 | } | 245 | } |
246 | if (cpu_is_omap24xx()) { | 246 | if (omap_vout_dss_omap24xx()) { |
247 | if ((try_crop.height/win->w.height) >= 2) | 247 | if ((try_crop.height/win->w.height) >= 2) |
248 | try_crop.height = win->w.height * 2; | 248 | try_crop.height = win->w.height * 2; |
249 | 249 | ||
@@ -258,7 +258,7 @@ int omap_vout_new_crop(struct v4l2_pix_format *pix, | |||
258 | if (try_crop.height != win->w.height) | 258 | if (try_crop.height != win->w.height) |
259 | try_crop.width = 768; | 259 | try_crop.width = 768; |
260 | } | 260 | } |
261 | } else if (cpu_is_omap34xx()) { | 261 | } else if (omap_vout_dss_omap34xx()) { |
262 | if ((try_crop.height/win->w.height) >= 4) | 262 | if ((try_crop.height/win->w.height) >= 4) |
263 | try_crop.height = win->w.height * 4; | 263 | try_crop.height = win->w.height * 4; |
264 | 264 | ||
@@ -337,3 +337,21 @@ void omap_vout_free_buffer(unsigned long virtaddr, u32 buf_size) | |||
337 | } | 337 | } |
338 | free_pages((unsigned long) virtaddr, order); | 338 | free_pages((unsigned long) virtaddr, order); |
339 | } | 339 | } |
340 | |||
341 | bool omap_vout_dss_omap24xx(void) | ||
342 | { | ||
343 | return omapdss_get_version() == OMAPDSS_VER_OMAP24xx; | ||
344 | } | ||
345 | |||
346 | bool omap_vout_dss_omap34xx(void) | ||
347 | { | ||
348 | switch (omapdss_get_version()) { | ||
349 | case OMAPDSS_VER_OMAP34xx_ES1: | ||
350 | case OMAPDSS_VER_OMAP34xx_ES3: | ||
351 | case OMAPDSS_VER_OMAP3630: | ||
352 | case OMAPDSS_VER_AM35xx: | ||
353 | return true; | ||
354 | default: | ||
355 | return false; | ||
356 | } | ||
357 | } | ||
diff --git a/drivers/media/platform/omap/omap_voutlib.h b/drivers/media/platform/omap/omap_voutlib.h index e51750a597e3..f9d1c0779f33 100644 --- a/drivers/media/platform/omap/omap_voutlib.h +++ b/drivers/media/platform/omap/omap_voutlib.h | |||
@@ -32,5 +32,8 @@ void omap_vout_new_format(struct v4l2_pix_format *pix, | |||
32 | struct v4l2_window *win); | 32 | struct v4l2_window *win); |
33 | unsigned long omap_vout_alloc_buffer(u32 buf_size, u32 *phys_addr); | 33 | unsigned long omap_vout_alloc_buffer(u32 buf_size, u32 *phys_addr); |
34 | void omap_vout_free_buffer(unsigned long virtaddr, u32 buf_size); | 34 | void omap_vout_free_buffer(unsigned long virtaddr, u32 buf_size); |
35 | |||
36 | bool omap_vout_dss_omap24xx(void); | ||
37 | bool omap_vout_dss_omap34xx(void); | ||
35 | #endif /* #ifndef OMAP_VOUTLIB_H */ | 38 | #endif /* #ifndef OMAP_VOUTLIB_H */ |
36 | 39 | ||