diff options
author | Mauro Carvalho Chehab <mchehab@infradead.org> | 2007-11-15 07:35:44 -0500 |
---|---|---|
committer | Mauro Carvalho Chehab <mchehab@infradead.org> | 2008-01-25 16:02:10 -0500 |
commit | 98883cdcb5884bd0f7a89ac36b7170404127b3ea (patch) | |
tree | 16658da847753911337e32c4fee7ae89539b45f9 /drivers/media/video | |
parent | f380e1d2c9a1ff82a89ec68850ce53094359000e (diff) |
V4L/DVB (6594): Add tuner_err macro
Some tuners, like xc3028, need to print error messages. Instead of declaring
local macros, create a tuner global macro for printing tuner errors.
To preserve CodingStyle on all tuner_macros, a few CodingStyle violations were
fixed at the other macros:
- lines with more than 80 columns
- two statements at the same line
The patch also removes the CodingStyle violation of having emacs declarations
inside de source code (CodingStyle chapter 18).
Signed-off-by: Mauro Carvalho Chehab <mchehab@infradead.org>
Diffstat (limited to 'drivers/media/video')
-rw-r--r-- | drivers/media/video/tuner-driver.h | 40 | ||||
-rw-r--r-- | drivers/media/video/tuner-i2c.h | 42 |
2 files changed, 45 insertions, 37 deletions
diff --git a/drivers/media/video/tuner-driver.h b/drivers/media/video/tuner-driver.h index d6e5afdaa824..a4db32d97a12 100644 --- a/drivers/media/video/tuner-driver.h +++ b/drivers/media/video/tuner-driver.h | |||
@@ -71,24 +71,26 @@ struct tuner { | |||
71 | 71 | ||
72 | /* ------------------------------------------------------------------------ */ | 72 | /* ------------------------------------------------------------------------ */ |
73 | 73 | ||
74 | #define tuner_warn(fmt, arg...) do {\ | 74 | #define tuner_warn(fmt, arg...) do { \ |
75 | printk(KERN_WARNING "%s %d-%04x: " fmt, PREFIX, \ | 75 | printk(KERN_WARNING "%s %d-%04x: " fmt, PREFIX, \ |
76 | i2c_adapter_id(t->i2c->adapter), t->i2c->addr , ##arg); } while (0) | 76 | i2c_adapter_id(t->i2c->adapter), t->i2c->addr, ##arg); \ |
77 | #define tuner_info(fmt, arg...) do {\ | 77 | } while (0) |
78 | printk(KERN_INFO "%s %d-%04x: " fmt, PREFIX, \ | 78 | |
79 | i2c_adapter_id(t->i2c->adapter), t->i2c->addr , ##arg); } while (0) | 79 | #define tuner_info(fmt, arg...) do { \ |
80 | #define tuner_dbg(fmt, arg...) do {\ | 80 | printk(KERN_INFO "%s %d-%04x: " fmt, PREFIX, \ |
81 | extern int tuner_debug; \ | 81 | i2c_adapter_id(t->i2c->adapter), t->i2c->addr , ##arg); \ |
82 | if (tuner_debug) \ | 82 | } while (0) |
83 | printk(KERN_DEBUG "%s %d-%04x: " fmt, PREFIX, \ | 83 | |
84 | i2c_adapter_id(t->i2c->adapter), t->i2c->addr , ##arg); } while (0) | 84 | #define tuner_err(fmt, arg...) do { \ |
85 | printk(KERN_ERR "%s %d-%04x: " fmt, PREFIX, \ | ||
86 | i2c_adapter_id(t->i2c->adapter), t->i2c->addr , ##arg); \ | ||
87 | } while (0) | ||
88 | |||
89 | #define tuner_dbg(fmt, arg...) do { \ | ||
90 | extern int tuner_debug; \ | ||
91 | if (tuner_debug) \ | ||
92 | printk(KERN_DEBUG "%s %d-%04x: " fmt, PREFIX, \ | ||
93 | i2c_adapter_id(t->i2c->adapter), t->i2c->addr , ##arg); \ | ||
94 | } while (0) | ||
85 | 95 | ||
86 | #endif /* __TUNER_DRIVER_H__ */ | 96 | #endif /* __TUNER_DRIVER_H__ */ |
87 | |||
88 | /* | ||
89 | * Overrides for Emacs so that we follow Linus's tabbing style. | ||
90 | * --------------------------------------------------------------------------- | ||
91 | * Local variables: | ||
92 | * c-basic-offset: 8 | ||
93 | * End: | ||
94 | */ | ||
diff --git a/drivers/media/video/tuner-i2c.h b/drivers/media/video/tuner-i2c.h index cfba3d10906c..b5ac189ba40f 100644 --- a/drivers/media/video/tuner-i2c.h +++ b/drivers/media/video/tuner-i2c.h | |||
@@ -47,24 +47,30 @@ static inline int tuner_i2c_xfer_recv(struct tuner_i2c_props *props, char *buf, | |||
47 | } | 47 | } |
48 | 48 | ||
49 | #ifndef __TUNER_DRIVER_H__ | 49 | #ifndef __TUNER_DRIVER_H__ |
50 | #define tuner_warn(fmt, arg...) do {\ | 50 | #define tuner_warn(fmt, arg...) do { \ |
51 | printk(KERN_WARNING "%s %d-%04x: " fmt, PREFIX, \ | 51 | printk(KERN_WARNING "%s %d-%04x: " fmt, PREFIX, \ |
52 | i2c_adapter_id(priv->i2c_props.adap), priv->i2c_props.addr , ##arg); } while (0) | 52 | i2c_adapter_id(priv->i2c_props.adap), \ |
53 | #define tuner_info(fmt, arg...) do {\ | 53 | priv->i2c_props.addr, ##arg); \ |
54 | printk(KERN_INFO "%s %d-%04x: " fmt, PREFIX, \ | 54 | } while (0) |
55 | i2c_adapter_id(priv->i2c_props.adap), priv->i2c_props.addr , ##arg); } while (0) | 55 | |
56 | #define tuner_dbg(fmt, arg...) do {\ | 56 | #define tuner_info(fmt, arg...) do { \ |
57 | if ((debug)) \ | 57 | printk(KERN_INFO "%s %d-%04x: " fmt, PREFIX, \ |
58 | printk(KERN_DEBUG "%s %d-%04x: " fmt, PREFIX, \ | 58 | i2c_adapter_id(priv->i2c_props.adap), \ |
59 | i2c_adapter_id(priv->i2c_props.adap), priv->i2c_props.addr , ##arg); } while (0) | 59 | priv->i2c_props.addr , ##arg); \ |
60 | } while (0) | ||
61 | |||
62 | #define tuner_err(fmt, arg...) do { \ | ||
63 | printk(KERN_ERR "%s %d-%04x: " fmt, PREFIX, \ | ||
64 | i2c_adapter_id(priv->i2c_props.adap), \ | ||
65 | priv->i2c_props.addr , ##arg); \ | ||
66 | } while (0) | ||
67 | |||
68 | #define tuner_dbg(fmt, arg...) do { \ | ||
69 | if ((debug)) \ | ||
70 | printk(KERN_DEBUG "%s %d-%04x: " fmt, PREFIX, \ | ||
71 | i2c_adapter_id(priv->i2c_props.adap), \ | ||
72 | priv->i2c_props.addr , ##arg); \ | ||
73 | } while (0) | ||
60 | #endif /* __TUNER_DRIVER_H__ */ | 74 | #endif /* __TUNER_DRIVER_H__ */ |
61 | 75 | ||
62 | #endif /* __TUNER_I2C_H__ */ | 76 | #endif /* __TUNER_I2C_H__ */ |
63 | |||
64 | /* | ||
65 | * Overrides for Emacs so that we follow Linus's tabbing style. | ||
66 | * --------------------------------------------------------------------------- | ||
67 | * Local variables: | ||
68 | * c-basic-offset: 8 | ||
69 | * End: | ||
70 | */ | ||