diff options
author | Márton Németh <nm127@freemail.hu> | 2009-03-27 10:13:57 -0400 |
---|---|---|
committer | Mauro Carvalho Chehab <mchehab@redhat.com> | 2009-03-30 11:43:48 -0400 |
commit | 8bbd90ce80d39d372857235f00c7abb208bd9e4f (patch) | |
tree | c23deff65dae6323f7e8f58da4dd7156bd0279fd /drivers/media/video/uvc | |
parent | 0ce566da77767bc7dd6e4016a6544c9e814d2ed3 (diff) |
V4L/DVB (11293): uvcvideo: Add zero fill for VIDIOC_ENUM_FMT
When enumerating formats with VIDIOC_ENUM_FMT the uvcvideo driver does not
fill the reserved fields of the struct v4l2_fmtdesc with zeros as required by
V4L2 API revision 0.24 [1]. Add the missing initializations.
The patch was tested with v4l-test 0.10 [2] with CNF7129 webcam found on EeePC
901.
References:
[1] V4L2 API specification, revision 0.24
http://v4l2spec.bytesex.org/spec/r8367.htm
[2] v4l-test: Test environment for Video For Linux Two API
http://v4l-test.sourceforge.net/
Signed-off-by: Márton Németh <nm127@freemail.hu>
Signed-off-by: Laurent Pinchart <laurent.pinchart@skynet.be>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
Diffstat (limited to 'drivers/media/video/uvc')
-rw-r--r-- | drivers/media/video/uvc/uvc_v4l2.c | 6 |
1 files changed, 6 insertions, 0 deletions
diff --git a/drivers/media/video/uvc/uvc_v4l2.c b/drivers/media/video/uvc/uvc_v4l2.c index 30781b82b6b5..2a80caa54fb4 100644 --- a/drivers/media/video/uvc/uvc_v4l2.c +++ b/drivers/media/video/uvc/uvc_v4l2.c | |||
@@ -673,11 +673,17 @@ static long uvc_v4l2_do_ioctl(struct file *file, unsigned int cmd, void *arg) | |||
673 | { | 673 | { |
674 | struct v4l2_fmtdesc *fmt = arg; | 674 | struct v4l2_fmtdesc *fmt = arg; |
675 | struct uvc_format *format; | 675 | struct uvc_format *format; |
676 | enum v4l2_buf_type type = fmt->type; | ||
677 | __u32 index = fmt->index; | ||
676 | 678 | ||
677 | if (fmt->type != video->streaming->type || | 679 | if (fmt->type != video->streaming->type || |
678 | fmt->index >= video->streaming->nformats) | 680 | fmt->index >= video->streaming->nformats) |
679 | return -EINVAL; | 681 | return -EINVAL; |
680 | 682 | ||
683 | memset(fmt, 0, sizeof(*fmt)); | ||
684 | fmt->index = index; | ||
685 | fmt->type = type; | ||
686 | |||
681 | format = &video->streaming->format[fmt->index]; | 687 | format = &video->streaming->format[fmt->index]; |
682 | fmt->flags = 0; | 688 | fmt->flags = 0; |
683 | if (format->flags & UVC_FMT_FLAG_COMPRESSED) | 689 | if (format->flags & UVC_FMT_FLAG_COMPRESSED) |