diff options
author | Trent Piepho <xyzzy@speakeasy.org> | 2009-03-03 23:21:03 -0500 |
---|---|---|
committer | Mauro Carvalho Chehab <mchehab@redhat.com> | 2009-03-30 11:43:06 -0400 |
commit | 38367255185408748c2d46641e06c83570af161c (patch) | |
tree | 4c76afbd0d216baad346d5da76f10e946a98a8d4 /drivers/media/video/usbvision | |
parent | df7bdfcd0efa9a25a7c9751a25b4d4efd9141b8d (diff) |
V4L/DVB (10818): usbvision: Don't need to zero ioctl parameter fields
The v4l2 core code in v4l2_ioctl will zero out the structure the driver is
supposed to fill in for read-only ioctls. For read/write ioctls, all the
fields which aren't supplied from userspace will be zeroed out.
Zeroing code is removed from g_audio, queryctrl, and enum_fmt_vid_cap.
Signed-off-by: Trent Piepho <xyzzy@speakeasy.org>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
Diffstat (limited to 'drivers/media/video/usbvision')
-rw-r--r-- | drivers/media/video/usbvision/usbvision-video.c | 7 |
1 files changed, 0 insertions, 7 deletions
diff --git a/drivers/media/video/usbvision/usbvision-video.c b/drivers/media/video/usbvision/usbvision-video.c index 863fcb31622f..3d400e4b7a27 100644 --- a/drivers/media/video/usbvision/usbvision-video.c +++ b/drivers/media/video/usbvision/usbvision-video.c | |||
@@ -697,7 +697,6 @@ static int vidioc_g_audio (struct file *file, void *priv, struct v4l2_audio *a) | |||
697 | { | 697 | { |
698 | struct usb_usbvision *usbvision = video_drvdata(file); | 698 | struct usb_usbvision *usbvision = video_drvdata(file); |
699 | 699 | ||
700 | memset(a,0,sizeof(*a)); | ||
701 | if(usbvision->radio) { | 700 | if(usbvision->radio) { |
702 | strcpy(a->name,"Radio"); | 701 | strcpy(a->name,"Radio"); |
703 | } else { | 702 | } else { |
@@ -721,10 +720,6 @@ static int vidioc_queryctrl (struct file *file, void *priv, | |||
721 | struct v4l2_queryctrl *ctrl) | 720 | struct v4l2_queryctrl *ctrl) |
722 | { | 721 | { |
723 | struct usb_usbvision *usbvision = video_drvdata(file); | 722 | struct usb_usbvision *usbvision = video_drvdata(file); |
724 | int id=ctrl->id; | ||
725 | |||
726 | memset(ctrl,0,sizeof(*ctrl)); | ||
727 | ctrl->id=id; | ||
728 | 723 | ||
729 | call_all(usbvision, core, queryctrl, ctrl); | 724 | call_all(usbvision, core, queryctrl, ctrl); |
730 | 725 | ||
@@ -926,11 +921,9 @@ static int vidioc_enum_fmt_vid_cap (struct file *file, void *priv, | |||
926 | if(vfd->index>=USBVISION_SUPPORTED_PALETTES-1) { | 921 | if(vfd->index>=USBVISION_SUPPORTED_PALETTES-1) { |
927 | return -EINVAL; | 922 | return -EINVAL; |
928 | } | 923 | } |
929 | vfd->flags = 0; | ||
930 | vfd->type = V4L2_BUF_TYPE_VIDEO_CAPTURE; | 924 | vfd->type = V4L2_BUF_TYPE_VIDEO_CAPTURE; |
931 | strcpy(vfd->description,usbvision_v4l2_format[vfd->index].desc); | 925 | strcpy(vfd->description,usbvision_v4l2_format[vfd->index].desc); |
932 | vfd->pixelformat = usbvision_v4l2_format[vfd->index].format; | 926 | vfd->pixelformat = usbvision_v4l2_format[vfd->index].format; |
933 | memset(vfd->reserved, 0, sizeof(vfd->reserved)); | ||
934 | return 0; | 927 | return 0; |
935 | } | 928 | } |
936 | 929 | ||