diff options
author | Greg Kroah-Hartman <gregkh@suse.de> | 2008-08-14 12:37:34 -0400 |
---|---|---|
committer | Greg Kroah-Hartman <gregkh@suse.de> | 2008-10-17 17:41:08 -0400 |
commit | aa82661baf8a48379355ffa8bf162b07cf487600 (patch) | |
tree | 22b555a5227c2d6f3a145d5a5350b2b473602262 /drivers/media/video/usbvideo | |
parent | 1817b1692a2eab022e805d32e910f4556c89dce8 (diff) |
USB: remove warn() macro from usb media drivers
USB should not be having it's own printk macros, so remove warn() and
use the system-wide standard of dev_warn() wherever possible. In the
few places that will not work out, use a basic printk().
Cc: Mauro Carvalho Chehab <mchehab@infradead.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Diffstat (limited to 'drivers/media/video/usbvideo')
-rw-r--r-- | drivers/media/video/usbvideo/konicawc.c | 8 | ||||
-rw-r--r-- | drivers/media/video/usbvideo/quickcam_messenger.c | 14 |
2 files changed, 13 insertions, 9 deletions
diff --git a/drivers/media/video/usbvideo/konicawc.c b/drivers/media/video/usbvideo/konicawc.c index e986c28b7bb0..da27a5287983 100644 --- a/drivers/media/video/usbvideo/konicawc.c +++ b/drivers/media/video/usbvideo/konicawc.c | |||
@@ -229,7 +229,8 @@ static void konicawc_register_input(struct konicawc *cam, struct usb_device *dev | |||
229 | 229 | ||
230 | cam->input = input_dev = input_allocate_device(); | 230 | cam->input = input_dev = input_allocate_device(); |
231 | if (!input_dev) { | 231 | if (!input_dev) { |
232 | warn("Not enough memory for camera's input device\n"); | 232 | dev_warn(&dev->dev, |
233 | "Not enough memory for camera's input device\n"); | ||
233 | return; | 234 | return; |
234 | } | 235 | } |
235 | 236 | ||
@@ -243,8 +244,9 @@ static void konicawc_register_input(struct konicawc *cam, struct usb_device *dev | |||
243 | 244 | ||
244 | error = input_register_device(cam->input); | 245 | error = input_register_device(cam->input); |
245 | if (error) { | 246 | if (error) { |
246 | warn("Failed to register camera's input device, err: %d\n", | 247 | dev_warn(&dev->dev, |
247 | error); | 248 | "Failed to register camera's input device, err: %d\n", |
249 | error); | ||
248 | input_free_device(cam->input); | 250 | input_free_device(cam->input); |
249 | cam->input = NULL; | 251 | cam->input = NULL; |
250 | } | 252 | } |
diff --git a/drivers/media/video/usbvideo/quickcam_messenger.c b/drivers/media/video/usbvideo/quickcam_messenger.c index 05c61b523115..4459b8a7f818 100644 --- a/drivers/media/video/usbvideo/quickcam_messenger.c +++ b/drivers/media/video/usbvideo/quickcam_messenger.c | |||
@@ -93,7 +93,7 @@ static void qcm_register_input(struct qcm *cam, struct usb_device *dev) | |||
93 | 93 | ||
94 | cam->input = input_dev = input_allocate_device(); | 94 | cam->input = input_dev = input_allocate_device(); |
95 | if (!input_dev) { | 95 | if (!input_dev) { |
96 | warn("insufficient mem for cam input device"); | 96 | dev_warn(&dev->dev, "insufficient mem for cam input device\n"); |
97 | return; | 97 | return; |
98 | } | 98 | } |
99 | 99 | ||
@@ -107,8 +107,9 @@ static void qcm_register_input(struct qcm *cam, struct usb_device *dev) | |||
107 | 107 | ||
108 | error = input_register_device(cam->input); | 108 | error = input_register_device(cam->input); |
109 | if (error) { | 109 | if (error) { |
110 | warn("Failed to register camera's input device, err: %d\n", | 110 | dev_warn(&dev->dev, |
111 | error); | 111 | "Failed to register camera's input device, err: %d\n", |
112 | error); | ||
112 | input_free_device(cam->input); | 113 | input_free_device(cam->input); |
113 | cam->input = NULL; | 114 | cam->input = NULL; |
114 | } | 115 | } |
@@ -587,8 +588,9 @@ static int qcm_compress_iso(struct uvd *uvd, struct urb *dataurb) | |||
587 | dataurb->iso_frame_desc[i].offset; | 588 | dataurb->iso_frame_desc[i].offset; |
588 | 589 | ||
589 | if (st < 0) { | 590 | if (st < 0) { |
590 | warn("Data error: packet=%d. len=%d. status=%d.", | 591 | dev_warn(&uvd->dev->dev, |
591 | i, n, st); | 592 | "Data error: packet=%d. len=%d. status=%d.\n", |
593 | i, n, st); | ||
592 | uvd->stats.iso_err_count++; | 594 | uvd->stats.iso_err_count++; |
593 | continue; | 595 | continue; |
594 | } | 596 | } |
@@ -699,7 +701,7 @@ static void qcm_stop_data(struct uvd *uvd) | |||
699 | 701 | ||
700 | ret = qcm_camera_off(uvd); | 702 | ret = qcm_camera_off(uvd); |
701 | if (ret) | 703 | if (ret) |
702 | warn("couldn't turn the cam off."); | 704 | dev_warn(&uvd->dev->dev, "couldn't turn the cam off.\n"); |
703 | 705 | ||
704 | uvd->streaming = 0; | 706 | uvd->streaming = 0; |
705 | 707 | ||