aboutsummaryrefslogtreecommitdiffstats
path: root/drivers/media/video/saa7164/saa7164-core.c
diff options
context:
space:
mode:
authorSteven Toth <stoth@kernellabs.com>2009-05-10 13:08:27 -0400
committerMauro Carvalho Chehab <mchehab@redhat.com>2009-09-18 23:14:51 -0400
commit1a6450d4d43a4d4caecaa3ca7796cbe8c7cfbba3 (patch)
tree93c3bdb287eb32c5bff29cdcd6e3d6c12556c761 /drivers/media/video/saa7164/saa7164-core.c
parent9d119c3314cd7ad251e1e2c97b4e081d870a31f7 (diff)
V4L/DVB (12927): SAA7164: Remove volatiles for PCI writes (coding style violation)
Signed-off-by: Steven Toth <stoth@kernellabs.com> Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
Diffstat (limited to 'drivers/media/video/saa7164/saa7164-core.c')
-rw-r--r--drivers/media/video/saa7164/saa7164-core.c12
1 files changed, 6 insertions, 6 deletions
diff --git a/drivers/media/video/saa7164/saa7164-core.c b/drivers/media/video/saa7164/saa7164-core.c
index bf4ca4f29b01..968ecd4ad495 100644
--- a/drivers/media/video/saa7164/saa7164-core.c
+++ b/drivers/media/video/saa7164/saa7164-core.c
@@ -126,12 +126,13 @@ static irqreturn_t saa7164_irq(int irq, void *dev_id)
126 /* Check that the hardware is accessable. If the status bytes are 126 /* Check that the hardware is accessable. If the status bytes are
127 * 0xFF then the device is not accessable, the the IRQ belongs 127 * 0xFF then the device is not accessable, the the IRQ belongs
128 * to another driver. 128 * to another driver.
129 * 4 x u32 interrupt registers.
129 */ 130 */
130 for (i = 0; i < INT_SIZE/4; i++) { 131 for (i = 0; i < INT_SIZE/4; i++) {
131 132
132 /* TODO: Convert into saa7164_readl() */ 133 /* TODO: Convert into saa7164_readl() */
133 /* Read the 4 hardware interrupt registers */ 134 /* Read the 4 hardware interrupt registers */
134 intstat[i] = *(dev->InterruptStatus + i); 135 intstat[i] = saa7164_readl(dev->int_status + (i * 4));
135 136
136 if (intstat[i] != 0xffffffff) 137 if (intstat[i] != 0xffffffff)
137 hwacc = 1; 138 hwacc = 1;
@@ -184,9 +185,8 @@ static irqreturn_t saa7164_irq(int irq, void *dev_id)
184 } 185 }
185 } 186 }
186 187
187 /* TODO: Convert into saa7164_writel() */
188 /* Ack it */ 188 /* Ack it */
189 *(dev->InterruptAck + i) = intstat[i]; 189 saa7164_writel(dev->int_ack + (i * 4), intstat[i]);
190 190
191 } 191 }
192 } 192 }
@@ -487,9 +487,9 @@ static int saa7164_dev_setup(struct saa7164_dev *dev)
487 printk(KERN_INFO "CORE %s: dev->bmmio2 = 0x%p\n", dev->name, 487 printk(KERN_INFO "CORE %s: dev->bmmio2 = 0x%p\n", dev->name,
488 dev->bmmio2); 488 dev->bmmio2);
489 489
490 /* TODO: Magic defines used in the windows driver, define these */ 490 /* Inerrupt and ack register locations offset of bmmio */
491 dev->InterruptStatus = (u32 *)(dev->bmmio + 0x183000 + 0xf80); 491 dev->int_status = 0x183000 + 0xf80;
492 dev->InterruptAck = (u32 *)(dev->bmmio + 0x183000 + 0xf90); 492 dev->int_ack = 0x183000 + 0xf90;
493 493
494 printk(KERN_INFO 494 printk(KERN_INFO
495 "CORE %s: subsystem: %04x:%04x, board: %s [card=%d,%s]\n", 495 "CORE %s: subsystem: %04x:%04x, board: %s [card=%d,%s]\n",