diff options
author | Jean-Francois Moine <moinejf@free.fr> | 2009-12-12 04:58:01 -0500 |
---|---|---|
committer | Mauro Carvalho Chehab <mchehab@redhat.com> | 2009-12-15 21:18:49 -0500 |
commit | 83955556669f69fccfd332b52e9b1796d60c77bd (patch) | |
tree | 29b94e2cb24c5de83523838a7dfaa0fe88cf53b8 /drivers/media/video/gspca/gl860 | |
parent | 37b372e5ebe187037e01885151a0afb546a38520 (diff) |
V4L/DVB (13626): gspca - many subdrivers: Fix some warnings.
- gl860.c:332:15: warning: cast to restricted __le16
- gl860.c:333:15: warning: cast to restricted __le16
- gl860-mi1320.c:348:5: warning: symbol 'mi1320_camera_settings' was not declared. Should it be static?
- gl860-mi2020.c:772:5: warning: symbol 'mi2020_camera_settings' was not declared. Should it be static?
- m5602_ov9650.c:444:7: warning: symbol 'data' shadows an earlier one
- m5602_core.c:84:5: warning: symbol 'm5602_wait_for_i2c' was not declared. Should it be static?
- m5602_core.c:391:6: warning: symbol 'm5602_disconnect' was not declared. Should it be static?
- m5602_s5k4aa.c:530:23: warning: dubious: x | !y
- m5602_s5k4aa.c:575:23: warning: dubious: x | !y
- gspca.c:1196:13: warning: potentially expensive pointer subtraction
- mr97310a.c:70:5: warning: symbol 'force_sensor_type' was not declared. Should it be static?
- ov519.c:2025:4: warning: do-while statement is not a compound statement
- ov519.c:2063:4: warning: do-while statement is not a compound statement
- ov519.c:2089:4: warning: do-while statement is not a compound statement
- ov519.c:1985:34: warning: incorrect type in assignment (different base types)
- sn9c20x.c:1164:5: warning: symbol 'i2c_r1' was not declared. Should it be static?
- sn9c20x.c:1189:5: warning: symbol 'i2c_r2' was not declared. Should it be static?
- sn9c20x.c:2237:27: warning: right shift by bigger than source value
- sn9c20x.c:2237:27: warning: right shift by bigger than source value
Signed-off-by: Jean-Francois Moine <moinejf@free.fr>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
Diffstat (limited to 'drivers/media/video/gspca/gl860')
-rw-r--r-- | drivers/media/video/gspca/gl860/gl860-mi1320.c | 2 | ||||
-rw-r--r-- | drivers/media/video/gspca/gl860/gl860-mi2020.c | 2 | ||||
-rw-r--r-- | drivers/media/video/gspca/gl860/gl860.c | 10 |
3 files changed, 7 insertions, 7 deletions
diff --git a/drivers/media/video/gspca/gl860/gl860-mi1320.c b/drivers/media/video/gspca/gl860/gl860-mi1320.c index 1355e526ee84..c276a7debdec 100644 --- a/drivers/media/video/gspca/gl860/gl860-mi1320.c +++ b/drivers/media/video/gspca/gl860/gl860-mi1320.c | |||
@@ -345,7 +345,7 @@ static int mi1320_configure_alt(struct gspca_dev *gspca_dev) | |||
345 | return 0; | 345 | return 0; |
346 | } | 346 | } |
347 | 347 | ||
348 | int mi1320_camera_settings(struct gspca_dev *gspca_dev) | 348 | static int mi1320_camera_settings(struct gspca_dev *gspca_dev) |
349 | { | 349 | { |
350 | struct sd *sd = (struct sd *) gspca_dev; | 350 | struct sd *sd = (struct sd *) gspca_dev; |
351 | 351 | ||
diff --git a/drivers/media/video/gspca/gl860/gl860-mi2020.c b/drivers/media/video/gspca/gl860/gl860-mi2020.c index 80cb3f1b36f7..7c31b4f2abea 100644 --- a/drivers/media/video/gspca/gl860/gl860-mi2020.c +++ b/drivers/media/video/gspca/gl860/gl860-mi2020.c | |||
@@ -769,7 +769,7 @@ static int mi2020_configure_alt(struct gspca_dev *gspca_dev) | |||
769 | return 0; | 769 | return 0; |
770 | } | 770 | } |
771 | 771 | ||
772 | int mi2020_camera_settings(struct gspca_dev *gspca_dev) | 772 | static int mi2020_camera_settings(struct gspca_dev *gspca_dev) |
773 | { | 773 | { |
774 | struct sd *sd = (struct sd *) gspca_dev; | 774 | struct sd *sd = (struct sd *) gspca_dev; |
775 | 775 | ||
diff --git a/drivers/media/video/gspca/gl860/gl860.c b/drivers/media/video/gspca/gl860/gl860.c index bd3c21a37be6..4878c8f66543 100644 --- a/drivers/media/video/gspca/gl860/gl860.c +++ b/drivers/media/video/gspca/gl860/gl860.c | |||
@@ -40,7 +40,7 @@ static void sd_pkt_scan(struct gspca_dev *gspca_dev, | |||
40 | static void sd_callback(struct gspca_dev *gspca_dev); | 40 | static void sd_callback(struct gspca_dev *gspca_dev); |
41 | 41 | ||
42 | static int gl860_guess_sensor(struct gspca_dev *gspca_dev, | 42 | static int gl860_guess_sensor(struct gspca_dev *gspca_dev, |
43 | s32 vendor_id, s32 product_id); | 43 | u16 vendor_id, u16 product_id); |
44 | 44 | ||
45 | /*============================ driver options ==============================*/ | 45 | /*============================ driver options ==============================*/ |
46 | 46 | ||
@@ -326,11 +326,11 @@ static int sd_config(struct gspca_dev *gspca_dev, | |||
326 | { | 326 | { |
327 | struct sd *sd = (struct sd *) gspca_dev; | 327 | struct sd *sd = (struct sd *) gspca_dev; |
328 | struct cam *cam; | 328 | struct cam *cam; |
329 | s32 vendor_id, product_id; | 329 | u16 vendor_id, product_id; |
330 | 330 | ||
331 | /* Get USB VendorID and ProductID */ | 331 | /* Get USB VendorID and ProductID */ |
332 | vendor_id = le16_to_cpu(id->idVendor); | 332 | vendor_id = id->idVendor; |
333 | product_id = le16_to_cpu(id->idProduct); | 333 | product_id = id->idProduct; |
334 | 334 | ||
335 | sd->nbRightUp = 1; | 335 | sd->nbRightUp = 1; |
336 | sd->nbIm = -1; | 336 | sd->nbIm = -1; |
@@ -673,7 +673,7 @@ void fetch_idxdata(struct gspca_dev *gspca_dev, struct idxdata *tbl, int len) | |||
673 | } | 673 | } |
674 | 674 | ||
675 | static int gl860_guess_sensor(struct gspca_dev *gspca_dev, | 675 | static int gl860_guess_sensor(struct gspca_dev *gspca_dev, |
676 | s32 vendor_id, s32 product_id) | 676 | u16 vendor_id, u16 product_id) |
677 | { | 677 | { |
678 | struct sd *sd = (struct sd *) gspca_dev; | 678 | struct sd *sd = (struct sd *) gspca_dev; |
679 | u8 probe, nb26, nb96, nOV, ntry; | 679 | u8 probe, nb26, nb96, nOV, ntry; |