aboutsummaryrefslogtreecommitdiffstats
path: root/drivers/media/video/cx23885
diff options
context:
space:
mode:
authorMauro Carvalho Chehab <mchehab@redhat.com>2011-10-14 16:00:19 -0400
committerMauro Carvalho Chehab <mchehab@redhat.com>2011-10-14 16:00:19 -0400
commitd5492fb9ed3f3f25c56b25684072f0d234863b08 (patch)
treee880da23a80c996a0b6539accfeaed5d385bc8b1 /drivers/media/video/cx23885
parent97ce5670fcee40b37f75d227ed88dcc51af63140 (diff)
[media] cx23885: Don't use memset on vidioc_ callbacks
vidioc_g_tuner should not do any memset for the parameters. Core already does that. In particular, V4L2 core now does some handling for the tuner type, and the tuner-core module relies on that. So, doing any memset there is a very bad idea. Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
Diffstat (limited to 'drivers/media/video/cx23885')
-rw-r--r--drivers/media/video/cx23885/cx23885-video.c1
1 files changed, 0 insertions, 1 deletions
diff --git a/drivers/media/video/cx23885/cx23885-video.c b/drivers/media/video/cx23885/cx23885-video.c
index acd6e0c2970e..34854b0a94a5 100644
--- a/drivers/media/video/cx23885/cx23885-video.c
+++ b/drivers/media/video/cx23885/cx23885-video.c
@@ -1223,7 +1223,6 @@ static int vidioc_g_tuner(struct file *file, void *priv,
1223 if (0 != t->index) 1223 if (0 != t->index)
1224 return -EINVAL; 1224 return -EINVAL;
1225 1225
1226 memset(t, 0, sizeof(*t));
1227 strcpy(t->name, "Television"); 1226 strcpy(t->name, "Television");
1228 1227
1229 return 0; 1228 return 0;