aboutsummaryrefslogtreecommitdiffstats
path: root/drivers/media/v4l2-core
diff options
context:
space:
mode:
authorHans Verkuil <hans.verkuil@cisco.com>2014-07-25 05:08:36 -0400
committerMauro Carvalho Chehab <m.chehab@samsung.com>2014-09-02 15:37:50 -0400
commit529a53c6087b3e8648185dfa4491043ec43554d6 (patch)
treeb21699ae1bc18b4fd745e02c489e12cd672358da /drivers/media/v4l2-core
parent41b9aa0040526d13e08e2ad79970377afe1d622d (diff)
[media] vb2: fix multiplanar read() with non-zero data_offset
If this is a multiplanar buf_type and the plane we want to read has a non-zero data_offset, then that data_offset was not taken into account. Note that read() or write() for formats with more than one plane is currently not allowed, hence the use of 'planes[0]' since this is only relevant for a single-plane format. Signed-off-by: Hans Verkuil <hans.verkuil@cisco.com> Signed-off-by: Mauro Carvalho Chehab <m.chehab@samsung.com>
Diffstat (limited to 'drivers/media/v4l2-core')
-rw-r--r--drivers/media/v4l2-core/videobuf2-core.c6
1 files changed, 6 insertions, 0 deletions
diff --git a/drivers/media/v4l2-core/videobuf2-core.c b/drivers/media/v4l2-core/videobuf2-core.c
index 5b808e25fc09..7e6aff673a5a 100644
--- a/drivers/media/v4l2-core/videobuf2-core.c
+++ b/drivers/media/v4l2-core/videobuf2-core.c
@@ -2955,6 +2955,12 @@ static size_t __vb2_perform_fileio(struct vb2_queue *q, char __user *data, size_
2955 buf->queued = 0; 2955 buf->queued = 0;
2956 buf->size = read ? vb2_get_plane_payload(q->bufs[index], 0) 2956 buf->size = read ? vb2_get_plane_payload(q->bufs[index], 0)
2957 : vb2_plane_size(q->bufs[index], 0); 2957 : vb2_plane_size(q->bufs[index], 0);
2958 /* Compensate for data_offset on read in the multiplanar case. */
2959 if (is_multiplanar && read &&
2960 fileio->b.m.planes[0].data_offset < buf->size) {
2961 buf->pos = fileio->b.m.planes[0].data_offset;
2962 buf->size -= buf->pos;
2963 }
2958 } else { 2964 } else {
2959 buf = &fileio->bufs[index]; 2965 buf = &fileio->bufs[index];
2960 } 2966 }