aboutsummaryrefslogtreecommitdiffstats
path: root/drivers/media/platform
diff options
context:
space:
mode:
authorWei Yongjun <yongjun_wei@trendmicro.com.cn>2012-11-15 07:18:17 -0500
committerMauro Carvalho Chehab <mchehab@redhat.com>2012-11-22 09:23:26 -0500
commit94b76a88f16c869109c41380c77f4a2b847650e3 (patch)
tree64d10fc4d75c204176f6a450b703443251480888 /drivers/media/platform
parent63af4af59238fc17e70d0b0046362c804d4fc567 (diff)
[media] davinci: vpif: fix return value check for vb2_dma_contig_init_ctx()
In case of error, the function vb2_dma_contig_init_ctx() returns ERR_PTR() and never returns NULL. The NULL test in the return value check should be replaced with IS_ERR(). dpatch engine is used to auto generate this patch. (https://github.com/weiyj/dpatch) Signed-off-by: Wei Yongjun <yongjun_wei@trendmicro.com.cn> Acked-by: Lad, Prabhakar <prabhakar.lad@ti.com> [prabhakar.lad@ti.com: reword commit header] Signed-off-by: Lad, Prabhakar <prabhakar.lad@ti.com> Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
Diffstat (limited to 'drivers/media/platform')
-rw-r--r--drivers/media/platform/davinci/vpif_capture.c4
-rw-r--r--drivers/media/platform/davinci/vpif_display.c4
2 files changed, 4 insertions, 4 deletions
diff --git a/drivers/media/platform/davinci/vpif_capture.c b/drivers/media/platform/davinci/vpif_capture.c
index 2d28a96e7775..41890a938830 100644
--- a/drivers/media/platform/davinci/vpif_capture.c
+++ b/drivers/media/platform/davinci/vpif_capture.c
@@ -1004,9 +1004,9 @@ static int vpif_reqbufs(struct file *file, void *priv,
1004 1004
1005 /* Initialize videobuf2 queue as per the buffer type */ 1005 /* Initialize videobuf2 queue as per the buffer type */
1006 common->alloc_ctx = vb2_dma_contig_init_ctx(vpif_dev); 1006 common->alloc_ctx = vb2_dma_contig_init_ctx(vpif_dev);
1007 if (!common->alloc_ctx) { 1007 if (IS_ERR(common->alloc_ctx)) {
1008 vpif_err("Failed to get the context\n"); 1008 vpif_err("Failed to get the context\n");
1009 return -EINVAL; 1009 return PTR_ERR(common->alloc_ctx);
1010 } 1010 }
1011 q = &common->buffer_queue; 1011 q = &common->buffer_queue;
1012 q->type = V4L2_BUF_TYPE_VIDEO_CAPTURE; 1012 q->type = V4L2_BUF_TYPE_VIDEO_CAPTURE;
diff --git a/drivers/media/platform/davinci/vpif_display.c b/drivers/media/platform/davinci/vpif_display.c
index 977ee436c334..e5109ae0593d 100644
--- a/drivers/media/platform/davinci/vpif_display.c
+++ b/drivers/media/platform/davinci/vpif_display.c
@@ -972,9 +972,9 @@ static int vpif_reqbufs(struct file *file, void *priv,
972 } 972 }
973 /* Initialize videobuf2 queue as per the buffer type */ 973 /* Initialize videobuf2 queue as per the buffer type */
974 common->alloc_ctx = vb2_dma_contig_init_ctx(vpif_dev); 974 common->alloc_ctx = vb2_dma_contig_init_ctx(vpif_dev);
975 if (!common->alloc_ctx) { 975 if (IS_ERR(common->alloc_ctx)) {
976 vpif_err("Failed to get the context\n"); 976 vpif_err("Failed to get the context\n");
977 return -EINVAL; 977 return PTR_ERR(common->alloc_ctx);
978 } 978 }
979 q = &common->buffer_queue; 979 q = &common->buffer_queue;
980 q->type = V4L2_BUF_TYPE_VIDEO_OUTPUT; 980 q->type = V4L2_BUF_TYPE_VIDEO_OUTPUT;