diff options
author | Laurent Pinchart <laurent.pinchart@ideasonboard.com> | 2014-05-21 16:39:16 -0400 |
---|---|---|
committer | Mauro Carvalho Chehab <m.chehab@samsung.com> | 2014-06-17 11:04:05 -0400 |
commit | e51daefc228aa164adcc17fe8fce0f856ad0a1cc (patch) | |
tree | 248a974bd3a5b3f5ccdd11963975565e802c53de /drivers/media/platform/vsp1 | |
parent | 50e59058a42056063add41c2d900d1b162e2d6d6 (diff) |
[media] v4l: vsp1: Remove the unneeded vsp1_video_buffer video field
The field is assigned but never read, remove it.
This fixes a bug caused by the struct vb2_buffer field not being be the
very first field of the vsp1_video_buffer buffer structure as required
by videobuf2.
Cc: stable@vger.kernel.org
Reported-by: Takanari Hayama <taki@igel.co.jp>
Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Signed-off-by: Mauro Carvalho Chehab <m.chehab@samsung.com>
Diffstat (limited to 'drivers/media/platform/vsp1')
-rw-r--r-- | drivers/media/platform/vsp1/vsp1_video.c | 2 | ||||
-rw-r--r-- | drivers/media/platform/vsp1/vsp1_video.h | 1 |
2 files changed, 0 insertions, 3 deletions
diff --git a/drivers/media/platform/vsp1/vsp1_video.c b/drivers/media/platform/vsp1/vsp1_video.c index 8a1253e51f04..677e3aa04eee 100644 --- a/drivers/media/platform/vsp1/vsp1_video.c +++ b/drivers/media/platform/vsp1/vsp1_video.c | |||
@@ -654,8 +654,6 @@ static int vsp1_video_buffer_prepare(struct vb2_buffer *vb) | |||
654 | if (vb->num_planes < format->num_planes) | 654 | if (vb->num_planes < format->num_planes) |
655 | return -EINVAL; | 655 | return -EINVAL; |
656 | 656 | ||
657 | buf->video = video; | ||
658 | |||
659 | for (i = 0; i < vb->num_planes; ++i) { | 657 | for (i = 0; i < vb->num_planes; ++i) { |
660 | buf->addr[i] = vb2_dma_contig_plane_dma_addr(vb, i); | 658 | buf->addr[i] = vb2_dma_contig_plane_dma_addr(vb, i); |
661 | buf->length[i] = vb2_plane_size(vb, i); | 659 | buf->length[i] = vb2_plane_size(vb, i); |
diff --git a/drivers/media/platform/vsp1/vsp1_video.h b/drivers/media/platform/vsp1/vsp1_video.h index c04d48fa2999..7284320d5433 100644 --- a/drivers/media/platform/vsp1/vsp1_video.h +++ b/drivers/media/platform/vsp1/vsp1_video.h | |||
@@ -90,7 +90,6 @@ static inline struct vsp1_pipeline *to_vsp1_pipeline(struct media_entity *e) | |||
90 | } | 90 | } |
91 | 91 | ||
92 | struct vsp1_video_buffer { | 92 | struct vsp1_video_buffer { |
93 | struct vsp1_video *video; | ||
94 | struct vb2_buffer buf; | 93 | struct vb2_buffer buf; |
95 | struct list_head queue; | 94 | struct list_head queue; |
96 | 95 | ||