[media] s5p-mfc: Fix input/output format reporting

The video encode/decode paths have duplicated logic between VIDIOC_TRY_FMT and VIDIOC_S_FMT that should be de-duped. Also, video decode reports V4L2_PIX_FMT_NV12MT_16X16 output format, regardless of what the actual output has been set at. Fix this. Signed-off-by: John Sheu <sheu@google.com> Signed-off-by: Kamil Debski <k.debski@samsung.com> Signed-off-by: Mauro Carvalho Chehab <m.chehab@samsung.com>
author: John Sheu <sheu@chromium.org> 2013-05-30 15:42:08 -0400
committer: Mauro Carvalho Chehab <m.chehab@samsung.com> 2013-07-25 21:46:36 -0400
commit: b2634562ad90be16441cff1127136457ea619466 (patch)
tree: 8fcfbecedc292dd0caf64108a1bf16cd9f573372 /drivers/media/platform/s5p-mfc
parent: 1b2c14b44adcb7836528640bfdc40bf7499d987d (diff)
2 files changed, 48 insertions, 77 deletions
diff --git a/drivers/media/platform/s5p-mfc/s5p_mfc_dec.c b/drivers/media/platform/s5p-mfc/s5p_mfc_dec.c
index 00b07032f4f0..06091c01176a 100644
--- a/drivers/media/platform/s5p-mfc/s5p_mfc_dec.c
+++ b/drivers/media/platform/s5p-mfc/s5p_mfc_dec.c
@@ -344,7 +344,7 @@ static int vidioc_g_fmt(struct file *file, void *priv, struct v4l2_format *f)
                pix_mp->num_planes = 2;
                /* Set pixelformat to the format in which MFC
                   outputs the decoded frame */
-                pix_mp->pixelformat = V4L2_PIX_FMT_NV12MT;
+                pix_mp->pixelformat = ctx->dst_fmt->fourcc;
                pix_mp->plane_fmt[0].bytesperline = ctx->buf_width;
                pix_mp->plane_fmt[0].sizeimage = ctx->luma_size;
                pix_mp->plane_fmt[1].bytesperline = ctx->buf_width;
@@ -382,10 +382,16 @@ static int vidioc_try_fmt(struct file *file, void *priv, struct v4l2_format *f)
                        mfc_err("Unsupported format for source.\n");
                        return -EINVAL;
                }
-                if (!IS_MFCV6(dev) && (fmt->fourcc == V4L2_PIX_FMT_VP8)) {
+                if (fmt->codec_mode == S5P_FIMV_CODEC_NONE) {
-                        mfc_err("Not supported format.\n");
+                        mfc_err("Unknown codec\n");
                        return -EINVAL;
                }
+                if (!IS_MFCV6(dev)) {
+                        if (fmt->fourcc == V4L2_PIX_FMT_VP8) {
+                                mfc_err("Not supported format.\n");
+                                return -EINVAL;
+                        }
+                }
        } else if (f->type == V4L2_BUF_TYPE_VIDEO_CAPTURE_MPLANE) {
                fmt = find_format(f, MFC_FMT_RAW);
                if (!fmt) {
@@ -411,7 +417,6 @@ static int vidioc_s_fmt(struct file *file, void *priv, struct v4l2_format *f)
        struct s5p_mfc_dev *dev = video_drvdata(file);
        struct s5p_mfc_ctx *ctx = fh_to_ctx(priv);
        int ret = 0;
-        struct s5p_mfc_fmt *fmt;
        struct v4l2_pix_format_mplane *pix_mp;
        mfc_debug_enter();
@@ -425,54 +430,32 @@ static int vidioc_s_fmt(struct file *file, void *priv, struct v4l2_format *f)
                goto out;
        }
        if (f->type == V4L2_BUF_TYPE_VIDEO_CAPTURE_MPLANE) {
-                fmt = find_format(f, MFC_FMT_RAW);
+                /* dst_fmt is validated by call to vidioc_try_fmt */
-                if (!fmt) {
+                ctx->dst_fmt = find_format(f, MFC_FMT_RAW);
-                        mfc_err("Unsupported format for source.\n");
+                ret = 0;
-                        return -EINVAL;
-                }
-                if (!IS_MFCV6(dev) && (fmt->fourcc != V4L2_PIX_FMT_NV12MT)) {
-                        mfc_err("Not supported format.\n");
-                        return -EINVAL;
-                } else if (IS_MFCV6(dev) &&
-                                (fmt->fourcc == V4L2_PIX_FMT_NV12MT)) {
-                        mfc_err("Not supported format.\n");
-                        return -EINVAL;
-                }
-                ctx->dst_fmt = fmt;
-                mfc_debug_leave();
-                return ret;
-        } else if (f->type != V4L2_BUF_TYPE_VIDEO_OUTPUT_MPLANE) {
-                mfc_err("Wrong type error for S_FMT : %d", f->type);
-                return -EINVAL;
-        }
-        fmt = find_format(f, MFC_FMT_DEC);
-        if (!fmt || fmt->codec_mode == S5P_MFC_CODEC_NONE) {
-                mfc_err("Unknown codec\n");
-                ret = -EINVAL;
                goto out;
-        }
+        } else if (f->type == V4L2_BUF_TYPE_VIDEO_OUTPUT_MPLANE) {
-        if (fmt->type != MFC_FMT_DEC) {
+                /* src_fmt is validated by call to vidioc_try_fmt */
-                mfc_err("Wrong format selected, you should choose "
+                ctx->src_fmt = find_format(f, MFC_FMT_DEC);
-                                        "format for decoding\n");
+                ctx->codec_mode = ctx->src_fmt->codec_mode;
+                mfc_debug(2, "The codec number is: %d\n", ctx->codec_mode);
+                pix_mp->height = 0;
+                pix_mp->width = 0;
+                if (pix_mp->plane_fmt[0].sizeimage)
+                        ctx->dec_src_buf_size = pix_mp->plane_fmt[0].sizeimage;
+                else
+                        pix_mp->plane_fmt[0].sizeimage = ctx->dec_src_buf_size =
+                                                                DEF_CPB_SIZE;
+                pix_mp->plane_fmt[0].bytesperline = 0;
+                ctx->state = MFCINST_INIT;
+                ret = 0;
+                goto out;
+        } else {
+                mfc_err("Wrong type error for S_FMT : %d", f->type);
                ret = -EINVAL;
                goto out;
        }
-        if (!IS_MFCV6(dev) && (fmt->fourcc == V4L2_PIX_FMT_VP8)) {
-                mfc_err("Not supported format.\n");
-                return -EINVAL;
-        }
-        ctx->src_fmt = fmt;
-        ctx->codec_mode = fmt->codec_mode;
-        mfc_debug(2, "The codec number is: %d\n", ctx->codec_mode);
-        pix_mp->height = 0;
-        pix_mp->width = 0;
-        if (pix_mp->plane_fmt[0].sizeimage)
-                ctx->dec_src_buf_size = pix_mp->plane_fmt[0].sizeimage;
-        else
-                pix_mp->plane_fmt[0].sizeimage = ctx->dec_src_buf_size =
-                                                                DEF_CPB_SIZE;
-        pix_mp->plane_fmt[0].bytesperline = 0;
-        ctx->state = MFCINST_INIT;
 out:
        mfc_debug_leave();
        return ret;
diff --git a/drivers/media/platform/s5p-mfc/s5p_mfc_enc.c b/drivers/media/platform/s5p-mfc/s5p_mfc_enc.c
index 2549967b2f85..59e56f4c8ce3 100644
--- a/drivers/media/platform/s5p-mfc/s5p_mfc_enc.c
+++ b/drivers/media/platform/s5p-mfc/s5p_mfc_enc.c
@@ -906,6 +906,7 @@ static int vidioc_g_fmt(struct file *file, void *priv, struct v4l2_format *f)
 static int vidioc_try_fmt(struct file *file, void *priv, struct v4l2_format *f)
 {
+        struct s5p_mfc_dev *dev = video_drvdata(file);
        struct s5p_mfc_fmt *fmt;
        struct v4l2_pix_format_mplane *pix_fmt_mp = &f->fmt.pix_mp;
@@ -930,6 +931,18 @@ static int vidioc_try_fmt(struct file *file, void *priv, struct v4l2_format *f)
                        return -EINVAL;
                }
+                if (!IS_MFCV6(dev)) {
+                        if (fmt->fourcc == V4L2_PIX_FMT_NV12MT_16X16) {
+                                mfc_err("Not supported format.\n");
+                                return -EINVAL;
+                        }
+                } else if (IS_MFCV6(dev)) {
+                        if (fmt->fourcc == V4L2_PIX_FMT_NV12MT) {
+                                mfc_err("Not supported format.\n");
+                                return -EINVAL;
+                        }
+                }
                if (fmt->num_planes != pix_fmt_mp->num_planes) {
                        mfc_err("failed to try output format\n");
                        return -EINVAL;
@@ -947,7 +960,6 @@ static int vidioc_s_fmt(struct file *file, void *priv, struct v4l2_format *f)
 {
        struct s5p_mfc_dev *dev = video_drvdata(file);
        struct s5p_mfc_ctx *ctx = fh_to_ctx(priv);
-        struct s5p_mfc_fmt *fmt;
        struct v4l2_pix_format_mplane *pix_fmt_mp = &f->fmt.pix_mp;
        int ret = 0;
@@ -960,13 +972,9 @@ static int vidioc_s_fmt(struct file *file, void *priv, struct v4l2_format *f)
                goto out;
        }
        if (f->type == V4L2_BUF_TYPE_VIDEO_CAPTURE_MPLANE) {
-                fmt = find_format(f, MFC_FMT_ENC);
+                /* dst_fmt is validated by call to vidioc_try_fmt */
-                if (!fmt) {
+                ctx->dst_fmt = find_format(f, MFC_FMT_ENC);
-                        mfc_err("failed to set capture format\n");
-                        return -EINVAL;
-                }
                ctx->state = MFCINST_INIT;
-                ctx->dst_fmt = fmt;
                ctx->codec_mode = ctx->dst_fmt->codec_mode;
                ctx->enc_dst_buf_size = pix_fmt_mp->plane_fmt[0].sizeimage;
                pix_fmt_mp->plane_fmt[0].bytesperline = 0;
@@ -987,28 +995,8 @@ static int vidioc_s_fmt(struct file *file, void *priv, struct v4l2_format *f)
                }
                mfc_debug(2, "Got instance number: %d\n", ctx->inst_no);
        } else if (f->type == V4L2_BUF_TYPE_VIDEO_OUTPUT_MPLANE) {
-                fmt = find_format(f, MFC_FMT_RAW);
+                /* src_fmt is validated by call to vidioc_try_fmt */
-                if (!fmt) {
+                ctx->src_fmt = find_format(f, MFC_FMT_RAW);
-                        mfc_err("failed to set output format\n");
-                        return -EINVAL;
-                }
-                if (!IS_MFCV6(dev) &&
-                                (fmt->fourcc == V4L2_PIX_FMT_NV12MT_16X16)) {
-                        mfc_err("Not supported format.\n");
-                        return -EINVAL;
-                } else if (IS_MFCV6(dev) &&
-                                (fmt->fourcc == V4L2_PIX_FMT_NV12MT)) {
-                        mfc_err("Not supported format.\n");
-                        return -EINVAL;
-                }
-                if (fmt->num_planes != pix_fmt_mp->num_planes) {
-                        mfc_err("failed to set output format\n");
-                        ret = -EINVAL;
-                        goto out;
-                }
-                ctx->src_fmt = fmt;
                ctx->img_width = pix_fmt_mp->width;
                ctx->img_height = pix_fmt_mp->height;
                mfc_debug(2, "codec number: %d\n", ctx->src_fmt->codec_mode);
author	John Sheu <sheu@chromium.org>	2013-05-30 15:42:08 -0400
committer	Mauro Carvalho Chehab <m.chehab@samsung.com>	2013-07-25 21:46:36 -0400
commit	b2634562ad90be16441cff1127136457ea619466 (patch)
tree	8fcfbecedc292dd0caf64108a1bf16cd9f573372 /drivers/media/platform/s5p-mfc
parent	1b2c14b44adcb7836528640bfdc40bf7499d987d (diff)

diff --git a/drivers/media/platform/s5p-mfc/s5p_mfc_dec.c b/drivers/media/platform/s5p-mfc/s5p_mfc_dec.c index 00b07032f4f0..06091c01176a 100644 --- a/drivers/media/platform/s5p-mfc/s5p_mfc_dec.c +++ b/drivers/media/platform/s5p-mfc/s5p_mfc_dec.c
@@ -344,7 +344,7 @@ static int vidioc_g_fmt(struct file file, void priv, struct v4l2_format *f)
344	pix_mp->num_planes = 2;	344	pix_mp->num_planes = 2;
345	/* Set pixelformat to the format in which MFC	345	/* Set pixelformat to the format in which MFC
346	outputs the decoded frame */	346	outputs the decoded frame */
347	pix_mp->pixelformat = V4L2_PIX_FMT_NV12MT;	347	pix_mp->pixelformat = ctx->dst_fmt->fourcc;
348	pix_mp->plane_fmt[0].bytesperline = ctx->buf_width;	348	pix_mp->plane_fmt[0].bytesperline = ctx->buf_width;
349	pix_mp->plane_fmt[0].sizeimage = ctx->luma_size;	349	pix_mp->plane_fmt[0].sizeimage = ctx->luma_size;
350	pix_mp->plane_fmt[1].bytesperline = ctx->buf_width;	350	pix_mp->plane_fmt[1].bytesperline = ctx->buf_width;
@@ -382,10 +382,16 @@ static int vidioc_try_fmt(struct file file, void priv, struct v4l2_format *f)
382	mfc_err("Unsupported format for source.\n");	382	mfc_err("Unsupported format for source.\n");
383	return -EINVAL;	383	return -EINVAL;
384	}	384	}
385	if (!IS_MFCV6(dev) && (fmt->fourcc == V4L2_PIX_FMT_VP8)) {	385	if (fmt->codec_mode == S5P_FIMV_CODEC_NONE) {
386	mfc_err("Not supported format.\n");	386	mfc_err("Unknown codec\n");
387	return -EINVAL;	387	return -EINVAL;
388	}	388	}
		389	if (!IS_MFCV6(dev)) {
		390	if (fmt->fourcc == V4L2_PIX_FMT_VP8) {
		391	mfc_err("Not supported format.\n");
		392	return -EINVAL;
		393	}
		394	}
389	} else if (f->type == V4L2_BUF_TYPE_VIDEO_CAPTURE_MPLANE) {	395	} else if (f->type == V4L2_BUF_TYPE_VIDEO_CAPTURE_MPLANE) {
390	fmt = find_format(f, MFC_FMT_RAW);	396	fmt = find_format(f, MFC_FMT_RAW);
391	if (!fmt) {	397	if (!fmt) {
@@ -411,7 +417,6 @@ static int vidioc_s_fmt(struct file file, void priv, struct v4l2_format *f)
411	struct s5p_mfc_dev *dev = video_drvdata(file);	417	struct s5p_mfc_dev *dev = video_drvdata(file);
412	struct s5p_mfc_ctx *ctx = fh_to_ctx(priv);	418	struct s5p_mfc_ctx *ctx = fh_to_ctx(priv);
413	int ret = 0;	419	int ret = 0;
414	struct s5p_mfc_fmt *fmt;
415	struct v4l2_pix_format_mplane *pix_mp;	420	struct v4l2_pix_format_mplane *pix_mp;
416		421
417	mfc_debug_enter();	422	mfc_debug_enter();
@@ -425,54 +430,32 @@ static int vidioc_s_fmt(struct file file, void priv, struct v4l2_format *f)
425	goto out;	430	goto out;
426	}	431	}
427	if (f->type == V4L2_BUF_TYPE_VIDEO_CAPTURE_MPLANE) {	432	if (f->type == V4L2_BUF_TYPE_VIDEO_CAPTURE_MPLANE) {
428	fmt = find_format(f, MFC_FMT_RAW);	433	/* dst_fmt is validated by call to vidioc_try_fmt */
429	if (!fmt) {	434	ctx->dst_fmt = find_format(f, MFC_FMT_RAW);
430	mfc_err("Unsupported format for source.\n");	435	ret = 0;
431	return -EINVAL;
432	}
433	if (!IS_MFCV6(dev) && (fmt->fourcc != V4L2_PIX_FMT_NV12MT)) {
434	mfc_err("Not supported format.\n");
435	return -EINVAL;
436	} else if (IS_MFCV6(dev) &&
437	(fmt->fourcc == V4L2_PIX_FMT_NV12MT)) {
438	mfc_err("Not supported format.\n");
439	return -EINVAL;
440	}
441	ctx->dst_fmt = fmt;
442	mfc_debug_leave();
443	return ret;
444	} else if (f->type != V4L2_BUF_TYPE_VIDEO_OUTPUT_MPLANE) {
445	mfc_err("Wrong type error for S_FMT : %d", f->type);
446	return -EINVAL;
447	}
448	fmt = find_format(f, MFC_FMT_DEC);
449	if (!fmt \|\| fmt->codec_mode == S5P_MFC_CODEC_NONE) {
450	mfc_err("Unknown codec\n");
451	ret = -EINVAL;
452	goto out;	436	goto out;
453	}	437	} else if (f->type == V4L2_BUF_TYPE_VIDEO_OUTPUT_MPLANE) {
454	if (fmt->type != MFC_FMT_DEC) {	438	/* src_fmt is validated by call to vidioc_try_fmt */
455	mfc_err("Wrong format selected, you should choose "	439	ctx->src_fmt = find_format(f, MFC_FMT_DEC);
456	"format for decoding\n");	440	ctx->codec_mode = ctx->src_fmt->codec_mode;
		441	mfc_debug(2, "The codec number is: %d\n", ctx->codec_mode);
		442	pix_mp->height = 0;
		443	pix_mp->width = 0;
		444	if (pix_mp->plane_fmt[0].sizeimage)
		445	ctx->dec_src_buf_size = pix_mp->plane_fmt[0].sizeimage;
		446	else
		447	pix_mp->plane_fmt[0].sizeimage = ctx->dec_src_buf_size =
		448	DEF_CPB_SIZE;
		449	pix_mp->plane_fmt[0].bytesperline = 0;
		450	ctx->state = MFCINST_INIT;
		451	ret = 0;
		452	goto out;
		453	} else {
		454	mfc_err("Wrong type error for S_FMT : %d", f->type);
457	ret = -EINVAL;	455	ret = -EINVAL;
458	goto out;	456	goto out;
459	}	457	}
460	if (!IS_MFCV6(dev) && (fmt->fourcc == V4L2_PIX_FMT_VP8)) {	458
461	mfc_err("Not supported format.\n");
462	return -EINVAL;
463	}
464	ctx->src_fmt = fmt;
465	ctx->codec_mode = fmt->codec_mode;
466	mfc_debug(2, "The codec number is: %d\n", ctx->codec_mode);
467	pix_mp->height = 0;
468	pix_mp->width = 0;
469	if (pix_mp->plane_fmt[0].sizeimage)
470	ctx->dec_src_buf_size = pix_mp->plane_fmt[0].sizeimage;
471	else
472	pix_mp->plane_fmt[0].sizeimage = ctx->dec_src_buf_size =
473	DEF_CPB_SIZE;
474	pix_mp->plane_fmt[0].bytesperline = 0;
475	ctx->state = MFCINST_INIT;
476	out:	459	out:
477	mfc_debug_leave();	460	mfc_debug_leave();
478	return ret;	461	return ret;


diff --git a/drivers/media/platform/s5p-mfc/s5p_mfc_enc.c b/drivers/media/platform/s5p-mfc/s5p_mfc_enc.c index 2549967b2f85..59e56f4c8ce3 100644 --- a/drivers/media/platform/s5p-mfc/s5p_mfc_enc.c +++ b/drivers/media/platform/s5p-mfc/s5p_mfc_enc.c
@@ -906,6 +906,7 @@ static int vidioc_g_fmt(struct file file, void priv, struct v4l2_format *f)
906		906
907	static int vidioc_try_fmt(struct file file, void priv, struct v4l2_format *f)	907	static int vidioc_try_fmt(struct file file, void priv, struct v4l2_format *f)
908	{	908	{
		909	struct s5p_mfc_dev *dev = video_drvdata(file);
909	struct s5p_mfc_fmt *fmt;	910	struct s5p_mfc_fmt *fmt;
910	struct v4l2_pix_format_mplane *pix_fmt_mp = &f->fmt.pix_mp;	911	struct v4l2_pix_format_mplane *pix_fmt_mp = &f->fmt.pix_mp;
911		912
@@ -930,6 +931,18 @@ static int vidioc_try_fmt(struct file file, void priv, struct v4l2_format *f)
930	return -EINVAL;	931	return -EINVAL;
931	}	932	}
932		933
		934	if (!IS_MFCV6(dev)) {
		935	if (fmt->fourcc == V4L2_PIX_FMT_NV12MT_16X16) {
		936	mfc_err("Not supported format.\n");
		937	return -EINVAL;
		938	}
		939	} else if (IS_MFCV6(dev)) {
		940	if (fmt->fourcc == V4L2_PIX_FMT_NV12MT) {
		941	mfc_err("Not supported format.\n");
		942	return -EINVAL;
		943	}
		944	}
		945
933	if (fmt->num_planes != pix_fmt_mp->num_planes) {	946	if (fmt->num_planes != pix_fmt_mp->num_planes) {
934	mfc_err("failed to try output format\n");	947	mfc_err("failed to try output format\n");
935	return -EINVAL;	948	return -EINVAL;
@@ -947,7 +960,6 @@ static int vidioc_s_fmt(struct file file, void priv, struct v4l2_format *f)
947	{	960	{
948	struct s5p_mfc_dev *dev = video_drvdata(file);	961	struct s5p_mfc_dev *dev = video_drvdata(file);
949	struct s5p_mfc_ctx *ctx = fh_to_ctx(priv);	962	struct s5p_mfc_ctx *ctx = fh_to_ctx(priv);
950	struct s5p_mfc_fmt *fmt;
951	struct v4l2_pix_format_mplane *pix_fmt_mp = &f->fmt.pix_mp;	963	struct v4l2_pix_format_mplane *pix_fmt_mp = &f->fmt.pix_mp;
952	int ret = 0;	964	int ret = 0;
953		965
@@ -960,13 +972,9 @@ static int vidioc_s_fmt(struct file file, void priv, struct v4l2_format *f)
960	goto out;	972	goto out;
961	}	973	}
962	if (f->type == V4L2_BUF_TYPE_VIDEO_CAPTURE_MPLANE) {	974	if (f->type == V4L2_BUF_TYPE_VIDEO_CAPTURE_MPLANE) {
963	fmt = find_format(f, MFC_FMT_ENC);	975	/* dst_fmt is validated by call to vidioc_try_fmt */
964	if (!fmt) {	976	ctx->dst_fmt = find_format(f, MFC_FMT_ENC);
965	mfc_err("failed to set capture format\n");
966	return -EINVAL;
967	}
968	ctx->state = MFCINST_INIT;	977	ctx->state = MFCINST_INIT;
969	ctx->dst_fmt = fmt;
970	ctx->codec_mode = ctx->dst_fmt->codec_mode;	978	ctx->codec_mode = ctx->dst_fmt->codec_mode;
971	ctx->enc_dst_buf_size = pix_fmt_mp->plane_fmt[0].sizeimage;	979	ctx->enc_dst_buf_size = pix_fmt_mp->plane_fmt[0].sizeimage;
972	pix_fmt_mp->plane_fmt[0].bytesperline = 0;	980	pix_fmt_mp->plane_fmt[0].bytesperline = 0;
@@ -987,28 +995,8 @@ static int vidioc_s_fmt(struct file file, void priv, struct v4l2_format *f)
987	}	995	}
988	mfc_debug(2, "Got instance number: %d\n", ctx->inst_no);	996	mfc_debug(2, "Got instance number: %d\n", ctx->inst_no);
989	} else if (f->type == V4L2_BUF_TYPE_VIDEO_OUTPUT_MPLANE) {	997	} else if (f->type == V4L2_BUF_TYPE_VIDEO_OUTPUT_MPLANE) {
990	fmt = find_format(f, MFC_FMT_RAW);	998	/* src_fmt is validated by call to vidioc_try_fmt */
991	if (!fmt) {	999	ctx->src_fmt = find_format(f, MFC_FMT_RAW);
992	mfc_err("failed to set output format\n");
993	return -EINVAL;
994	}
995
996	if (!IS_MFCV6(dev) &&
997	(fmt->fourcc == V4L2_PIX_FMT_NV12MT_16X16)) {
998	mfc_err("Not supported format.\n");
999	return -EINVAL;
1000	} else if (IS_MFCV6(dev) &&
1001	(fmt->fourcc == V4L2_PIX_FMT_NV12MT)) {
1002	mfc_err("Not supported format.\n");
1003	return -EINVAL;
1004	}
1005
1006	if (fmt->num_planes != pix_fmt_mp->num_planes) {
1007	mfc_err("failed to set output format\n");
1008	ret = -EINVAL;
1009	goto out;
1010	}
1011	ctx->src_fmt = fmt;
1012	ctx->img_width = pix_fmt_mp->width;	1000	ctx->img_width = pix_fmt_mp->width;
1013	ctx->img_height = pix_fmt_mp->height;	1001	ctx->img_height = pix_fmt_mp->height;
1014	mfc_debug(2, "codec number: %d\n", ctx->src_fmt->codec_mode);	1002	mfc_debug(2, "codec number: %d\n", ctx->src_fmt->codec_mode);