diff options
author | Ondrej Zary <linux@rainbow-software.org> | 2013-02-01 18:01:17 -0500 |
---|---|---|
committer | Mauro Carvalho Chehab <mchehab@redhat.com> | 2013-04-14 18:00:28 -0400 |
commit | 0a5ea88b31bed56350939c6a99c4cd58904baa66 (patch) | |
tree | 6a73f7ae7abf3a09438cedf599a3d24706796cfd /drivers/media/pci/saa7134 | |
parent | 3bbaa3a60175ed120c8ab8937c21425fd744c7b7 (diff) |
[media] saa7134: v4l2-compliance: return real frequency
Make saa7134 driver more V4L2 compliant: don't cache frequency in
s_frequency/g_frequency but return real one instead
Signed-off-by: Ondrej Zary <linux@rainbow-software.org>
Signed-off-by: Hans Verkuil <hans.verkuil@cisco.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
Diffstat (limited to 'drivers/media/pci/saa7134')
-rw-r--r-- | drivers/media/pci/saa7134/saa7134-video.c | 6 | ||||
-rw-r--r-- | drivers/media/pci/saa7134/saa7134.h | 1 |
2 files changed, 4 insertions, 3 deletions
diff --git a/drivers/media/pci/saa7134/saa7134-video.c b/drivers/media/pci/saa7134/saa7134-video.c index 941e2ebab41d..506a9f401db7 100644 --- a/drivers/media/pci/saa7134/saa7134-video.c +++ b/drivers/media/pci/saa7134/saa7134-video.c | |||
@@ -2051,8 +2051,11 @@ static int saa7134_g_frequency(struct file *file, void *priv, | |||
2051 | struct saa7134_fh *fh = priv; | 2051 | struct saa7134_fh *fh = priv; |
2052 | struct saa7134_dev *dev = fh->dev; | 2052 | struct saa7134_dev *dev = fh->dev; |
2053 | 2053 | ||
2054 | if (0 != f->tuner) | ||
2055 | return -EINVAL; | ||
2056 | |||
2054 | f->type = fh->radio ? V4L2_TUNER_RADIO : V4L2_TUNER_ANALOG_TV; | 2057 | f->type = fh->radio ? V4L2_TUNER_RADIO : V4L2_TUNER_ANALOG_TV; |
2055 | f->frequency = dev->ctl_freq; | 2058 | saa_call_all(dev, tuner, g_frequency, f); |
2056 | 2059 | ||
2057 | return 0; | 2060 | return 0; |
2058 | } | 2061 | } |
@@ -2070,7 +2073,6 @@ static int saa7134_s_frequency(struct file *file, void *priv, | |||
2070 | if (1 == fh->radio && V4L2_TUNER_RADIO != f->type) | 2073 | if (1 == fh->radio && V4L2_TUNER_RADIO != f->type) |
2071 | return -EINVAL; | 2074 | return -EINVAL; |
2072 | mutex_lock(&dev->lock); | 2075 | mutex_lock(&dev->lock); |
2073 | dev->ctl_freq = f->frequency; | ||
2074 | 2076 | ||
2075 | saa_call_all(dev, tuner, s_frequency, f); | 2077 | saa_call_all(dev, tuner, s_frequency, f); |
2076 | 2078 | ||
diff --git a/drivers/media/pci/saa7134/saa7134.h b/drivers/media/pci/saa7134/saa7134.h index fc07b19ed536..d2ad16c1569a 100644 --- a/drivers/media/pci/saa7134/saa7134.h +++ b/drivers/media/pci/saa7134/saa7134.h | |||
@@ -607,7 +607,6 @@ struct saa7134_dev { | |||
607 | int ctl_contrast; | 607 | int ctl_contrast; |
608 | int ctl_hue; | 608 | int ctl_hue; |
609 | int ctl_saturation; | 609 | int ctl_saturation; |
610 | int ctl_freq; | ||
611 | int ctl_mute; /* audio */ | 610 | int ctl_mute; /* audio */ |
612 | int ctl_volume; | 611 | int ctl_volume; |
613 | int ctl_invert; /* private */ | 612 | int ctl_invert; /* private */ |