diff options
author | Kees Cook <keescook@chromium.org> | 2013-07-03 18:04:57 -0400 |
---|---|---|
committer | Linus Torvalds <torvalds@linux-foundation.org> | 2013-07-03 19:07:41 -0400 |
commit | d8537548c924db3c44afde7646b6e220c7beb79d (patch) | |
tree | 619ef33bab975df1946eb118f7d03e6aaed77515 /drivers/media/pci/cx18 | |
parent | 02aa2a37636c8fa4fb9322d91be46ff8225b7de0 (diff) |
drivers: avoid format strings in names passed to alloc_workqueue()
For the workqueue creation interfaces that do not expect format strings,
make sure they cannot accidently be parsed that way. Additionally, clean
up calls made with a single parameter that would be handled as a format
string. Many callers are passing potentially dynamic string content, so
use "%s" in those cases to avoid any potential accidents.
Signed-off-by: Kees Cook <keescook@chromium.org>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Diffstat (limited to 'drivers/media/pci/cx18')
-rw-r--r-- | drivers/media/pci/cx18/cx18-driver.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/media/pci/cx18/cx18-driver.c b/drivers/media/pci/cx18/cx18-driver.c index 67b61cf3e03a..004d8ace5019 100644 --- a/drivers/media/pci/cx18/cx18-driver.c +++ b/drivers/media/pci/cx18/cx18-driver.c | |||
@@ -695,7 +695,7 @@ static int cx18_create_in_workq(struct cx18 *cx) | |||
695 | { | 695 | { |
696 | snprintf(cx->in_workq_name, sizeof(cx->in_workq_name), "%s-in", | 696 | snprintf(cx->in_workq_name, sizeof(cx->in_workq_name), "%s-in", |
697 | cx->v4l2_dev.name); | 697 | cx->v4l2_dev.name); |
698 | cx->in_work_queue = alloc_ordered_workqueue(cx->in_workq_name, 0); | 698 | cx->in_work_queue = alloc_ordered_workqueue("%s", 0, cx->in_workq_name); |
699 | if (cx->in_work_queue == NULL) { | 699 | if (cx->in_work_queue == NULL) { |
700 | CX18_ERR("Unable to create incoming mailbox handler thread\n"); | 700 | CX18_ERR("Unable to create incoming mailbox handler thread\n"); |
701 | return -ENOMEM; | 701 | return -ENOMEM; |