aboutsummaryrefslogtreecommitdiffstats
path: root/drivers/media/pci/bt8xx/dst_ca.c
diff options
context:
space:
mode:
authorNickolai Zeldovich <nickolai@csail.mit.edu>2013-01-07 20:28:05 -0500
committerMauro Carvalho Chehab <mchehab@redhat.com>2013-02-05 16:26:38 -0500
commitbb71b14d80bde8484ae63ee09d969c72d8615e0c (patch)
tree33a3cb8bb2419c1a46d669a331f79c66e12cf4f3 /drivers/media/pci/bt8xx/dst_ca.c
parent22331a5e0a493f8edfbd504bb58bd03d308ddb0c (diff)
[media] drivers/media/pci: use memmove for overlapping regions
Change several memcpy() to memmove() in cases when the regions are definitely overlapping; memcpy() of overlapping regions is undefined behavior in C and can produce different results depending on the compiler, the memcpy implementation, etc. Cc: Andy Walls <awalls@md.metrocast.net> Signed-off-by: Nickolai Zeldovich <nickolai@csail.mit.edu> Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
Diffstat (limited to 'drivers/media/pci/bt8xx/dst_ca.c')
-rw-r--r--drivers/media/pci/bt8xx/dst_ca.c4
1 files changed, 2 insertions, 2 deletions
diff --git a/drivers/media/pci/bt8xx/dst_ca.c b/drivers/media/pci/bt8xx/dst_ca.c
index 7d96fab7d246..0e788fca992c 100644
--- a/drivers/media/pci/bt8xx/dst_ca.c
+++ b/drivers/media/pci/bt8xx/dst_ca.c
@@ -180,11 +180,11 @@ static int ca_get_app_info(struct dst_state *state)
180 put_command_and_length(&state->messages[0], CA_APP_INFO, length); 180 put_command_and_length(&state->messages[0], CA_APP_INFO, length);
181 181
182 // Copy application_type, application_manufacturer and manufacturer_code 182 // Copy application_type, application_manufacturer and manufacturer_code
183 memcpy(&state->messages[4], &state->messages[7], 5); 183 memmove(&state->messages[4], &state->messages[7], 5);
184 184
185 // Set string length and copy string 185 // Set string length and copy string
186 state->messages[9] = str_length; 186 state->messages[9] = str_length;
187 memcpy(&state->messages[10], &state->messages[12], str_length); 187 memmove(&state->messages[10], &state->messages[12], str_length);
188 188
189 return 0; 189 return 0;
190} 190}