diff options
author | Peter Beutner <p.beutner@gmx.net> | 2005-07-07 20:57:39 -0400 |
---|---|---|
committer | Linus Torvalds <torvalds@g5.osdl.org> | 2005-07-07 21:23:54 -0400 |
commit | 3ec4a30771ed9a0ce6f05e637ea83b3781cc61d7 (patch) | |
tree | d883cc6e133d447eace15f64d4e187492d5f674e /drivers/media/dvb | |
parent | 761979248adf83f5bece22e058ec445511984012 (diff) |
[PATCH] dvb: core: dmxdev cleanups
- remove void casts
- not necessary to set filter state twice to STATE_FREE during
dvb_dmxdev_init()
Signed-off-by: Peter Beutner <p.beutner@gmx.net>
Signed-off-by: Johannes Stezenbach <js@linuxtv.org>
Signed-off-by: Andrew Morton <akpm@osdl.org>
Signed-off-by: Linus Torvalds <torvalds@osdl.org>
Diffstat (limited to 'drivers/media/dvb')
-rw-r--r-- | drivers/media/dvb/dvb-core/dmxdev.c | 15 |
1 files changed, 4 insertions, 11 deletions
diff --git a/drivers/media/dvb/dvb-core/dmxdev.c b/drivers/media/dvb/dvb-core/dmxdev.c index 1624f4be5ea7..68050cd527cb 100644 --- a/drivers/media/dvb/dvb-core/dmxdev.c +++ b/drivers/media/dvb/dvb-core/dmxdev.c | |||
@@ -42,12 +42,6 @@ MODULE_PARM_DESC(debug, "Turn on/off debugging (default:off)."); | |||
42 | 42 | ||
43 | #define dprintk if (debug) printk | 43 | #define dprintk if (debug) printk |
44 | 44 | ||
45 | static inline struct dmxdev_filter * | ||
46 | dvb_dmxdev_file_to_filter(struct file *file) | ||
47 | { | ||
48 | return (struct dmxdev_filter *) file->private_data; | ||
49 | } | ||
50 | |||
51 | static inline void dvb_dmxdev_buffer_init(struct dmxdev_buffer *buffer) | 45 | static inline void dvb_dmxdev_buffer_init(struct dmxdev_buffer *buffer) |
52 | { | 46 | { |
53 | buffer->data=NULL; | 47 | buffer->data=NULL; |
@@ -844,7 +838,7 @@ static ssize_t dvb_dmxdev_read_sec(struct dmxdev_filter *dfil, | |||
844 | static ssize_t | 838 | static ssize_t |
845 | dvb_demux_read(struct file *file, char __user *buf, size_t count, loff_t *ppos) | 839 | dvb_demux_read(struct file *file, char __user *buf, size_t count, loff_t *ppos) |
846 | { | 840 | { |
847 | struct dmxdev_filter *dmxdevfilter=dvb_dmxdev_file_to_filter(file); | 841 | struct dmxdev_filter *dmxdevfilter= file->private_data; |
848 | int ret=0; | 842 | int ret=0; |
849 | 843 | ||
850 | if (down_interruptible(&dmxdevfilter->mutex)) | 844 | if (down_interruptible(&dmxdevfilter->mutex)) |
@@ -865,7 +859,7 @@ dvb_demux_read(struct file *file, char __user *buf, size_t count, loff_t *ppos) | |||
865 | static int dvb_demux_do_ioctl(struct inode *inode, struct file *file, | 859 | static int dvb_demux_do_ioctl(struct inode *inode, struct file *file, |
866 | unsigned int cmd, void *parg) | 860 | unsigned int cmd, void *parg) |
867 | { | 861 | { |
868 | struct dmxdev_filter *dmxdevfilter=dvb_dmxdev_file_to_filter(file); | 862 | struct dmxdev_filter *dmxdevfilter = file->private_data; |
869 | struct dmxdev *dmxdev=dmxdevfilter->dev; | 863 | struct dmxdev *dmxdev=dmxdevfilter->dev; |
870 | unsigned long arg=(unsigned long) parg; | 864 | unsigned long arg=(unsigned long) parg; |
871 | int ret=0; | 865 | int ret=0; |
@@ -962,7 +956,7 @@ static int dvb_demux_ioctl(struct inode *inode, struct file *file, | |||
962 | 956 | ||
963 | static unsigned int dvb_demux_poll (struct file *file, poll_table *wait) | 957 | static unsigned int dvb_demux_poll (struct file *file, poll_table *wait) |
964 | { | 958 | { |
965 | struct dmxdev_filter *dmxdevfilter = dvb_dmxdev_file_to_filter(file); | 959 | struct dmxdev_filter *dmxdevfilter = file->private_data; |
966 | unsigned int mask = 0; | 960 | unsigned int mask = 0; |
967 | 961 | ||
968 | if (!dmxdevfilter) | 962 | if (!dmxdevfilter) |
@@ -987,7 +981,7 @@ static unsigned int dvb_demux_poll (struct file *file, poll_table *wait) | |||
987 | 981 | ||
988 | static int dvb_demux_release(struct inode *inode, struct file *file) | 982 | static int dvb_demux_release(struct inode *inode, struct file *file) |
989 | { | 983 | { |
990 | struct dmxdev_filter *dmxdevfilter = dvb_dmxdev_file_to_filter(file); | 984 | struct dmxdev_filter *dmxdevfilter = file->private_data; |
991 | struct dmxdev *dmxdev = dmxdevfilter->dev; | 985 | struct dmxdev *dmxdev = dmxdevfilter->dev; |
992 | 986 | ||
993 | return dvb_dmxdev_filter_free(dmxdev, dmxdevfilter); | 987 | return dvb_dmxdev_filter_free(dmxdev, dmxdevfilter); |
@@ -1111,7 +1105,6 @@ dvb_dmxdev_init(struct dmxdev *dmxdev, struct dvb_adapter *dvb_adapter) | |||
1111 | dvb_dmxdev_filter_state_set(&dmxdev->filter[i], DMXDEV_STATE_FREE); | 1105 | dvb_dmxdev_filter_state_set(&dmxdev->filter[i], DMXDEV_STATE_FREE); |
1112 | dmxdev->dvr[i].dev=dmxdev; | 1106 | dmxdev->dvr[i].dev=dmxdev; |
1113 | dmxdev->dvr[i].buffer.data=NULL; | 1107 | dmxdev->dvr[i].buffer.data=NULL; |
1114 | dvb_dmxdev_filter_state_set(&dmxdev->filter[i], DMXDEV_STATE_FREE); | ||
1115 | dvb_dmxdev_dvr_state_set(&dmxdev->dvr[i], DMXDEV_STATE_FREE); | 1108 | dvb_dmxdev_dvr_state_set(&dmxdev->dvr[i], DMXDEV_STATE_FREE); |
1116 | } | 1109 | } |
1117 | 1110 | ||