diff options
author | Mauro Carvalho Chehab <m.chehab@samsung.com> | 2014-01-17 14:02:09 -0500 |
---|---|---|
committer | Mauro Carvalho Chehab <m.chehab@samsung.com> | 2014-03-04 12:30:55 -0500 |
commit | 9cf5370e3150f853cd9fa5a2537d6eb69acd703b (patch) | |
tree | be9173e61aa75edeafe8c85f440609ad60c34719 /drivers/media/dvb-frontends/drx39xyj | |
parent | 2f1f733386ce6dac70c0936b81b9f630ddfb1837 (diff) |
[media] drx-j: remove the useless microcode_size
This var is not used. Remove it from the code, as we'll now be
converting the driver to load the firmware from an external
file.
Acked-by: Devin Heitmueller <dheitmueller@kernellabs.com>
Signed-off-by: Mauro Carvalho Chehab <m.chehab@samsung.com>
Diffstat (limited to 'drivers/media/dvb-frontends/drx39xyj')
-rw-r--r-- | drivers/media/dvb-frontends/drx39xyj/drx_driver.h | 4 | ||||
-rw-r--r-- | drivers/media/dvb-frontends/drx39xyj/drxj.c | 10 |
2 files changed, 3 insertions, 11 deletions
diff --git a/drivers/media/dvb-frontends/drx39xyj/drx_driver.h b/drivers/media/dvb-frontends/drx39xyj/drx_driver.h index c36321b9dd72..f5add1a72dd6 100644 --- a/drivers/media/dvb-frontends/drx39xyj/drx_driver.h +++ b/drivers/media/dvb-frontends/drx39xyj/drx_driver.h | |||
@@ -1021,8 +1021,6 @@ STRUCTS | |||
1021 | struct drxu_code_info { | 1021 | struct drxu_code_info { |
1022 | u8 *mc_data; | 1022 | u8 *mc_data; |
1023 | /**< Pointer to microcode image. */ | 1023 | /**< Pointer to microcode image. */ |
1024 | u16 mc_size; | ||
1025 | /**< Microcode image size. */ | ||
1026 | }; | 1024 | }; |
1027 | 1025 | ||
1028 | /** | 1026 | /** |
@@ -1932,7 +1930,6 @@ struct drx_reg_dump { | |||
1932 | struct drx_common_attr { | 1930 | struct drx_common_attr { |
1933 | /* Microcode (firmware) attributes */ | 1931 | /* Microcode (firmware) attributes */ |
1934 | u8 *microcode; /**< Pointer to microcode image. */ | 1932 | u8 *microcode; /**< Pointer to microcode image. */ |
1935 | u16 microcode_size; | ||
1936 | /**< Size of microcode image in bytes. */ | 1933 | /**< Size of microcode image in bytes. */ |
1937 | bool verify_microcode; | 1934 | bool verify_microcode; |
1938 | /**< Use microcode verify or not. */ | 1935 | /**< Use microcode verify or not. */ |
@@ -2351,7 +2348,6 @@ Access macros | |||
2351 | #define DRX_ATTR_CACHESTANDARD(d) ((d)->my_common_attr->di_cache_standard) | 2348 | #define DRX_ATTR_CACHESTANDARD(d) ((d)->my_common_attr->di_cache_standard) |
2352 | #define DRX_ATTR_CURRENTCHANNEL(d) ((d)->my_common_attr->current_channel) | 2349 | #define DRX_ATTR_CURRENTCHANNEL(d) ((d)->my_common_attr->current_channel) |
2353 | #define DRX_ATTR_MICROCODE(d) ((d)->my_common_attr->microcode) | 2350 | #define DRX_ATTR_MICROCODE(d) ((d)->my_common_attr->microcode) |
2354 | #define DRX_ATTR_MICROCODESIZE(d) ((d)->my_common_attr->microcode_size) | ||
2355 | #define DRX_ATTR_VERIFYMICROCODE(d) ((d)->my_common_attr->verify_microcode) | 2351 | #define DRX_ATTR_VERIFYMICROCODE(d) ((d)->my_common_attr->verify_microcode) |
2356 | #define DRX_ATTR_CAPABILITIES(d) ((d)->my_common_attr->capabilities) | 2352 | #define DRX_ATTR_CAPABILITIES(d) ((d)->my_common_attr->capabilities) |
2357 | #define DRX_ATTR_PRODUCTID(d) ((d)->my_common_attr->product_id) | 2353 | #define DRX_ATTR_PRODUCTID(d) ((d)->my_common_attr->product_id) |
diff --git a/drivers/media/dvb-frontends/drx39xyj/drxj.c b/drivers/media/dvb-frontends/drx39xyj/drxj.c index c04745202c49..e21dd5a7dd2b 100644 --- a/drivers/media/dvb-frontends/drx39xyj/drxj.c +++ b/drivers/media/dvb-frontends/drx39xyj/drxj.c | |||
@@ -876,7 +876,6 @@ struct i2c_device_addr drxj_default_addr_g = { | |||
876 | */ | 876 | */ |
877 | struct drx_common_attr drxj_default_comm_attr_g = { | 877 | struct drx_common_attr drxj_default_comm_attr_g = { |
878 | (u8 *)NULL, /* ucode ptr */ | 878 | (u8 *)NULL, /* ucode ptr */ |
879 | 0, /* ucode size */ | ||
880 | true, /* ucode verify switch */ | 879 | true, /* ucode verify switch */ |
881 | {0}, /* version record */ | 880 | {0}, /* version record */ |
882 | 881 | ||
@@ -12171,7 +12170,6 @@ trouble ? | |||
12171 | /* Check if audio microcode is already uploaded */ | 12170 | /* Check if audio microcode is already uploaded */ |
12172 | if (!(ext_attr->flag_aud_mc_uploaded)) { | 12171 | if (!(ext_attr->flag_aud_mc_uploaded)) { |
12173 | ucode_info.mc_data = common_attr->microcode; | 12172 | ucode_info.mc_data = common_attr->microcode; |
12174 | ucode_info.mc_size = common_attr->microcode_size; | ||
12175 | 12173 | ||
12176 | /* Upload only audio microcode */ | 12174 | /* Upload only audio microcode */ |
12177 | rc = ctrl_u_code_upload(demod, &ucode_info, UCODE_UPLOAD, true); | 12175 | rc = ctrl_u_code_upload(demod, &ucode_info, UCODE_UPLOAD, true); |
@@ -18831,8 +18829,8 @@ bool is_mc_block_audio(u32 addr) | |||
18831 | */ | 18829 | */ |
18832 | static int | 18830 | static int |
18833 | ctrl_u_code_upload(struct drx_demod_instance *demod, | 18831 | ctrl_u_code_upload(struct drx_demod_instance *demod, |
18834 | struct drxu_code_info *mc_info, | 18832 | struct drxu_code_info *mc_info, |
18835 | enum drxu_code_actionaction, bool upload_audio_mc) | 18833 | enum drxu_code_actionaction, bool upload_audio_mc) |
18836 | { | 18834 | { |
18837 | u16 i = 0; | 18835 | u16 i = 0; |
18838 | u16 mc_nr_of_blks = 0; | 18836 | u16 mc_nr_of_blks = 0; |
@@ -18846,8 +18844,7 @@ ctrl_u_code_upload(struct drx_demod_instance *demod, | |||
18846 | ext_attr = (struct drxj_data *) demod->my_ext_attr; | 18844 | ext_attr = (struct drxj_data *) demod->my_ext_attr; |
18847 | 18845 | ||
18848 | /* Check arguments */ | 18846 | /* Check arguments */ |
18849 | if ((mc_info == NULL) || | 18847 | if (!mc_info || !mc_info->mc_data) { |
18850 | (mc_info->mc_data == NULL) || (mc_info->mc_size == 0)) { | ||
18851 | return -EINVAL; | 18848 | return -EINVAL; |
18852 | } | 18849 | } |
18853 | 18850 | ||
@@ -20147,7 +20144,6 @@ int drxj_open(struct drx_demod_instance *demod) | |||
20147 | pretend device is already open */ | 20144 | pretend device is already open */ |
20148 | common_attr->is_opened = true; | 20145 | common_attr->is_opened = true; |
20149 | ucode_info.mc_data = common_attr->microcode; | 20146 | ucode_info.mc_data = common_attr->microcode; |
20150 | ucode_info.mc_size = common_attr->microcode_size; | ||
20151 | 20147 | ||
20152 | #ifdef DRXJ_SPLIT_UCODE_UPLOAD | 20148 | #ifdef DRXJ_SPLIT_UCODE_UPLOAD |
20153 | /* Upload microcode without audio part */ | 20149 | /* Upload microcode without audio part */ |